NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-11 07:55:58 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix minor details not only in apic eoi

Browse Source 
The introduction of APIC EOI patches had a few little details that
could look better, so this patch fixes that and one more place in the
file as well (same problem).
This commit is contained in:
Martin Kletzander 2012-09-18 11:40:52 +02:00
parent 54106114a4
commit e6bd3ce056
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/formatdomain.html.in
View File

@ -1020,9 +1020,9 @@
</dd> </dd>
<dt><code>apic</code></dt> <dt><code>apic</code></dt>
<dd>APIC allows the use of programmable IRQ <dd>APIC allows the use of programmable IRQ
management. <span class="since">Since 0.10.2 (QEMU only)</span> management. <span class="since">Since 0.10.2 (QEMU only)</span> there is
there is an optional attribute <code>eoi</code> with values "on" an optional attribute <code>eoi</code> with values <code>on</code>
and "off" which toggles the availability of EOI (End of and <code>off</code> which toggles the availability of EOI (End of
Interrupt) for the guest. Interrupt) for the guest.
</dd> </dd>
<dt><code>hap</code></dt> <dt><code>hap</code></dt>

5
src/conf/domain_conf.c
View File

@ -8617,7 +8617,6 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps,
virReportError(VIR_ERR_XML_ERROR, virReportError(VIR_ERR_XML_ERROR,
_("Unsupported CPU placement mode '%s'"), _("Unsupported CPU placement mode '%s'"),
tmp); tmp);
VIR_FREE(tmp);
goto error; goto error;
} }
VIR_FREE(tmp); VIR_FREE(tmp);
@ -8851,7 +8850,6 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps,
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("unknown value for attribute eoi: %s"), _("unknown value for attribute eoi: %s"),
tmp); tmp);
VIR_FREE(tmp);
goto error; goto error;
} }
def->apic_eoi = eoi; def->apic_eoi = eoi;
@ -13433,6 +13431,7 @@ virDomainDefFormatInternal(virDomainDefPtr def,
} }
virBufferAddLit(buf, " <os>\n"); virBufferAddLit(buf, " <os>\n");
virBufferAddLit(buf, " <type"); virBufferAddLit(buf, " <type");
if (def->os.arch) if (def->os.arch)
virBufferAsprintf(buf, " arch='%s'", def->os.arch); virBufferAsprintf(buf, " arch='%s'", def->os.arch);
@ -13523,7 +13522,7 @@ virDomainDefFormatInternal(virDomainDefPtr def,
" eoi='%s'", " eoi='%s'",
virDomainApicEoiTypeToString(def->apic_eoi)); virDomainApicEoiTypeToString(def->apic_eoi));
} }
virBufferAsprintf(buf, "/>\n"); virBufferAddLit(buf, "/>\n");
} }
} }
virBufferAddLit(buf, " </features>\n"); virBufferAddLit(buf, " </features>\n");