From e97d7733fea2b6089ff706f19101f1226716350d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
Date: Mon, 11 Feb 2019 14:21:35 +0000
Subject: [PATCH] virsh: fix return value in storage vol name completor
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The function must return a pointer, not a boolean. Fortunately 'false'
is equivalent to 'NULL' so this bug no had ill effect previously.

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tools/virsh-completer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c
index e62226fc13..7c68e2e832 100644
--- a/tools/virsh-completer.c
+++ b/tools/virsh-completer.c
@@ -287,7 +287,7 @@ virshStorageVolNameCompleter(vshControl *ctl,
         return NULL;
 
     if (!(pool = virshCommandOptPool(ctl, cmd, "pool", NULL)))
-        return false;
+        return NULL;
 
     if ((nvols = virStoragePoolListAllVolumes(pool, &vols, flags)) < 0)
         goto error;