NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

logging: confirm that we want to ignore a write error

Browse Source 
* src/util/logging.c (virLogMessage): Include "ignore-value.h".
Use it to ignore the return value of safewrite.
Use STDERR_FILENO, rather than "2".
* bootstrap (modules): Add ignore-value.
* gnulib: Update to latest, for ignore-value that is now LGPLv2+.
This commit is contained in:
Jim Meyering
2010-01-18 11:51:01 +01:00
parent 8cfc4c9a03
commit eb895e7407
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.gnulib

Submodule .gnulib updated: 4c52807f41...146d914507

1
bootstrap
View File

@@ -76,6 +76,7 @@ getpass
gettext gettext
gitlog-to-changelog gitlog-to-changelog
gnumakefile gnumakefile
ignore-value
inet_pton inet_pton
ioctl ioctl
maintainer-makefile maintainer-makefile

5
src/util/logging.c
View File

@@ -1,7 +1,7 @@
/* /*
* logging.c: internal logging and debugging * logging.c: internal logging and debugging
* *
* Copyright (C) 2008 Red Hat, Inc. * Copyright (C) 2008, 2010 Red Hat, Inc.
* *
* This library is free software; you can redistribute it and/or * This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public * modify it under the terms of the GNU Lesser General Public
@@ -34,6 +34,7 @@
#include <syslog.h> #include <syslog.h>
#endif #endif
#include "ignore-value.h"
#include "logging.h" #include "logging.h"
#include "memory.h" #include "memory.h"
#include "util.h" #include "util.h"
@@ -579,7 +580,7 @@ void virLogMessage(const char *category, int priority, const char *funcname,
msg, len, virLogOutputs[i].data); msg, len, virLogOutputs[i].data);
} }
if ((virLogNbOutputs == 0) && (flags != 1)) if ((virLogNbOutputs == 0) && (flags != 1))
safewrite(2, msg, len); ignore_value (safewrite(STDERR_FILENO, msg, len));
virLogUnlock(); virLogUnlock();
VIR_FREE(msg); VIR_FREE(msg);