NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

qemuDomainAttachDeviceDiskLiveInternal: Absorb qemuDomainAttachVirtioDiskDevice

Browse Source 
Move the specific device setup and address reservation code into the
main hotplug helper as it's just one extra function call.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Peter Krempa 2021-05-18 15:10:22 +02:00
parent f7fbdbb52f
commit f60135d37a
1 changed files with 8 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/qemu/qemu_hotplug.c
View File

@ -798,29 +798,6 @@ qemuDomainAttachDiskGeneric(virQEMUDriver *driver,
} }
static int
qemuDomainAttachVirtioDiskDevice(virQEMUDriver *driver,
virDomainObj *vm,
virDomainDiskDef *disk)
{
virDomainDeviceDef dev = { VIR_DOMAIN_DEVICE_DISK, { .disk = disk } };
bool releaseaddr = false;
int rv;
if (qemuDomainEnsureVirtioAddress(&releaseaddr, vm, &dev, disk->dst) < 0)
return -1;
if ((rv = qemuDomainAttachDiskGeneric(driver, vm, disk)) < 0) {
if (rv == -1 && releaseaddr)
qemuDomainReleaseDeviceAddress(vm, &disk->info);
return -1;
}
return 0;
}
int qemuDomainAttachControllerDevice(virQEMUDriver *driver, int qemuDomainAttachControllerDevice(virQEMUDriver *driver,
virDomainObj *vm, virDomainObj *vm,
virDomainControllerDef *controller) virDomainControllerDef *controller)
@ -1005,6 +982,7 @@ qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriver *driver,
size_t i; size_t i;
virDomainDiskDef *disk = dev->data.disk; virDomainDiskDef *disk = dev->data.disk;
bool releaseUSB = false; bool releaseUSB = false;
bool releaseVirtio = false;
int ret = -1; int ret = -1;
if (disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM || if (disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ||
@ -1054,7 +1032,10 @@ qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriver *driver,
break; break;
case VIR_DOMAIN_DISK_BUS_VIRTIO: case VIR_DOMAIN_DISK_BUS_VIRTIO:
ret = qemuDomainAttachVirtioDiskDevice(driver, vm, disk); if (qemuDomainEnsureVirtioAddress(&releaseVirtio, vm, dev, disk->dst) < 0)
goto cleanup;
ret = qemuDomainAttachDiskGeneric(driver, vm, disk);
break; break;
case VIR_DOMAIN_DISK_BUS_SCSI: case VIR_DOMAIN_DISK_BUS_SCSI:
@ -1083,6 +1064,9 @@ qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriver *driver,
if (releaseUSB) if (releaseUSB)
virDomainUSBAddressRelease(priv->usbaddrs, &disk->info); virDomainUSBAddressRelease(priv->usbaddrs, &disk->info);
if (releaseVirtio && ret == -1)
qemuDomainReleaseDeviceAddress(vm, &disk->info);
} }
return ret; return ret;