From f78e2495e5eb6168da75eb866eb5cb8bd92ac0f5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A1n=20Tomko?= <jtomko@redhat.com>
Date: Tue, 10 Aug 2021 17:10:34 +0200
Subject: [PATCH] vsh: cmdEcho: use separate variable for argument
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Do not use 'arg' which is later used for an allocated string.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---
 tools/vsh.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tools/vsh.c b/tools/vsh.c
index 3bbaecd2ea..bf32a8dc22 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -3199,17 +3199,16 @@ cmdEcho(vshControl *ctl, const vshCmd *cmd)
     while ((opt = vshCommandOptArgv(ctl, cmd, opt))) {
         char *str;
         g_auto(virBuffer) xmlbuf = VIR_BUFFER_INITIALIZER;
-
-        arg = opt->data;
+        const char *curr = opt->data;
 
         if (count)
             virBufferAddChar(&buf, ' ');
 
         if (xml) {
-            virBufferEscapeString(&xmlbuf, "%s", arg);
+            virBufferEscapeString(&xmlbuf, "%s", curr);
             str = virBufferContentAndReset(&xmlbuf);
         } else {
-            str = g_strdup(arg);
+            str = g_strdup(curr);
         }
 
         if (shell)