From fbf8e1c3144739454cebbac8aa4f8b8c5031ee03 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Tue, 24 Sep 2013 16:09:36 +0100 Subject: [PATCH] Fix leak in virDomainVcpuPinDefArrayFree If virDomainVcpuPinDefArrayFree is called with def != NULL, but nvcpupin == 0, then it leaks memory for 'def'. This is an unusual scenario, but it hits when cleaning up after an OOM during parsing of XML. Signed-off-by: Daniel P. Berrange --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4110127f92..152672acf1 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1854,7 +1854,7 @@ virDomainVcpuPinDefArrayFree(virDomainVcpuPinDefPtr *def, { size_t i; - if (!def || !nvcpupin) + if (!def) return; for (i = 0; i < nvcpupin; i++) {