NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2026-09-03 20:53:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

qemuBuildControllersByTypeCommandLine: free devstr in the cleanup

Browse Source 
section

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Ján Tomko
2019-01-25 14:58:43 +01:00
parent c7e03df8c0
commit fc1c16bccd
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/qemu/qemu_command.c
+4 -5
View File
@@ -3145,12 +3145,12 @@ qemuBuildControllersByTypeCommandLine(virCommandPtr cmd,
virQEMUCapsPtr qemuCaps, virQEMUCapsPtr qemuCaps,
virDomainControllerType type) virDomainControllerType type)
{ {
char *devstr = NULL;
int ret = -1; int ret = -1;
size_t i; size_t i;
for (i = 0; i < def->ncontrollers; i++) { for (i = 0; i < def->ncontrollers; i++) {
virDomainControllerDefPtr cont = def->controllers[i]; virDomainControllerDefPtr cont = def->controllers[i];
char *devstr;
if (cont->type != type) if (cont->type != type)
continue; continue;
@@ -3183,23 +3183,22 @@ qemuBuildControllersByTypeCommandLine(virCommandPtr cmd,
continue; continue;
} }
VIR_FREE(devstr);
if (qemuBuildControllerDevStr(def, cont, qemuCaps, &devstr) < 0) if (qemuBuildControllerDevStr(def, cont, qemuCaps, &devstr) < 0)
goto cleanup; goto cleanup;
if (devstr) { if (devstr) {
if (qemuCommandAddExtDevice(cmd, &cont->info) < 0) { if (qemuCommandAddExtDevice(cmd, &cont->info) < 0)
VIR_FREE(devstr);
goto cleanup; goto cleanup;
}
virCommandAddArg(cmd, "-device"); virCommandAddArg(cmd, "-device");
virCommandAddArg(cmd, devstr); virCommandAddArg(cmd, devstr);
VIR_FREE(devstr);
} }
} }
ret = 0; ret = 0;
cleanup: cleanup:
VIR_FREE(devstr);
return ret; return ret;
} }