mirror of
https://github.com/libvirt/libvirt.git
synced 2026-09-03 20:53:04 -05:00
While it may seem that zero detection is pointless for backing chain layers other than the top one, which is usually the only one gettin written to, with block operations such as active-layer commit the non-top layer may become active, in which case the VM wouldn't be configured in accordance to the XML any more. Similarly with snapshots a new image is introduced which would not get zero detection enabled, but next start of the VM would enable it. Fix this by propagating the zero detection setting for all layers. This problem partially addresses one of the issues reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1120389 Fixes:8a78f88a1aanda522c3044b(effectively reverts them) Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com>
69 lines
1.2 KiB
JSON
69 lines
1.2 KiB
JSON
{
|
|
"node-name": "node-a-f",
|
|
"read-only": false,
|
|
"discard": "unmap",
|
|
"detect-zeroes": "unmap",
|
|
"driver": "qcow",
|
|
"file": "node-a-s",
|
|
"backing": "node-b-f"
|
|
}
|
|
{
|
|
"driver": "file",
|
|
"filename": "/var/lib/libvirt/images/a",
|
|
"node-name": "node-a-s",
|
|
"auto-read-only": true,
|
|
"discard": "unmap"
|
|
}
|
|
{
|
|
"node-name": "node-b-f",
|
|
"read-only": true,
|
|
"discard": "unmap",
|
|
"detect-zeroes": "unmap",
|
|
"driver": "qed",
|
|
"file": "node-b-s",
|
|
"backing": "node-c-f"
|
|
}
|
|
{
|
|
"driver": "file",
|
|
"filename": "/var/lib/libvirt/images/b",
|
|
"node-name": "node-b-s",
|
|
"auto-read-only": true,
|
|
"discard": "unmap"
|
|
}
|
|
{
|
|
"node-name": "node-c-f",
|
|
"read-only": true,
|
|
"discard": "unmap",
|
|
"detect-zeroes": "unmap",
|
|
"driver": "vmdk",
|
|
"file": "node-c-s",
|
|
"backing": "node-d-f"
|
|
}
|
|
{
|
|
"driver": "nbd",
|
|
"server": {
|
|
"type": "inet",
|
|
"host": "test.org",
|
|
"port": "10809"
|
|
},
|
|
"export": "images/c",
|
|
"node-name": "node-c-s",
|
|
"auto-read-only": true,
|
|
"discard": "unmap"
|
|
}
|
|
{
|
|
"node-name": "node-d-f",
|
|
"read-only": true,
|
|
"discard": "unmap",
|
|
"detect-zeroes": "unmap",
|
|
"driver": "raw",
|
|
"file": "node-d-s"
|
|
}
|
|
{
|
|
"driver": "file",
|
|
"filename": "/var/lib/libvirt/images/d",
|
|
"node-name": "node-d-s",
|
|
"auto-read-only": true,
|
|
"discard": "unmap"
|
|
}
|