mirror of
https://github.com/libvirt/libvirt.git
synced 2026-10-02 12:20:06 -05:00
Michal Privoznik
ee8381e729
The networkxml2xmltest does basic parse -> format tests. The networkxml2conftest does parse -> conf tests. Now, majority of XMLs are the same. That is, output XMLs of networkxml2xmltest and input XMls of networkxml2conftest. There are only a few differences. This is actually great, because it will allow either tests to do both test cases. There are some (subtle) differences in individual test cases though: 1) some test cases exist only in networkxml2conftest and not networkxml2xmltest, or 2) some test cases in networkxml2conftest have more values, i.e. extra elements, extra attributes. or 3) some test cases in networkxml2conftest have less values. For cases from 1) they were just copied over. For cases from 2) those extra elements/attributes were added, and for cases from 3) those extra attributes were removed (to minimize changes to .conf files in near future). One caveat though: networkxml2xmlupdatetest uses input XMLs of networkxml2xmltest too (hence changes under networkxml2xmlupdateout/ dir). This means that the "delete-srv-record-protocol" test started failing, because the input network XML now has more <srv/> records than the test case anticipated. But this is easy to fix - hence seemingly unrelated change under networkxml2xmlupdatein/ dir. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>