NuKVM/libvirt
3
0 Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2026-10-02 12:20:06 -05:00
Code Issues Packages Projects Releases Wiki Activity
Files
8f0cf96b66b5f34f1134b3ff4e76a7cb1c3cfbb6
libvirt/tools
T
History
Michal Privoznik 8f0cf96b66 libvirt-guests.sh: Declare and assign separately to avoid masking return values 
In Bash, the following code does not do what you think it does:

  func() {
      local var=$(false)
      echo $?
  }

Here, '0' is echoed even though false is designed to exit with a
non-zero code. This is because in fact the last executed command
is 'local' not 'false' and thus '$?' contains zero as in "yeah,
the variable is successfully declared" [1]. In our libvirt-guest
shell script, there are a few places like this. Fix them.

1: bash_builtins(1)
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2026-01-19 14:21:57 +01:00
..
bash-completion
bash-completion: Run virsh/virt-admin in quiet mode
2024-05-28 08:51:45 +02:00
nss
tools/nss: check for missing array element
2025-11-07 11:58:35 +00:00
ssh-proxy
tools: ssh-proxy: Check for domain status before parsing its CID
2025-01-21 13:58:04 +01:00
wireshark
wireshark: Adapt to wireshark-4.6.0
2025-10-14 15:08:33 +02:00
libvirt_recover_xattrs.sh
tools: fix iterating over argv when recovering xattr
2021-11-30 10:45:35 +00:00
libvirt_win_icon_16x16.ico
Move virsh into tools/ directory
2009-09-21 14:41:45 +01:00
libvirt_win_icon_32x32.ico
Move virsh into tools/ directory
2009-09-21 14:41:45 +01:00
libvirt_win_icon_48x48.ico
Move virsh into tools/ directory
2009-09-21 14:41:45 +01:00
libvirt_win_icon_64x64.ico
Move virsh into tools/ directory
2009-09-21 14:41:45 +01:00
libvirt-guests.service.in
libvirt-guests.service: use Type=exec
2026-01-06 12:58:12 +00:00
libvirt-guests.sh.in
libvirt-guests.sh: Declare and assign separately to avoid masking return values
2026-01-19 14:21:57 +01:00
libvirt-login-shell.sysusers.conf
tools: add sysusers file to create 'virtlogin' group
2025-02-03 14:45:09 +00:00
meson.build
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh_win_icon.rc
Move virsh into tools/ directory
2009-09-21 14:41:45 +01:00
virsh-backup.c
lib: Introduce VIR_DOMAIN_BACKUP_BEGIN_PRESERVE_SHUTDOWN_DOMAIN flag
2025-11-24 16:40:24 +01:00
virsh-backup.h
backup: Implement virsh support for backup
2019-12-10 12:41:56 +01:00
virsh-checkpoint.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-checkpoint.h
backup: Implement virsh support for checkpoints
2019-07-26 16:48:58 -05:00
virsh-completer-checkpoint.c
tools: Remove unused includes
2022-06-16 06:43:58 +02:00
virsh-completer-checkpoint.h
virsh-completer*.h: Use modern header style
2021-09-17 09:40:46 +02:00
virsh-completer-domain.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-completer-domain.h
virsh: Add option "throttle-groups" to "attach_disk"
2025-03-20 17:43:44 +01:00
virsh-completer-host.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-completer-host.h
virsh: Add completer for hypervisor-cpu-baseline --model
2022-10-10 14:31:43 +02:00
virsh-completer-interface.c
tools: Remove unused includes
2022-06-16 06:43:58 +02:00
virsh-completer-interface.h
virsh-completer*.h: Use modern header style
2021-09-17 09:40:46 +02:00
virsh-completer-network.c
tools: Remove unused includes
2022-06-16 06:43:58 +02:00
virsh-completer-network.h
virsh: Introduce net-update --section completer
2022-01-19 16:48:33 +01:00
virsh-completer-nodedev.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-completer-nodedev.h
virsh: Provide completer for PCI backend drivers
2022-04-04 16:30:48 +02:00
virsh-completer-nwfilter.c
tools: Remove unused includes
2022-06-16 06:43:58 +02:00
virsh-completer-nwfilter.h
virsh-completer*.h: Use modern header style
2021-09-17 09:40:46 +02:00
virsh-completer-pool.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-completer-pool.h
virsh-completer: modify and fix bug in virshPoolTypeCompleter, now used for more commands
2024-02-20 12:08:22 +01:00
virsh-completer-secret.c
tools: Remove unused includes
2022-06-16 06:43:58 +02:00
virsh-completer-secret.h
virsh-completer*.h: Use modern header style
2021-09-17 09:40:46 +02:00
virsh-completer-snapshot.c
tools: Remove unused includes
2022-06-16 06:43:58 +02:00
virsh-completer-snapshot.h
virsh-completer*.h: Use modern header style
2021-09-17 09:40:46 +02:00
virsh-completer-volume.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-completer-volume.h
virsh: Provide completer for vol-wipe algorithms
2022-03-11 09:10:24 +01:00
virsh-completer.h
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-console.c
virsh: Show 'connected to console' message later
2024-04-02 18:26:35 +02:00
virsh-console.h
virsh: add console --resume support
2023-10-24 13:51:32 +02:00
virsh-domain-event.c
lib: Introduce VIR_DOMAIN_EVENT_SUSPENDED_GUEST_SHUTDOWN event reason
2025-11-24 16:40:24 +01:00
virsh-domain-event.h
virsh: Move 'cmdEvent' and all of its machinery to virsh-domain-event.c
2022-03-03 11:06:56 +01:00
virsh-domain-monitor.c
src: add new APIs for marking a domain to autostart once
2025-03-20 14:55:17 +00:00
virsh-domain-monitor.h
virsh: Fix virshDomainInterfaceSourceCompleter
2020-01-07 16:12:55 +01:00
virsh-domain.c
virsh: Add completer for '--image-format' option of 'save' command
2025-12-10 11:07:34 +01:00
virsh-domain.h
virsh: Add mode option to domdirtyrate-calc virsh api
2022-02-21 13:34:16 +01:00
virsh-edit.c
tools: Update format strings in translated messages (part 1)
2023-04-01 11:40:35 +02:00
virsh-host.c
util: virHostCPUGetStatsLinux: support VIR_NODE_CPU_STATS_GUEST
2025-09-01 16:14:31 +02:00
virsh-host.h
virsh-host: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers
2021-07-23 09:59:12 +02:00
virsh-interface.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-interface.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virsh-network.c
virsh: Apply empty completer to arguments where completion doesn't make sense
2025-05-21 15:49:36 +02:00
virsh-network.h
virsh: Introduce net-update --section completer
2022-01-19 16:48:33 +01:00
virsh-nodedev.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-nodedev.h
tools: s/Nodedev/NodeDevice/
2019-08-09 09:03:53 +02:00
virsh-nwfilter.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-nwfilter.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virsh-pool.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-pool.h
virsh-pool: Remove static from virshStoragePoolList{Free,Collect}
2021-06-16 10:32:33 +02:00
virsh-secret.c
tools: check for failure decoding secret base64 value
2026-01-06 10:59:46 +00:00
virsh-secret.h
tools: remove unnecessary includes
2020-08-03 15:30:40 +02:00
virsh-snapshot.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-snapshot.h
tools: remove unnecessary includes
2020-08-03 15:30:40 +02:00
virsh-util.c
virsh: Avoid using translated messages without format
2025-02-24 11:14:11 +01:00
virsh-util.h
virsh exposure of Network Metadata APIs
2023-08-25 12:36:37 +02:00
virsh-volume.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virsh-volume.h
virsh: Provide completer for vol-wipe algorithms
2022-03-11 09:10:24 +01:00
virsh.c
vshCommandRun: Convert to directly return the exit code
2025-06-12 10:17:03 +02:00
virsh.h
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
virt-admin-completer.c
lib: Drop internal virXXXPtr typedefs
2021-04-13 17:00:38 +02:00
virt-admin-completer.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virt-admin.c
vshCommandRun: Convert to directly return the exit code
2025-06-12 10:17:03 +02:00
virt-admin.h
lib: Drop internal virXXXPtr typedefs
2021-04-13 17:00:38 +02:00
virt-host-validate-bhyve.c
tools: split off common helpers for host validate tool
2024-06-11 12:50:23 +01:00
virt-host-validate-bhyve.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virt-host-validate-ch.c
tools: split off common helpers for host validate tool
2024-06-11 12:50:23 +01:00
virt-host-validate-ch.h
tools: add virt-host-validate-ch for ch driver
2021-10-12 17:28:35 +02:00
virt-host-validate-common.c
tools: be explicit about failure to find x86 secure virt
2025-11-20 17:26:18 +00:00
virt-host-validate-common.h
tools: Secure guest check for Intel in virt-host-validate
2025-07-25 11:27:43 +01:00
virt-host-validate-lxc.c
tools: split off common helpers for host validate tool
2024-06-11 12:50:23 +01:00
virt-host-validate-lxc.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virt-host-validate-qemu.c
tools: inform user which hardware virt was found during validation
2025-11-20 17:27:30 +00:00
virt-host-validate-qemu.h
tools: use #pragma once in headers
2019-06-19 17:12:34 +02:00
virt-host-validate.c
tools: split off common helpers for host validate tool
2024-06-11 12:50:23 +01:00
virt-login-shell-helper.c
tools: drop unused --version argument
2024-06-11 12:50:23 +01:00
virt-login-shell.c
Use G_N_ELEMENTS() more
2023-03-13 13:29:07 +01:00
virt-login-shell.conf
virt-login-shell: add ability to auto-detect shell from container
2016-06-10 11:03:02 +01:00
virt-pki-query-dn.c
tools: drop unused --version argument
2024-06-11 12:50:23 +01:00
virt-pki-validate.c
rpc: refactor TLS sanity checking to support many cert files
2025-11-24 15:05:09 +00:00
virt-qemu-qmp-proxy
python: Do not explicitly state variables are global when only read
2025-04-16 10:14:40 +02:00
virt-qemu-sev-validate
vir-qemu-sev-validate: Use string() method in xpath
2023-12-05 12:21:38 +01:00
virt-sanlock-cleanup.in
build: Extract pod from source files
2016-04-25 15:40:43 +02:00
virt-validate-common.c
tools: allow passing details for passed validation tests
2025-11-20 17:25:38 +00:00
virt-validate-common.h
tools: allow passing details for passed validation tests
2025-11-20 17:25:38 +00:00
virt-xml-validate.in
virt-xml-validate: Fix incorrect wildcards for XML roots
2022-07-07 12:21:16 +02:00
vsh-completer.c
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
vsh-completer.h
virsh: completer: Extract common completer methods from virsh to vsh
2025-05-21 15:49:36 +02:00
vsh-table.c
lib: use struct zero initializer instead of memset
2023-08-03 16:41:19 +02:00
vsh-table.h
vsh-table: Ensure NULL terminated arguments to vshTable*()
2021-12-17 15:05:58 +01:00
vsh.c
lib: Avoid changing const strings via strchr() and friends
2025-12-02 12:42:41 +01:00
vsh.h
vsh: Add support for commands with more return values
2025-06-12 10:17:03 +02:00