mirror of
https://github.com/libvirt/libvirt.git
synced 2026-10-02 12:20:06 -05:00
Andrea Bolognani
9d06d0f66f
The check is supposed to stop users from trying to compile
virt-login-shell on Windows by erroring out during the
configure phase; however, there are two flaws in it:
* the value of "x$with_win" is compared to "yes" instead
of "xyes" (note the "x" in the first string)
* "test" is not being used, so the script will actually
try to run a command called "x$with_win" instead of
performing string comparison
This patch fixes both issues.
(cherry picked from commit ccf58bd72a)
40 lines
1.5 KiB
Plaintext
40 lines
1.5 KiB
Plaintext
dnl Copyright (c) 2015 SUSE LINUX Products GmbH, Nuernberg, Germany.
|
|
dnl
|
|
dnl This library is free software; you can redistribute it and/or
|
|
dnl modify it under the terms of the GNU Lesser General Public
|
|
dnl License as published by the Free Software Foundation; either
|
|
dnl version 2.1 of the License, or (at your option) any later version.
|
|
dnl
|
|
dnl This library is distributed in the hope that it will be useful,
|
|
dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
dnl Lesser General Public License for more details.
|
|
dnl
|
|
dnl You should have received a copy of the GNU Lesser General Public
|
|
dnl License along with this library. If not, see
|
|
dnl <http://www.gnu.org/licenses/>.
|
|
|
|
AC_DEFUN([LIBVIRT_CHECK_LOGIN_SHELL], [
|
|
AC_ARG_WITH([login_shell],
|
|
[AS_HELP_STRING([--with-login-shell],
|
|
[build virt-login-shell @<:@default=check@:>@])])
|
|
m4_divert_text([DEFAULTS], [with_login_shell=check])
|
|
|
|
if test "x$with_login_shell" != "xno"; then
|
|
if test "x$with_win" = "xyes"; then
|
|
if test "x$with_login_shell" = "xyes"; then
|
|
AC_MSG_ERROR([virt-login-shell is not supported on Windows])
|
|
else
|
|
with_login_shell=no;
|
|
fi
|
|
else
|
|
with_login_shell=yes;
|
|
fi
|
|
fi
|
|
|
|
if test "x$with_login_shell" = "xyes" ; then
|
|
AC_DEFINE_UNQUOTED([WITH_LOGIN_SHELL], 1, [whether virt-login-shell is built])
|
|
fi
|
|
AM_CONDITIONAL([WITH_LOGIN_SHELL], [test "$with_login_shell" = "yes"])
|
|
])
|