Unit context improvements (#1639)

Move the unit context to a name matching the other contexts. Remove some
unnecessary entries from it that are unused, and remove references to
the old name relying on spec helper to load all contexts.

spec/support/unit_context.rb

@@ -22,21 +22,36 @@ shared_context 'unit' do
     test_env.vagrantfile vagrantfile
     test_env
   end
-  let(:env)              { { env: iso_env, machine: machine, ui: ui, root_path: '/rootpath' } }
-  let(:conf)             { Vagrant::Config::V2::DummyConfig.new }
-  let(:ui)               { Vagrant::UI::Silent.new }
   let(:iso_env)          { test_env.create_vagrant_env ui_class: Vagrant::UI::Basic }
   let(:machine)          { iso_env.machine(:test, :libvirt) }
+  let(:ui)               { Vagrant::UI::Silent.new }
+  let(:env)              { { env: iso_env, machine: machine, ui: ui, root_path: '/rootpath' } }
+
   # Mock the communicator to prevent SSH commands for being executed.
   let(:communicator)     { double('communicator') }
   # Mock the guest operating system.
   let(:guest)            { double('guest') }
   let(:app)              { ->(env) {} }
-  let(:plugin)           { register_plugin }
 
   before (:each) do
     allow(machine).to receive(:guest).and_return(guest)
     allow(machine).to receive(:communicate).and_return(communicator)
     allow(machine).to receive(:ui).and_return(ui)
   end
+
+  around do |example|
+    Dir.mktmpdir do |tmpdir|
+      original_home = ENV['HOME']
+
+      begin
+        virtual_home = File.expand_path(File.join(tmpdir, 'home'))
+        Dir.mkdir(virtual_home)
+        ENV['HOME'] = virtual_home
+
+        example.run
+      ensure
+        ENV['HOME'] = original_home
+      end
+    end
+  end
 end

spec/unit/action/clean_machine_folder_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
 
 require 'vagrant-libvirt/action/clean_machine_folder'
 

spec/unit/action/cleanup_on_failure_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
 
 require 'vagrant/action/runner'
 

spec/unit/action/create_domain_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
-require 'support/libvirt_context'
 
 require 'fog/libvirt/models/compute/volume'
 

spec/unit/action/create_domain_volume_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
-require 'support/libvirt_context'
 
 require 'fog/libvirt/models/compute/volume'
 

spec/unit/action/destroy_domain_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
-require 'support/libvirt_context'
 
 require 'vagrant-libvirt/action/destroy_domain'
 

spec/unit/action/forward_ports_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
-require 'support/libvirt_context'
 
 require 'vagrant-libvirt/errors'
 require 'vagrant-libvirt/action/forward_ports'

spec/unit/action/halt_domain_spec.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
+
-require 'support/libvirt_context'
 require 'vagrant-libvirt/action/halt_domain'
 
 describe VagrantPlugins::ProviderLibvirt::Action::HaltDomain do

spec/unit/action/handle_box_image_spec.rb

@@ -2,8 +2,6 @@
 
 require 'spec_helper'
 require 'json'
-require 'support/sharedcontext'
-require 'support/libvirt_context'
 
 require 'vagrant-libvirt/action/destroy_domain'
 require 'vagrant-libvirt/util/byte_number'

spec/unit/action/package_domain_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
 
 require 'vagrant-libvirt/action/clean_machine_folder'
 

spec/unit/action/prepare_nfs_settings_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
 
 require 'vagrant-libvirt/action/prepare_nfs_settings'
 

spec/unit/action/remove_libvirt_image_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
 
 require 'vagrant-libvirt/action/remove_libvirt_image'
 

spec/unit/action/set_boot_order_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
-require 'support/libvirt_context'
 
 require 'vagrant-libvirt/action/set_boot_order'
 

spec/unit/action/shutdown_domain_spec.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
-require 'support/sharedcontext'
+
-require 'support/libvirt_context'
 require 'vagrant-libvirt/action/shutdown_domain'
 
 describe VagrantPlugins::ProviderLibvirt::Action::StartShutdownTimer do

spec/unit/action/start_domain_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
-require 'support/libvirt_context'
 
 require 'vagrant-libvirt/errors'
 require 'vagrant-libvirt/action/start_domain'

spec/unit/action/wait_till_up_spec.rb

@@ -1,12 +1,10 @@
 # frozen_string_literal: true
 
+require 'spec_helper'
+
 require 'vagrant-libvirt/action/wait_till_up'
 require 'vagrant-libvirt/errors'
 
-require 'spec_helper'
-require 'support/sharedcontext'
-require 'support/libvirt_context'
-
 describe VagrantPlugins::ProviderLibvirt::Action::WaitTillUp do
   subject { described_class.new(app, env) }
 

spec/unit/action_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
 
 require 'vagrant/action/runner'
 

spec/unit/cap/mount_9p_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
 
 require 'vagrant-libvirt'
 

spec/unit/cap/synced_folder_9p_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
 
 require 'vagrant-libvirt/cap/synced_folder_9p'
 require 'vagrant-libvirt/util/unindent'

spec/unit/cap/synced_folder_virtiofs_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
 
 require 'vagrant-libvirt/cap/synced_folder_virtiofs'
 require 'vagrant-libvirt/util/unindent'

spec/unit/config_spec.rb

@@ -3,7 +3,6 @@
 require 'support/binding_proc'
 
 require 'spec_helper'
-require 'support/sharedcontext'
 
 require 'vagrant-libvirt/config'
 

spec/unit/driver_spec.rb

@@ -4,7 +4,6 @@ require 'fog/libvirt/requests/compute/dhcp_leases'
 
 require 'spec_helper'
 require 'support/binding_proc'
-require 'support/sharedcontext'
 
 require 'vagrant-libvirt/driver'
 

spec/unit/plugin_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'support/sharedcontext'
 
 require 'vagrant-libvirt'
 require 'vagrant-libvirt/plugin'

spec/unit/templates/domain_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'support/sharedcontext'
+require 'spec_helper'
 
 require 'vagrant-libvirt/config'
 require 'vagrant-libvirt/util/erb_template'