From 33f2a39b3d5405f118a6219fdcc0cb3fc464ac2b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dan=20=C4=8Cerm=C3=A1k?= <45594031+dcermak@users.noreply.github.com> Date: Thu, 22 Sep 2022 12:35:14 +0200 Subject: [PATCH] Spec fixes (#1603) - the sysprep.sh script was not executable (flagged by rpmlint) - Need to explicitly `require 'tmpdir'` in `spec_helper.rb` on openSUSE Tumbleweed, otherwise you get tons of failures like: ``` An error occurred while loading ./spec/unit/action/prepare_nfs_settings_spec.rb. Failure/Error: temp_dir = Dir.mktmpdir("rspec-") NoMethodError: undefined method `mktmpdir' for Dir:Class temp_dir = Dir.mktmpdir("rspec-") ^^^^^^^^^ Did you mean? mkdir # ./spec/spec_helper.rb:44:in `block in ' # ./spec/spec_helper.rb:41:in `' # ./spec/unit/action/prepare_nfs_settings_spec.rb:3:in `require' # ./spec/unit/action/prepare_nfs_settings_spec.rb:3:in `' ``` --- .../support-skeletons/package_complex/scripts/sysprep.sh | 0 spec/spec_helper.rb | 2 ++ 2 files changed, 2 insertions(+) mode change 100644 => 100755 spec/acceptance/support-skeletons/package_complex/scripts/sysprep.sh diff --git a/spec/acceptance/support-skeletons/package_complex/scripts/sysprep.sh b/spec/acceptance/support-skeletons/package_complex/scripts/sysprep.sh old mode 100644 new mode 100755 diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 197a473..dab296c 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -39,6 +39,8 @@ rescue LoadError end RSpec.configure do |config| + require 'tmpdir' + # set VAGRANT_HOME before any thing that requires vagrant is loaded to prevent # the global plugin manager from trying to use the default VAGRANT_HOME. temp_dir = Dir.mktmpdir("rspec-")