Checking if a volume exists before attempting to create it results in
a "time of check to time of use" race. When the check is done the
volume doesn't exist but then, because it is shared storage, it is
then created by another node before the local attempt to create it.
This results in an unexpected failure.
It is better to simply attempt to create the volume and ignore EEXIST
in cases where this is permissible.
Implementing this properly is complicated by the fact that the
exception appears to contain only an error message and does not appear
to contain a useful error code. Digging through the layers in, for
example, fog-libvirt provides no evidence why this is so. However,
the error message seems fairly unique and matching it is easy, so just
do that. A small hack to vastly improve stability.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Support `vagrant package` of e.g. bento-derived boxes that require SSH
hostkeys already set (as in the case of bento/debian-7 and above,) as
well as leave existing LVM UUIDs untouched (e.g. in bento/ubuntu-18.04.)
Instead of hard-coding sysprep operations, use an environment variable
to set these instead.
Use the Chef bento use case as an example for customizing sysprep
operations.
Default to using the same storage pool in case the user defines
storage_pool_name without defining snapshot_pool_name and only use a
separate pool when snapshot_pool_name is explicitly set.
This will ensure that setting storage_pool_name to a different pool does
not also require setting snapshot_pool_name to match previous behaviour.
Additionally it is reasonable for a user to assume that if a Vagrantfile
sets storage_pool_name to something other than 'default', then there
should be no need for a default pool.
Attempt to use latest travis CI settings for installing required
packages.
Should attempt to test various combinations to try and catch problems
occurring across different versions of vagrant with different versions
of ruby when people are using distro provided versions.
the 'echo' service is often not available out-of-the-box,
so the 'ping' of the ssh interface fails. This results in the
wrong ip addresses being used in /etc/exports, which results in
the vm not being able to mount the vagrant shares.
The 'vagrant ssh interface' will have the service 'ssh' available
(you won't be able to login to your vagrant box else), so it makes
sense to use that service for the ping.
This fixes the vm not being able to mount the shares over nfs after
a reload due to the wrong ip addresses being used.
In 5158b0e733, `git ls-files` was added to list the _files_ and _test_files_. This will never work for any process that uses a source tarball, like Debian packages and I think gems. Using `git ls-files` requires _git_ is installed on the build machine and requires that the _.git/_ dir is present in the source.
Example fixes:
* jfelchner/ruby-progressbar#54
* rubygems/rubygems#2064
* wpscanteam/CMSScanner#64
* readme: usb: keep usb-related sections together
* readme: usb: add link for usb device passthrough section
* readme: usb: add general info about usb usage
* readme: usb: place libvirt doco link after vagrantfile example
* readme: usb: add note about enabling spice redirection
