NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-08 23:23:23 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove a bunch of outdates FIXME/XXX comments

Browse Source
This commit is contained in:
Cole Robinson 2013-04-17 09:09:53 -04:00
parent c4ecea3c1b
commit 07e0c92b4b
23 changed files with 20 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/clitest.py
View File

@ -414,8 +414,6 @@ args_dict = {
# --smartcard mode with type
"--smartcard passthrough,type=spicevmc",
# --smartcard mode with type
# XXX Requires implementing more opts
#"--smartcard passthrough,type=tcp",
],
"invalid": [
@ -887,7 +885,7 @@ args_dict = {
# XML w/ managed storage, specify managed path
"--original-xml %(CLONE_STORAGE_XML)s --file %(MANAGEDNEW1)s",
# XML w/ managed storage, specify managed path across pools
# XXX: Libvirt test driver doesn't support cloning across pools
# Libvirt test driver doesn't support cloning across pools
#"--original-xml %(CLONE_STORAGE_XML)s --file /cross-pool/clonevol",
# XML w/ non-existent storage, with --preserve
"--original-xml %(CLONE_NOEXIST_XML)s --file %(EXISTIMG1)s --preserve",

6
tests/image.py
View File

@ -106,12 +106,8 @@ class TestImageParser(unittest.TestCase):
utils.reset_conn()
# Build libvirt XML from the image xml
# XXX: This doesn't set up devices, so the guest xml will be pretty
# XXX: sparse. There should really be a helper in the Image classes
# XXX: that turns virt-image xml into a minimal Guest object, but
# XXX: maybe that's just falling into the realm of virt-convert
def testImage2XML(self):
# Build libvirt XML from the image xml
self._image2XMLhelper("image.xml", ["image-xenpv32.xml",
"image-xenfv32.xml"])
self._image2XMLhelper("image-kernel.xml", ["image-xenpv32-kernel.xml"])

2
tests/xmlparse.py
View File

@ -255,7 +255,7 @@ class XMLParseTest(unittest.TestCase):
guest = virtinst.Guest(conn=conn,
parsexml=file(infile).read())
# XXX: Set size up front. VirtualDisk validation is kind of
# Set size up front. VirtualDisk validation is kind of
# convoluted. If trying to change a non-existing one and size wasn't
# already specified, we will error out.
disks = guest.get_devices("disk")

2
todo.txt
View File

@ -2,7 +2,6 @@
TODO before first release
=========================
check all XXX/TODO in the code, make sure nothing important is missing
revive import blacklist for virtinst code, maybe just a unittest that checks Gtk isn't in globals ?
is tui working? maybe just remove it, check with mcpierce
@ -28,6 +27,7 @@ spacing is weird in manager, prefs window. cant have unequal tree rows
- save this till the end, narrow it down to a simple reproducer and try and
fix, probably a gtk3 issue.
- list size issues: master actually has bigger list size than collapsed gtk3 rows, maybe that is part of the issue.
- check if manual themeing at the top of manager.py is still required/works
Object leaks

3
virtManager/baseclass.py
View File

@ -159,9 +159,6 @@ class vmmGObject(GObject.GObject):
return GObject.GObject.emit(self, signal_name, *args)
def __del__(self):
# XXX
# GObject.GObject.__del__(self)
try:
if self.config and self._leak_check:
self.config.remove_object(self.object_key)

9
virtManager/connect.py
View File

@ -393,10 +393,11 @@ class vmmConnect(vmmGObjectUI):
def check_resolve_host(self, host):
# Try to resolve hostname
# XXX: Avahi always uses 'hostname.local', but for some reason
# fedora out of the box can't resolve '.local' names
# Attempt to resolve the name. If it fails, remove .local
# if present, and try again
#
# Avahi always uses 'hostname.local', but for some reason
# fedora 12 out of the box can't resolve '.local' names
# Attempt to resolve the name. If it fails, remove .local
# if present, and try again
if host.endswith(".local"):
if self.can_resolve_local is False:
host = host[:-6]

1
virtManager/console.py
View File

@ -350,7 +350,6 @@ class VNCViewer(Viewer):
return self.desktop_resolution
def _auth_credential(self, src_ignore, credList):
# XXX shouldn't need this
values = []
for idx in range(int(credList.n_values)):
values.append(credList.get_nth(idx))

6
virtManager/delete.py
View File

@ -282,11 +282,7 @@ def prepare_storage_list(storage_list):
# icon size, tooltip
model = Gtk.ListStore(bool, bool, str, str, bool, str, int, str)
storage_list.set_model(model)
try:
storage_list.set_tooltip_column(STORAGE_ROW_TOOLTIP)
except:
# FIXME: use tooltip wrapper for this
pass
storage_list.set_tooltip_column(STORAGE_ROW_TOOLTIP)
confirmCol = Gtk.TreeViewColumn()
pathCol = Gtk.TreeViewColumn(_("Storage Path"))

2
virtManager/engine.py
View File

@ -50,7 +50,7 @@ from virtManager.error import vmmErrorDialog
from virtManager.systray import vmmSystray
# Enable this to get a report of leaked objects on app shutdown
# XXX: gtk3 has issues here
# gtk3/pygobject has issues here as of Fedora 18
debug_ref_leaks = False

6
virtManager/graphwidgets.py
View File

@ -373,9 +373,9 @@ class Sparkline(Gtk.DrawingArea):
draw_line(cr, 0, 0, w, h, points)
if self.filled:
# XXX: Fixes a fully filled graph from having an oddly
# tapered in end (bug 560913). Need to figure out
# what's really going on.
# Fixes a fully filled graph from having an oddly
# tapered in end (bug 560913). Need to figure out
# what's really going on.
points = [(0, h)] + points
draw_fill(cr, 0, 0, w, h, points, taper=True)

2
virtManager/host.py
View File

@ -1081,7 +1081,7 @@ class vmmHost(vmmGObjectUI):
str(e))
return
# XXX: This will require an interface restart
# This will require an interface restart
self.widget("interface-apply").set_sensitive(False)
def interface_startmode_changed(self, src_ignore):

1
virtManager/migrate.py
View File

@ -116,7 +116,6 @@ class vmmMigrateDialog(vmmGObjectUI):
dest_combo.add_attribute(text, 'text', 0)
dest_combo.add_attribute(text, 'sensitive', 2)
dest_model.set_sort_column_id(0, Gtk.SortType.ASCENDING)
# XXX no way to set tooltips here, kind of annoying
# Hook up signals to get connection listing
self.engine.connect("conn-added", self.dest_add_conn)

1
virtManager/systray.py
View File

@ -341,7 +341,6 @@ class vmmSystray(vmmGObject):
self.repopulate_menu_list()
def conn_state_changed(self, conn):
# XXX: Even 'paused' conn?
sensitive = conn.is_active()
menu_item = self.conn_menuitems[conn.get_uri()]
menu_item.set_sensitive(sensitive)

2
virtManager/uihelpers.py
View File

@ -288,8 +288,6 @@ def populate_smartcard_mode_combo(vm, combo):
# [xml value, label]
model.append(["passthrough", "Passthrough"])
model.append(["host", "Host"])
# TODO
# model.append(["host-certificates", "Host Certificates"])
def build_redir_type_combo(vm, combo):

3
virtManager/util.py
View File

@ -30,8 +30,6 @@ running_config = None
xml_escape = virtinst.util.xml_escape
# FIXME: selinux policy also has a ~/VirtualMachines/isos dir
def get_default_pool_path(conn):
if conn.is_session_uri():
@ -48,7 +46,6 @@ def build_default_pool(vmmconn):
"""
Helper to build the 'default' storage pool
"""
# FIXME: This should use config.get_default_image_path ?
conn = vmmconn.vmm
path = get_default_pool_path(vmmconn)

1
virtManagerTui/adddomain.py
View File

@ -215,7 +215,6 @@ class DomainConfigScreen(VmmTuiConfigScreen):
elif page is BRIDGE_PAGE:
if self.__network_bridges.getSelection() is not None:
if len(self.__mac_address.value()) > 0:
# TODO: regex check the format
return True
else:
errors.append("MAC address must be supplied.")

2
virtManagerTui/addnetwork.py
View File

@ -203,7 +203,7 @@ class AddNetworkConfigScreen(VmmTuiConfigScreen):
self.__end_address = Entry(15, self.__config.get_ipv4_end_address())
fields = []
fields.append(("Select the DHCP range", None))
# XXX
# XXX: Broken after gtk3/ipaddr conversion
# fields.append(("Start", self.__start_address.network))
# fields.append(("End", self.__end_address.network))
return [Label("Selecting The DHCP Range"),

1
virtinst/ImageParser.py
View File

@ -112,7 +112,6 @@ class Domain:
self.interface = int(node.xpathEval("count(devices/interface)"))
self.graphics = node.xpathEval("count(devices/graphics)") > 0
# FIXME: There must be a better way to check this
if tmpmem is not None:
try:
self.memory = int(tmpmem)

1
virtinst/NodeDeviceParser.py
View File

@ -251,7 +251,6 @@ class StorageDevice(NodeDevice):
self.block = None
self.bus = None
# FIXME: Map this to virtinst.device?
self.drive_type = None
self.size = 0

5
virtinst/OSDistro.py
View File

@ -93,7 +93,6 @@ def _storeForDistro(fetcher, baseuri, typ, progresscb, arch, distro=None,
stores.append(MandrivaDistro)
if distro == "mageia" or distro is None:
stores.append(MageiaDistro)
# XXX: this is really "nevada"
if distro == "solaris" or distro is None:
stores.append(SolarisDistro)
if distro == "solaris" or distro is None:
@ -760,8 +759,6 @@ class SuseDistro(Distro):
# On i686 arch, we also look under i585 and i386 dirs
# in case the RPM is built for a lesser arch. We also
# need the PAE variant (for Fedora dom0 at least)
#
# XXX shouldn't hard code that dom0 is PAE
if self.arch == "i386":
arches.append("i586")
arches.append("i686")
@ -1105,7 +1102,6 @@ class SolarisDistro(SunDistro):
the pathname of the kernel (32/64) to load, kernel options
and args, and '-B' boot properties."""
# XXX: ignoring smfargs for the time being
(kopts, kargs, ignore_smfargs, kbargs) = \
self.process_extra_args(guest.extraargs)
@ -1199,7 +1195,6 @@ class OpenSolarisDistro(SunDistro):
the pathname of the kernel (32/64) to load, kernel options
and args, and '-B' boot properties."""
# XXX: ignoring smfargs and kargs for the time being
(kopts, ignore_kargs, ignore_smfargs, kbargs) = \
self.process_extra_args(guest.extraargs)

1
virtinst/cli.py
View File

@ -2099,7 +2099,6 @@ def parse_sound(guest, optstr, dev=None):
def parse_hostdev(guest, optstr, dev=None):
# XXX: Need to implement this for virt-xml
ignore = dev
return virtinst.VirtualHostDevice.device_from_node(conn=guest.conn,
name=optstr)

4
virtinst/support.py
View File

@ -277,7 +277,7 @@ _support_dict = {
},
}
# XXX: RHEL6 has lots of feature backports, and since libvirt doesn't
# RHEL6 has lots of feature backports, and since libvirt doesn't
# really offer any XML feature introspection, we have to use hacks to
# make sure we aren't generating bogus config on non RHEL
_rhel6 = False
@ -559,7 +559,7 @@ def _check_support(conn, feature, data=None):
if hv != hv_type:
continue
# XXX: No HV specific version info, just use driver version
# No HV specific version info, just use driver version
if min_hv_ver < 0:
if actual_drv_ver <= -min_hv_ver:
found = True

5
virtinst/util.py
View File

@ -139,8 +139,8 @@ def validate_uuid(val):
if form is None:
raise ValueError(
_("UUID must be a 32-digit hexadecimal number. It may take "
"the form XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX or may omit "
"hyphens altogether."))
"the form xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx or may "
"omit hyphens altogether."))
else: # UUID had no dashes, so add them in
val = (val[0:8] + "-" + val[8:12] + "-" + val[12:16] +
@ -305,7 +305,6 @@ def default_nic():
if platform.system() != 'SunOS':
return dev
# XXX: fails without PRIV_XVM_CONTROL
proc = subprocess.Popen(['/usr/lib/xen/bin/xenstore-read',
'device-misc/vif/default-nic'], stdout=subprocess.PIPE,
stderr=subprocess.PIPE)