diff --git a/tests/cli-test-xml/compare/virt-install-features-vmcoreinfo.xml b/tests/cli-test-xml/compare/virt-install-features-vmcoreinfo.xml new file mode 100644 index 000000000..a149c7533 --- /dev/null +++ b/tests/cli-test-xml/compare/virt-install-features-vmcoreinfo.xml @@ -0,0 +1,28 @@ + + foobar + 00000000-1111-2222-3333-444444444444 + 65536 + 65536 + 1 + + hvm + + + + + + + + + + + + + /usr/bin/test-hv + + + + + + + diff --git a/tests/clitest.py b/tests/clitest.py index 8802bc8ff..04ab86dae 100644 --- a/tests/clitest.py +++ b/tests/clitest.py @@ -582,6 +582,7 @@ c.add_compare(""" \ c = vinst.add_category("features", "--nographics --noautoconsole --import --disk none --controller usb,model=none") c.add_compare("--features smm=on", "features-smm") c.add_invalid("--features smm=on --machine pc") +c.add_compare("--features vmcoreinfo=on", "features-vmcoreinfo") ######################## diff --git a/virtinst/cli.py b/virtinst/cli.py index 2bcd88553..16ad81a99 100644 --- a/virtinst/cli.py +++ b/virtinst/cli.py @@ -1795,6 +1795,7 @@ ParserFeatures.add_arg("pvspinlock", "pvspinlock", is_onoff=True) ParserFeatures.add_arg("gic_version", "gic_version") ParserFeatures.add_arg("smm", "smm", is_onoff=True, cb=ParserFeatures.set_smm_cb) +ParserFeatures.add_arg("vmcoreinfo", "vmcoreinfo", is_onoff=True) ################### diff --git a/virtinst/domainfeatures.py b/virtinst/domainfeatures.py index e4f3165b9..df7fe6cff 100644 --- a/virtinst/domainfeatures.py +++ b/virtinst/domainfeatures.py @@ -56,3 +56,5 @@ class DomainFeatures(XMLBuilder): pvspinlock = XMLProperty("./pvspinlock/@state", is_onoff=True) smm = XMLProperty("./smm/@state", is_onoff=True) + vmcoreinfo = XMLProperty("./vmcoreinfo", is_bool=True, + default_name="default", default_cb=lambda s: False)