NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix indentation of multiline log.exception() invocations

Browse Source 
Commit f107e39989 ("Switch to more traditional logging structure",
2019-06-17) replaced "logging.exception" with "log.exception", effectively
shifting the argument lists 4 characters to the left. The second and
further lines of multiline invocations were not accordingly unindented,
however, which ended up setting a suboptimal precedent as well. Unindent
those lines now.

Reported-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
This commit is contained in:
Laszlo Ersek 2023-08-30 10:03:15 +02:00 committed by Pavel Hrdina
parent 19b0f3f446
commit 2ebbdb2797
4 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
virtManager/hoststorage.py
View File

@ -427,8 +427,7 @@ class vmmHostStorage(vmmGObjectUI):
if not namestr: if not namestr:
namestr = None namestr = None
except Exception: # pragma: no cover except Exception: # pragma: no cover
log.exception("Failed to determine if storage volume in " log.exception("Failed to determine if storage volume in use.")
"use.")
sensitive = True sensitive = True
if self._vol_sensitive_cb: if self._vol_sensitive_cb:

7
virtManager/lib/inspection.py
View File

@ -115,9 +115,8 @@ def _perform_inspection(conn, vm): # pragma: no cover
g.mount_ro(dev, mp) g.mount_ro(dev, mp)
filesystems_mounted = True filesystems_mounted = True
except Exception: except Exception:
log.exception("%s: exception mounting %s on %s " log.exception("%s: exception mounting %s on %s (ignored)",
"(ignored)", prettyvm, dev, mp)
prettyvm, dev, mp)
icon = None icon = None
apps = None apps = None
@ -154,7 +153,7 @@ def _perform_inspection(conn, vm): # pragma: no cover
apps.append(app) apps.append(app)
except Exception: except Exception:
log.exception("%s: exception while listing apps (ignored)", log.exception("%s: exception while listing apps (ignored)",
prettyvm) prettyvm)
# Force the libguestfs handle to close right now. # Force the libguestfs handle to close right now.
del g del g

2
virtManager/object/domain.py
View File

@ -1429,7 +1429,7 @@ class vmmDomain(vmmLibvirtObject):
self._backend.undefineFlags(flags) self._backend.undefineFlags(flags)
except libvirt.libvirtError: except libvirt.libvirtError:
log.exception("libvirt undefineFlags failed, " log.exception("libvirt undefineFlags failed, "
"falling back to old style") "falling back to old style")
self._backend.undefine() self._backend.undefine()
@vmmLibvirtObject.lifecycle_action @vmmLibvirtObject.lifecycle_action

2
virtinst/guest.py
View File

@ -636,7 +636,7 @@ class Guest(XMLBuilder):
capsinfo = self.lookup_capsinfo() capsinfo = self.lookup_capsinfo()
except Exception: except Exception:
log.exception("Error fetching machine list for alias " log.exception("Error fetching machine list for alias "
"resolution, assuming mismatch"); "resolution, assuming mismatch");
return False return False
if capsinfo.is_machine_alias(self.os.machine, domcaps.machine): if capsinfo.is_machine_alias(self.os.machine, domcaps.machine):
return True return True