NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

virt-manager: Fix VNC connection on hypervisor without GraphicsFD

Browse Source 
Function virDomainOpenGraphicsFD() from libvirt can return -1
But in this case libvirt-python will raise an exception.
We should handle this case and return -1 as invalid FD.
In commit 5c451b64 Viewer._open() there is a code to open
graphics console in case of invalid GraphicsFD.

(crobinso: also log the error message)
This commit is contained in:
Mikhail Feoktistov 2016-03-26 13:02:38 +03:00 committed by Cole Robinson
parent a1383faff3
commit 32cccaa170
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
virtManager/domain.py
View File

@ -1117,7 +1117,12 @@ class vmmDomain(vmmLibvirtObject):
return self._backend.openConsole(devname, stream, flags)
def open_graphics_fd(self):
return self._backend.openGraphicsFD(0)
try:
fd = self._backend.openGraphicsFD(0)
except libvirt.libvirtError:
logging.debug("openGraphicsFD failed", exc_info=True)
fd = -1
return fd
def refresh_snapshots(self):
self._snapshot_list = None