NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

devicepanic: don't set default iobase

Browse Source 
This is not required and it's correctly handled by libvirt and QEMU.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Pavel Hrdina
2017-09-04 18:44:56 +02:00
parent 36230c9a18
commit 48604bfb37
4 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/cli-test-xml/compare/virt-install-panic-default.xml
View File

@@ -28,8 +28,6 @@
<emulator>/usr/bin/qemu-kvm</emulator> <emulator>/usr/bin/qemu-kvm</emulator>
<controller type="usb" index="0" model="none"/> <controller type="usb" index="0" model="none"/>
<console type="pty"/> <console type="pty"/>
<panic model="isa"> <panic model="isa"/>
<address type="isa" iobase="0x505"/>
</panic>
</devices> </devices>
</domain> </domain>

4
tests/cli-test-xml/compare/virt-install-panic-isa.xml
View File

@@ -28,8 +28,6 @@
<emulator>/usr/bin/qemu-kvm</emulator> <emulator>/usr/bin/qemu-kvm</emulator>
<controller type="usb" index="0" model="none"/> <controller type="usb" index="0" model="none"/>
<console type="pty"/> <console type="pty"/>
<panic model="isa"> <panic model="isa"/>
<address type="isa" iobase="0x505"/>
</panic>
</devices> </devices>
</domain> </domain>

4
tests/cli-test-xml/compare/virt-install-singleton-config-1.xml
View File

@@ -63,9 +63,7 @@
<rng model="virtio"> <rng model="virtio">
<backend model="random">/dev/random</backend> <backend model="random">/dev/random</backend>
</rng> </rng>
<panic model="isa"> <panic model="isa"/>
<address type="isa" iobase="0x505"/>
</panic>
</devices> </devices>
<seclabel type="dynamic" model="selinux"/> <seclabel type="dynamic" model="selinux"/>
<seclabel type="none" model="dac"/> <seclabel type="none" model="dac"/>

4
virtinst/devicepanic.py
View File

@@ -30,7 +30,6 @@ class VirtualPanicDevice(VirtualDevice):
MODELS = [MODEL_ISA] MODELS = [MODEL_ISA]
ISA_ADDRESS_TYPE = "isa" ISA_ADDRESS_TYPE = "isa"
IOBASE_DEFAULT = "0x505"
@staticmethod @staticmethod
def get_pretty_model(panic_model): def get_pretty_model(panic_model):
@@ -48,7 +47,6 @@ class VirtualPanicDevice(VirtualDevice):
default_name=MODEL_DEFAULT) default_name=MODEL_DEFAULT)
type = XMLProperty("./address/@type", type = XMLProperty("./address/@type",
default_cb=_get_default_address_type) default_cb=_get_default_address_type)
iobase = XMLProperty("./address/@iobase", iobase = XMLProperty("./address/@iobase")
default_cb=lambda s: s.IOBASE_DEFAULT)
VirtualPanicDevice.register_type() VirtualPanicDevice.register_type()