NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-08 07:03:02 -06:00
Code Issues Packages Projects Releases Wiki Activity

virt-install: Drop warning about '--console none'

Browse Source 
This should be rarely if ever used, don't warn the user about this
case

Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Cole Robinson 2019-11-24 17:25:51 -05:00
parent b55a959e5e
commit 4ef519229d
2 changed files with 2 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/clitest.py
View File

@ -1099,7 +1099,6 @@ c.add_valid("--pxe --destroy-on-exit", grep="Restarting guest.\n") # destroy-on
c.add_valid("--pxe --transient --destroy-on-exit", grep="Domain creation completed.") # destroy-on-exit + transient c.add_valid("--pxe --transient --destroy-on-exit", grep="Domain creation completed.") # destroy-on-exit + transient
c.add_valid("--pxe --graphics vnc --noreboot", grep="testsuite console command: ['virt-viewer'") # mock virt-viewer waiting, with noreboot magic c.add_valid("--pxe --graphics vnc --noreboot", grep="testsuite console command: ['virt-viewer'") # mock virt-viewer waiting, with noreboot magic
c.add_valid("--nographics --cdrom %(EXISTIMG1)s") # console warning about cdrom + nographics c.add_valid("--nographics --cdrom %(EXISTIMG1)s") # console warning about cdrom + nographics
c.add_valid("--nographics --console none --location %(TREEDIR)s", grep="No --console device added") # console warning about nographics + --console none
c.add_valid("--nographics --console none --location %(TREEDIR)s", grep="Directory tree installs typically") # warning about directory trees not working well c.add_valid("--nographics --console none --location %(TREEDIR)s", grep="Directory tree installs typically") # warning about directory trees not working well
c.add_valid("--pxe --nographics --transient", grep="testsuite console command: ['virsh'") # --transient handling c.add_valid("--pxe --nographics --transient", grep="testsuite console command: ['virsh'") # --transient handling

19
virt-install
View File

@ -319,10 +319,6 @@ def validate_required_options(options, guest, installer):
fail(msg) fail(msg)
_cdrom_location_man_page = _("See the man page for examples of "
"using --location with CDROM media")
def _show_nographics_warnings(options, guest, installer): def _show_nographics_warnings(options, guest, installer):
if guest.devices.graphics: if guest.devices.graphics:
return return
@ -333,19 +329,8 @@ def _show_nographics_warnings(options, guest, installer):
log.warning(_("CDROM media does not print to the text console " log.warning(_("CDROM media does not print to the text console "
"by default, so you likely will not see text install output. " "by default, so you likely will not see text install output. "
"You might want to use --location.") + " " + "You might want to use --location.") + " " +
_cdrom_location_man_page) _("See the man page for examples of "
return "using --location with CDROM media"))
if not options.location:
return
# Trying --location --nographics with console connect. Warn if
# they likely won't see any output.
if not guest.devices.console:
log.warning(_("No --console device added, you likely will not "
"see text install output from the guest."))
return
def _show_memory_warnings(guest): def _show_memory_warnings(guest):