NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

xmlbuilder: Clarify the node 'pretty' helper function

Browse Source
This commit is contained in:
Cole Robinson 2016-07-18 13:23:43 -04:00
parent d8a0a78805
commit 559e813b96
1 changed files with 47 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
virtinst/xmlbuilder.py
View File

@ -98,14 +98,13 @@ def _get_xpath_node(ctx, xpath):
return (node and node[0] or None)
def _build_xpath_node(ctx, xpath, addnode=None):
def _add_pretty_child(parentnode, newnode):
"""
Build all nodes required to set an xpath. If we have XML <foo/>, and want
to set xpath /foo/bar/baz@booyeah, we create node 'bar' and 'baz'
returning the last node created.
Add 'newnode' as a child of 'parentnode', but try to preserve
whitespace and nicely format the result.
"""
parentpath = ""
parentnode = None
def node_is_text(n):
return bool(n and n.type == "text" and not n.content.count("<"))
def prevSibling(node):
parent = node.get_parent()
@ -120,12 +119,6 @@ def _build_xpath_node(ctx, xpath, addnode=None):
return None
def make_node(parentnode, newnode):
# Add the needed parent node, try to preserve whitespace by
# looking for a starting TEXT node, and copying it
def node_is_text(n):
return bool(n and n.type == "text" and not n.content.count("<"))
sib = parentnode.get_last()
if not node_is_text(sib):
# This case is when we add a child element to a node for the
@ -162,6 +155,16 @@ def _build_xpath_node(ctx, xpath, addnode=None):
newnode.addNextSibling(txt)
return newnode
def _build_xpath_node(ctx, xpath, addnode=None):
"""
Build all nodes required to set an xpath. If we have XML <foo/>, and want
to set xpath /foo/bar/baz@booyeah, we create node 'bar' and 'baz'
returning the last node created.
"""
parentpath = ""
parentnode = None
nodelist = xpath.split("/")
for nodename in nodelist:
if not nodename:
@ -192,10 +195,10 @@ def _build_xpath_node(ctx, xpath, addnode=None):
nodename = nodename[:nodename.index("[")]
newnode = libxml2.newNode(nodename)
parentnode = make_node(parentnode, newnode)
parentnode = _add_pretty_child(parentnode, newnode)
if addnode:
parentnode = make_node(parentnode, addnode)
parentnode = _add_pretty_child(parentnode, addnode)
return parentnode