From 5c1ed03b89e30cdb6082e4cc31279ad9d5aa54cf Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Wed, 18 Dec 2013 16:34:10 -0500 Subject: [PATCH] Fix some pylint --- virtManager/config.py | 2 +- virtManager/inspection.py | 2 +- virtManager/packageutils.py | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/virtManager/config.py b/virtManager/config.py index 0b5f7ff8f..5daa884c1 100644 --- a/virtManager/config.py +++ b/virtManager/config.py @@ -182,7 +182,7 @@ class vmmConfig(object): try: # Check we can open the Python guestfs module. from guestfs import GuestFS # pylint: disable=F0401 - GuestFS(close_on_exit = False) + GuestFS(close_on_exit=False) return True except: return False diff --git a/virtManager/inspection.py b/virtManager/inspection.py index ef2a2f427..48150deaf 100644 --- a/virtManager/inspection.py +++ b/virtManager/inspection.py @@ -163,7 +163,7 @@ class vmmInspection(vmmGObject): vm.get_name()) return None - g = GuestFS(close_on_exit = False) + g = GuestFS(close_on_exit=False) prettyvm = conn.get_uri() + ":" + vm.get_name() ignore = vmuuid diff --git a/virtManager/packageutils.py b/virtManager/packageutils.py index 6299a3b9e..34478b78f 100644 --- a/virtManager/packageutils.py +++ b/virtManager/packageutils.py @@ -35,6 +35,8 @@ def check_packagekit(parent, errbox, packages): Returns None when we determine nothing useful. Returns (success, did we just install libvirt) otherwise. """ + ignore = errbox + if not packages: logging.debug("No PackageKit packages to search for.") return @@ -55,8 +57,7 @@ def check_packagekit(parent, errbox, packages): except Exception, e: # PackageKit frontend should report an error for us, so just log # the actual error - logging.debug("Error talking to PackageKit: %s" % str(e), - exc_info=True) + logging.debug("Error talking to PackageKit: %s", str(e), exc_info=True) return return True