From 5c1f4b238699dba34d6d7442396c9e1053645d88 Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Sun, 20 Sep 2020 16:44:24 -0400 Subject: [PATCH] virtinst: storage: gluster pools don't support volume creation Drop code that implies they do Signed-off-by: Cole Robinson --- tests/test_storage.py | 2 +- virtinst/storage.py | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/test_storage.py b/tests/test_storage.py index 4402a89a9..ee33ab32e 100644 --- a/tests/test_storage.py +++ b/tests/test_storage.py @@ -221,7 +221,7 @@ def testMisc(): glustervol = StorageVolume(fullconn) glustervol.pool = glusterpool - assert glustervol.supports_format() is True + assert glustervol.supports_format() is False diskvol = StorageVolume(fullconn) diskvol.pool = diskpool diff --git a/virtinst/storage.py b/virtinst/storage.py index df7a7fedf..864ae248b 100644 --- a/virtinst/storage.py +++ b/virtinst/storage.py @@ -621,11 +621,7 @@ class StorageVolume(_StorageObject): ###################### def supports_format(self): - if self.file_type == self.TYPE_FILE: - return True - if self._pool_xml.type == StoragePool.TYPE_GLUSTER: - return True - return False + return self.file_type == self.TYPE_FILE ##################