NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2026-08-14 06:54:51 -05:00
Code Issues Packages Projects Releases Wiki Activity

devices: controller: Add get_attached_devices

Browse Source 
Move the opencoded impl out of virt-manager details.py and into
virtinst, since this is entirely about XML comparison. Add tests for
it

Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Cole Robinson
2020-01-27 13:08:12 -05:00
parent ec580f82a2
commit 6f95ebc7fd
5 changed files with 264 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
virtManager/details/details.py
+16 -20
View File
@@ -2381,27 +2381,23 @@ class vmmDetails(vmmGObjectUI):
elif controller.type in ["scsi", "sata", "ide", "fdc"]:
model = self.widget("controller-device-list").get_model()
model.clear()
for disk in _calculate_disk_bus_index(self.vm.xmlobj.devices.disk):
if disk.address.compare_controller(controller, disk.bus):
name = _label_for_device(disk)
infoStr = ("%s on %s" % (name, disk.address.pretty_desc()))
model.append([infoStr])
self._disable_device_remove(
_("Cannot remove controller while devices are attached."))
uiutil.set_grid_row_visible(self.widget("device-list-label"), True)
uiutil.set_grid_row_visible(self.widget("controller-device-box"), True)
disks = controller.get_attached_devices(self.vm.xmlobj)
for disk in disks:
name = _label_for_device(disk)
infoStr = ("%s on %s" % (name, disk.address.pretty_desc()))
model.append([infoStr])
self._disable_device_remove(
_("Cannot remove controller while devices are attached."))
uiutil.set_grid_row_visible(
self.widget("device-list-label"), True)
uiutil.set_grid_row_visible(
self.widget("controller-device-box"), True)
elif controller.type == "virtio-serial":
for dev in self.vm.xmlobj.devices.channel:
if dev.address.compare_controller(controller, dev.address.type):
self._disable_device_remove(
_("Cannot remove controller while devices are attached."))
break
for dev in self.vm.xmlobj.devices.console:
# virtio console is implied to be on virtio-serial index=0
if controller.index == 0 and dev.target_type == "virtio":
self._disable_device_remove(
_("Cannot remove controller while devices are attached."))
break
devs = controller.get_attached_devices(self.vm.xmlobj)
if devs:
self._disable_device_remove(
_("Cannot remove controller while devices are attached."))
type_label = vmmAddHardware.controller_pretty_desc(controller)
self.widget("controller-type").set_text(type_label)