From 799c82584cc294ecceee9047f5c9aed314ca85bb Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Sat, 19 Sep 2020 14:08:10 -0400 Subject: [PATCH] virt-manager: Stop suppressing all warnings This is hiding useful stuff. It was enabled once upon a time because it was too noisy but let's see if it gets bad like the past Signed-off-by: Cole Robinson --- virtManager/asyncjob.py | 2 +- virtManager/engine.py | 4 ++-- virtManager/systray.py | 2 ++ virtManager/virtmanager.py | 7 ------- 4 files changed, 5 insertions(+), 10 deletions(-) diff --git a/virtManager/asyncjob.py b/virtManager/asyncjob.py index d61bf6649..201aeae80 100644 --- a/virtManager/asyncjob.py +++ b/virtManager/asyncjob.py @@ -9,7 +9,6 @@ import traceback from gi.repository import Gdk from gi.repository import GLib -from gi.repository import Vte import libvirt @@ -319,6 +318,7 @@ class vmmAsyncJob(vmmGObjectUI): @idle_wrapper def details_enable(self): + from gi.repository import Vte self._details_widget = Vte.Terminal() self.widget("details-box").add(self._details_widget) self._details_widget.set_visible(True) diff --git a/virtManager/engine.py b/virtManager/engine.py index 1d83160a6..58fd8026c 100644 --- a/virtManager/engine.py +++ b/virtManager/engine.py @@ -83,8 +83,8 @@ class vmmEngine(vmmGObject): def _cleanup(self): - if self._timer is not None: - GLib.source_remove(self._timer) + # self._timer should be automatically cleaned up + pass ################# diff --git a/virtManager/systray.py b/virtManager/systray.py index 6f1a37a60..30794a019 100644 --- a/virtManager/systray.py +++ b/virtManager/systray.py @@ -18,6 +18,8 @@ from .connmanager import vmmConnectionManager try: # pylint: disable=ungrouped-imports + import gi + gi.require_version('AppIndicator3', '0.1') from gi.repository import AppIndicator3 except Exception: # pragma: no cover AppIndicator3 = None diff --git a/virtManager/virtmanager.py b/virtManager/virtmanager.py index 9fe49e9b1..f6d538bcc 100755 --- a/virtManager/virtmanager.py +++ b/virtManager/virtmanager.py @@ -22,13 +22,6 @@ from virtinst import log from .lib.testmock import CLITestOptionsClass -# This is massively heavy handed, but I can't figure out any way to shut -# up the slew of gtk deprecation warnings that clog up our very useful -# stdout --debug output. Of course we could drop use of deprecated APIs, -# but it's a serious quantity of churn -import warnings # pylint: disable=wrong-import-order -warnings.simplefilter("ignore") - try: gi.check_version("3.22.0") except (ValueError, AttributeError): # pragma: no cover