NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

virtManager.clone: don't generate clone path if we don't default to clone

Browse Source 
If we don't default to clone the disk in question don't try to generate
and assign default clone_path, this will force user to select the path
explicitly and avoid some unnecessary errors in debug log.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Pavel Hrdina 2017-03-06 09:28:50 +01:00 committed by Cole Robinson
parent d93203022a
commit 79baf8e30c
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
virtManager/clone.py
View File

@ -407,6 +407,13 @@ class vmmCloneVM(vmmGObjectUI):
storage_add(cloneinfo) storage_add(cloneinfo)
continue continue
storage_row[STORAGE_INFO_CAN_CLONE] = True
# If we cannot create default clone_path don't even try to do that
if not default:
storage_add()
continue
try: try:
# Generate disk path, make sure that works # Generate disk path, make sure that works
clone_path = self.generate_clone_path_name(path) clone_path = self.generate_clone_path_name(path)
@ -421,7 +428,6 @@ class vmmCloneVM(vmmGObjectUI):
clone_path) clone_path)
storage_add(str(e)) storage_add(str(e))
storage_row[STORAGE_INFO_CAN_CLONE] = True
storage_row[STORAGE_INFO_NEW_PATH] = clone_path storage_row[STORAGE_INFO_NEW_PATH] = clone_path
storage_row[STORAGE_INFO_SIZE] = self.pretty_storage(size) storage_row[STORAGE_INFO_SIZE] = self.pretty_storage(size)
storage_add() storage_add()