From 9ca05455331f95ffbf0ff0a3ce6b1cb0c06d974f Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Mon, 9 Sep 2013 13:06:37 -0400 Subject: [PATCH] addhw: Drop intro text, simplify UI alignment --- ui/vmm-add-hardware.ui | 3795 +++++++++++++++--------------------- virtManager/addhardware.py | 9 +- 2 files changed, 1621 insertions(+), 2183 deletions(-) diff --git a/ui/vmm-add-hardware.ui b/ui/vmm-add-hardware.ui index aadb1649d..4b8f34138 100644 --- a/ui/vmm-add-hardware.ui +++ b/ui/vmm-add-hardware.ui @@ -117,21 +117,10 @@ True False - + True False - - - True - False - label - - - True - True - 0 - - + label @@ -145,258 +134,93 @@ - + True False - 12 + start + 18 - + True False - 0 - Please indicate how you would like to assign space on the host system for your virtual storage device. - True - True - - - False - False - 0 - - - - - True - False - 24 + 4 - + True False - 18 + 6 - + + True + True + False + 0.5 + True + True + + + True + False + C_reate a disk image on the computer's hard drive + True + True + config-storage-create + + + + + False + True + 0 + + + + + True + True + 0 + + + + + True + False + 6 + 22 + + True False 4 - + True False 6 - - True - True - False - 0.5 - True - True - - - True - False - C_reate a disk image on the computer's hard drive - True - True - config-storage-create - - - - - False - True - 0 - - - - - True - True - 0 - - - - - True - False - 6 - 22 - - - True - False - 4 - - - True - False - 6 - - - True - True - - 5 - 1 - adjustment6 - 1 - 1 - - - False - False - 0 - - - - - True - False - _GB - True - config-storage-size - - - False - True - 1 - - - - - True - True - 0 - - - - - True - False - 0 - <span color='#484848'>Free Space</span> - True - - - False - True - 1 - - - - - True - False - 6 - - - _Allocate entire disk now - True - True - False - True - 0.5 - True - - - False - True - 0 - - - - - True - False - gtk-info - - - False - True - 1 - - - - - True - True - 2 - - - - - - - False - True - 1 - - - - - True - False - - - True - True - False - 0.5 - True - config-storage-create - - - - True - False - Select _managed or other existing storage - True - True - config-storage-select - - - - - False - True - 0 - - - - - True - True - 2 - - - - - True - False - False - 6 - - - Bro_wse... - True - True - True - True - - - - False - True - 0 - - - - - 335 + True True + 5 + 1 + adjustment6 + 1 + 1 + + + False + False + 0 + + + + + True + False + _GB + True + config-storage-size False @@ -408,123 +232,260 @@ True True - 3 + 0 + + + + + True + False + 0 + <span color='#484848'>Free Space</span> + True + + + False + True + 1 + + + + + True + False + 6 + + + _Allocate entire disk now + True + True + False + True + 0.5 + True + + + False + True + 0 + + + + + True + False + gtk-info + + + False + True + 1 + + + + + True + True + 2 + + + + False + True + 1 + + + + + True + False + + + True + True + False + 0.5 + True + config-storage-create + + + + True + False + Select _managed or other existing storage + True + True + config-storage-select + + + - True + False + True + 0 + + + + + True + True + 2 + + + + + True + False + False + 6 + + + Bro_wse... + True + True + True + True + + + + False True 0 - + + 335 True - False - 3 - 2 - 6 - 6 - - - True - False - - - Device Type Field - - - - - 1 - 2 - GTK_FILL - GTK_FILL - - - - - True - False - 0 - _Device type: - True - config-storage-devtype - - - GTK_FILL - - - - - True - False - 0 - Cac_he mode: - True - config-storage-cache - - - 1 - 2 - GTK_FILL - - - - - True - False - - - 1 - 2 - 1 - 2 - GTK_FILL - GTK_FILL - - - - - True - False - 0 - S_torage format: - True - - - 2 - 3 - GTK_FILL - - - - - True - False - True - - - True - - - - - 1 - 2 - 2 - 3 - - + True + - True + False True 1 + + True + False + 3 + + + + + False + True + 0 + + + + + True + False + 3 + 2 + 6 + 6 + + + True + False + + + Device Type Field + + + + + 1 + 2 + GTK_FILL + GTK_FILL + + + + + True + False + 0 + _Device type: + True + config-storage-devtype + + + GTK_FILL + GTK_FILL + + + + + True + False + 0 + Cac_he mode: + True + config-storage-cache + + + 1 + 2 + GTK_FILL + GTK_FILL + + + + + True + False + + + 1 + 2 + 1 + 2 + GTK_FILL + GTK_FILL + + + + + True + False + 0 + S_torage format: + True + + + 2 + 3 + GTK_FILL + GTK_FILL + + + + + True + False + True + + + False + + + + + 1 + 2 + 2 + 3 + GTK_FILL + GTK_FILL + @@ -536,6 +497,7 @@ 1 + False @@ -550,231 +512,42 @@ - + True False - 1 + 9 + 6 - + True False - 12 + 6 - + True - False - 0 - Please indicate how you'd like to connect your new virtual network device to the host network. - True - True + True + False + True + 0.5 + True + False - False + True 0 - + True - False - 24 - - - True - False - 9 - 6 - - - True - False - 6 - - - True - True - False - True - 0.5 - True - - - - False - True - 0 - - - - - True - True - 17 - - aa:bb:cc:dd:ee:ff - - - MAC Address Field - - - - - False - True - 1 - - - - - 1 - 2 - 1 - 1 - - - - - True - False - 0 - 0.23999999463558197 - _Host device: - True - net-list - - - 0 - 0 - 1 - 1 - - - - - True - False - 0 - _MAC address: - True - True - create-mac-address - - - 0 - 2 - 1 - 1 - - - - - True - False - 0 - D_evice model: - True - net-model - - - 0 - 3 - 1 - 1 - - - - - True - False - 6 - - - True - False - _Bridge name: - True - net-bridge - - - False - True - 0 - - - - - True - True - - True - - - False - True - 1 - - - - - 1 - 1 - 1 - 1 - - - - - True - False - 6 - - - True - False - - - False - True - 0 - - - - - True - False - gtk-dialog-warning - - - False - True - 1 - - - - - 1 - 0 - 1 - 1 - - - - - True - False - start - - - 1 - 3 - 1 - 1 - - - - - + True + 17 + + aa:bb:cc:dd:ee:ff + + + MAC Address Field @@ -786,9 +559,164 @@ - False - True - 0 + 1 + 2 + 1 + 1 + + + + + True + False + 0 + 0.23999999463558197 + _Host device: + True + net-list + + + 0 + 0 + 1 + 1 + + + + + True + False + 0 + _MAC address: + True + True + create-mac-address + + + 0 + 2 + 1 + 1 + + + + + True + False + 0 + D_evice model: + True + net-model + + + 0 + 3 + 1 + 1 + + + + + True + False + 6 + + + True + False + _Bridge name: + True + net-bridge + + + False + True + 0 + + + + + True + True + + True + + + False + True + 1 + + + + + 1 + 1 + 1 + 1 + + + + + True + False + 6 + + + True + False + + + False + True + 0 + + + + + True + False + gtk-dialog-warning + + + False + True + 1 + + + + + 1 + 0 + 1 + 1 + + + + + True + False + start + + + 1 + 3 + 1 + 1 + + + + + True + False + + + + + + 0 + 1 + 1 + 1 @@ -808,107 +736,35 @@ - + True False - 1 + 2 + 6 + 6 - + True False - 12 - - - True - False - 0 - Please indicate what kind of pointer device to connect to the virtual machine. - True - True - - - False - False - 0 - - - - - True - False - 24 - - - True - False - 6 - 2 - 6 - 6 - - - True - False - 1 - _Type: - True - input-type - - - GTK_FILL - - - - - - True - False - - - True - False - - - False - True - 0 - - - - - True - False - - - - - - True - True - 1 - - - - - 1 - 2 - GTK_FILL - - - - - - - False - True - 1 - - + 1 + _Type: + True - False - True - 0 + GTK_FILL + + + + + + True + False + + + 1 + 2 + GTK_FILL + GTK_FILL @@ -928,23 +784,38 @@ - + True False - 1 + 6 + 6 - + + True + False + start + + + + 1 + 0 + 1 + 1 + + + + True False - 12 - + True - False + True + False + True 0 - Please indicate how you would like to view the virtual display. - True - True + True + False @@ -953,272 +824,211 @@ - + True - False - 24 - - - True - False - 6 - 6 - - - True - False - start - - - - 1 - 0 - 1 - 1 - - - - - True - False - - - True - True - False - True - 0 - True - - - - False - False - 0 - - - - - True - True - False - - True - - - False - True - 1 - - - - - 1 - 4 - 1 - 1 - - - - - True - False - 1 - _Type: - True - graphics-type - - - 0 - 0 - 1 - 1 - - - - - True - False - 1 - _Address: - True - graphics-address - - - 0 - 1 - 1 - 1 - - - - - True - False - 1 - Pa_ssword: - True - graphics-password - - - 0 - 4 - 1 - 1 - - - - - True - False - 1 - _Port: - True - graphics-port - - - 0 - 2 - 1 - 1 - - - - - True - False - - - - - - 0 - 3 - 1 - 1 - - - - - A_utomatically allocated - True - True - False - True - 0 - True - - - - 1 - 2 - 1 - 1 - - - - - True - False - 12 - - - True - True - - True - adjustment5 - 1 - True - True - if-valid - - - False - True - 0 - - - - - True - False - 6 - - - True - False - 1 - _TLS port: - True - graphics-port - - - False - True - 0 - - - - - True - True - - True - adjustment4 - 1 - True - True - if-valid - - - False - True - 1 - - - - - False - True - 1 - - - - - 1 - 3 - 1 - 1 - - - - - True - False - start - - - 1 - 1 - 1 - 1 - - - - + True + False + + True False - False + True 1 - True - True - 0 + 1 + 4 + 1 + 1 + + + + + True + False + 1 + _Type: + True + graphics-type + + + 0 + 0 + 1 + 1 + + + + + True + False + 1 + _Address: + True + graphics-address + + + 0 + 1 + 1 + 1 + + + + + True + False + 1 + Pa_ssword: + True + graphics-password + + + 0 + 4 + 1 + 1 + + + + + True + False + 1 + _Port: + True + graphics-port + + + 0 + 2 + 1 + 1 + + + + + True + False + + + + + + 0 + 3 + 1 + 1 + + + + + A_utomatically allocated + True + True + False + True + 0 + True + + + + 1 + 2 + 1 + 1 + + + + + True + False + 12 + + + True + True + + True + adjustment5 + 1 + True + True + if-valid + + + False + True + 0 + + + + + True + False + 6 + + + True + False + 1 + _TLS port: + True + graphics-port + + + False + True + 0 + + + + + True + True + + True + adjustment4 + 1 + True + True + if-valid + + + False + True + 1 + + + + + False + True + 1 + + + + + 1 + 3 + 1 + 1 + + + + + True + False + start + + + 1 + 1 + 1 + 1 @@ -1238,82 +1048,36 @@ - + True False - 1 + 2 + 6 + 6 - + True False - 12 - - - True - False - 0 - Please indicate what sound device type to connect to the virtual machine. - True - True - - - False - False - 0 - - - - - True - False - 24 - - - True - False - 2 - 6 - 6 - - - True - False - - - 1 - 2 - GTK_FILL - GTK_FILL - - - - - True - False - 1 - _Model: - True - sound-model - - - GTK_FILL - - - - - - - - False - True - 1 - - - True - True - 0 + 1 + 2 + GTK_FILL + GTK_FILL + + + + + True + False + 1 + _Model: + True + sound-model + + + GTK_FILL + @@ -1333,108 +1097,62 @@ - + True False - 1 + 2 + 2 + 6 + 6 - + True False - 12 + 0 + 1 + Host _Device: + True + host-device + + + GTK_FILL + GTK_FILL + + + + + True + True + etched-in - + True - False - 0 - Please indicate what physical device -to connect to the virtual machine. - True - True - - - False - False - 0 - - - - - True - False - - - True - False - 2 - 2 - 6 - 6 - - - True - False - 0 - 1 - Host _Device: - True - host-device - - - GTK_FILL - GTK_FILL - - - - - True - True - etched-in - - - True - True - False - - - - - - - - 2 - 1 - 2 - - - - - True - False - - - - - - 1 - 2 - GTK_FILL - - - + True + False + + - - True - True - 1 - - True - True - 0 + 2 + 1 + 2 + + + + + True + False + + + + + + 1 + 2 + GTK_FILL @@ -1454,311 +1172,290 @@ to connect to the virtual machine. - + True False - 1 - 6 + 6 + 6 - + + True + True + + + 1 + 2 + 1 + 1 + + + + + True + True + False + 0.5 + True + + + 1 + 6 + 1 + 1 + + + + True False - 2 - 24 + start + + + 1 + 3 + 1 + 1 + + + + + True + False + 6 - + + True + True + + + True + True + 0 + + + + True False - 6 - 6 - - - True - True - - - 1 - 2 - 1 - 1 - - - - - True - True - False - 0.5 - True - - - 1 - 6 - 1 - 1 - - - - - True - False - start - - - 1 - 3 - 1 - 1 - - - - - True - False - 6 - - - True - True - - - True - True - 0 - - - - - True - False - 0 - _Port: - True - char-port - - - False - True - 1 - - - - - True - True - adjustment3 - - - False - True - 2 - - - - - 1 - 4 - 1 - 1 - - - - - True - False - 6 - - - True - True - - - True - True - 0 - - - - - True - False - 0 - Po_rt: - True - char-bind-port - - - False - True - 1 - - - - - True - True - adjustment2 - - - False - True - 2 - - - - - 1 - 5 - 1 - 1 - - - - - True - False - 0 - _Path: - True - char-path - - - 0 - 2 - 1 - 1 - - - - - True - False - 0 - _Mode: - True - char-mode - - - 0 - 3 - 1 - 1 - - - - - True - False - 0 - H_ost: - True - char-host - - - 0 - 4 - 1 - 1 - - - - - True - False - 0 - _Bind Host: - True - char-bind-host - - - 0 - 5 - 1 - 1 - - - - - True - False - 0 - Use Te_lnet: - True - char-use-telnet - - - 0 - 6 - 1 - 1 - - - - - True - False - 0 - Device _Type: - True - char-device-type - - - 0 - 0 - 1 - 1 - - - - - True - False - start - - - - 1 - 0 - 1 - 1 - - - - - True - False - 0 - _Name: - True - char-target-name - - - 0 - 1 - 1 - 1 - - - - - True - True - - - - 1 - 1 - 1 - 1 - - + 0 + _Port: + True + char-port + + False + True + 1 + + + + + True + True + adjustment3 + + + False + True + 2 + - True - True - 0 + 1 + 4 + 1 + 1 + + + + + True + False + 6 + + + True + True + + + True + True + 0 + + + + + True + False + 0 + Po_rt: + True + char-bind-port + + + False + True + 1 + + + + + True + True + adjustment2 + + + False + True + 2 + + + + + 1 + 5 + 1 + 1 + + + + + True + False + 0 + _Path: + True + char-path + + + 0 + 2 + 1 + 1 + + + + + True + False + 0 + _Mode: + True + char-mode + + + 0 + 3 + 1 + 1 + + + + + True + False + 0 + H_ost: + True + char-host + + + 0 + 4 + 1 + 1 + + + + + True + False + 0 + _Bind Host: + True + char-bind-host + + + 0 + 5 + 1 + 1 + + + + + True + False + 0 + Use Te_lnet: + True + char-use-telnet + + + 0 + 6 + 1 + 1 + + + + + True + False + 0 + Device _Type: + True + char-device-type + + + 0 + 0 + 1 + 1 + + + + + True + False + start + + + + 1 + 0 + 1 + 1 + + + + + True + False + 0 + _Name: + True + char-target-name + + + 0 + 1 + 1 + 1 + + + + + True + True + + + + 1 + 1 + 1 + 1 @@ -1778,71 +1475,36 @@ to connect to the virtual machine. - + True False - 12 + 2 + 6 + 6 - + True False - 0 - Please indicate what video device type -to connect to the virtual machine. - True - True - False - False - 0 + 1 + 2 + GTK_FILL + GTK_FILL - + True False - 24 - - - True - False - 2 - 6 - 6 - - - True - False - - - 1 - 2 - GTK_FILL - GTK_FILL - - - - - True - False - 0 - _Model: - True - video-model - - - GTK_FILL - GTK_FILL - - - - + 0 + _Model: + True + video-model - False - True - 1 + GTK_FILL + GTK_FILL @@ -1862,113 +1524,66 @@ to connect to the virtual machine. - + True False - 1 + 2 + 2 + 6 + 6 - + True False - 12 - - - True - False - 0 - Please indicate what watchdog device type -and default action should be used. - True - True - - - False - False - 0 - - - - - True - False - 24 - - - True - False - 2 - 2 - 6 - 6 - - - True - False - - - 1 - 2 - GTK_FILL - GTK_FILL - - - - - True - False - 0 - _Model: - True - watchdog-model - - - GTK_FILL - GTK_FILL - - - - - True - False - Ac_tion: - True - watchdog-action - - - 1 - 2 - GTK_FILL - GTK_FILL - - - - - True - False - - - 1 - 2 - 1 - 2 - GTK_FILL - GTK_FILL - - - - - - - False - True - 1 - - - True - True - 0 + 1 + 2 + GTK_FILL + GTK_FILL + + + + + True + False + 0 + _Model: + True + watchdog-model + + + GTK_FILL + GTK_FILL + + + + + True + False + Ac_tion: + True + watchdog-action + + + 1 + 2 + GTK_FILL + GTK_FILL + + + + + True + False + + + 1 + 2 + 1 + 2 + GTK_FILL + GTK_FILL @@ -1988,371 +1603,336 @@ and default action should be used. - + True False - 12 + 6 + 6 - + True False - 0 - Please indicate which host directory to -access in the guest. - True - True - - - False - False - 0 - - - - - True - False - 24 - + True False - 6 - 6 - - - True - False - - - True - False - - - - False - True - 0 - - - - - True - False - 0 - Passthrough - - - True - True - 1 - - - - - 1 - 0 - 1 - 1 - - - - - True - False - - - True - False - - - False - True - 0 - - - - - True - False - 0 - Default - - - True - True - 1 - - - - - 1 - 2 - 1 - 1 - - - - - True - False - - - True - False - - - - False - True - 0 - - - - - True - False - 0 - Default - - - True - True - 1 - - - - - 1 - 1 - 1 - 1 - - - - - True - False - - - True - False - - - False - True - 0 - - - - - True - False - 0 - Default - - - True - True - 1 - - - - - 1 - 3 - 1 - 1 - - - - - True - True - - - - 1 - 5 - 1 - 1 - - - - - E_xport filesystem as readonly mount - True - True - False - True - 0.5 - True - - - 1 - 6 - 1 - 1 - - - - - True - False - 6 - - - True - True - - - - True - True - 0 - - - - - _Browse... - True - True - True - True - - - - False - True - 1 - - - - - 1 - 4 - 1 - 1 - - - - - True - False - 0 - _Type: - True - fs-type-combo - - - 0 - 0 - 1 - 1 - - - - - True - False - 0 - _Mode: - True - fs-mode-combo - - - 0 - 2 - 1 - 1 - - - - - True - False - 0 - _Driver: - True - fs-driver-combo - - - 0 - 1 - 1 - 1 - - - - - True - False - 0 - _Write Policy: - True - fs-wrpolicy-combo - - - 0 - 3 - 1 - 1 - - - - - True - False - 0 - src labelll: - True - fs-source - - - 0 - 4 - 1 - 1 - - - - - True - False - 0 - Ta_rget path: - True - fs-target - - - 0 - 5 - 1 - 1 - - - - - True - False - - - - - - 0 - 6 - 1 - 1 - - + + + False + True + 0 + + + + + True + False + 0 + Passthrough + + + True + True + 1 + - False - True - 1 + 1 + 0 + 1 + 1 + + + + + True + False + + + True + False + + + False + True + 0 + + + + + True + False + 0 + Default + + + True + True + 1 + + + + + 1 + 2 + 1 + 1 + + + + + True + False + + + True + False + + + + False + True + 0 + + + + + True + False + 0 + Default + + + True + True + 1 + + + + + 1 + 1 + 1 + 1 + + + + + True + False + + + True + False + + + False + True + 0 + + + + + True + False + 0 + Default + + + True + True + 1 + + + + + 1 + 3 + 1 + 1 + + + + + True + True + + + + 1 + 5 + 1 + 1 + + + + + E_xport filesystem as readonly mount + True + True + False + True + 0.5 + True + + + 1 + 6 + 1 + 1 + + + + + True + False + 6 + + + True + True + + + + True + True + 0 + + + + + _Browse... + True + True + True + True + + + + False + True + 1 + + + + + 1 + 4 + 1 + 1 + + + + + True + False + 0 + _Type: + True + fs-type-combo + + + 0 + 0 + 1 + 1 + + + + + True + False + 0 + _Mode: + True + fs-mode-combo + + + 0 + 2 + 1 + 1 + + + + + True + False + 0 + _Driver: + True + fs-driver-combo + + + 0 + 1 + 1 + 1 + + + + + True + False + 0 + _Write Policy: + True + fs-wrpolicy-combo + + + 0 + 3 + 1 + 1 + + + + + True + False + 0 + src labelll: + True + fs-source + + + 0 + 4 + 1 + 1 + + + + + True + False + 0 + Ta_rget path: + True + fs-target + + + 0 + 5 + 1 + 1 + + + + + True + False + + + + + + 0 + 6 + 1 + 1 @@ -2372,82 +1952,36 @@ access in the guest. - + True False - 1 + 2 + 6 + 6 - + True False - 12 - - - True - False - 0 - Please indicate what smartcard device mode to connect to the virtual machine. - True - True - - - False - False - 0 - - - - - True - False - 24 - - - True - False - 2 - 6 - 6 - - - True - False - - - 1 - 2 - GTK_FILL - GTK_FILL - - - - - True - False - 1 - _Mode: - True - smartcard-mode - - - GTK_FILL - - - - - - - - False - True - 1 - - - True - True - 0 + 1 + 2 + GTK_FILL + GTK_FILL + + + + + True + False + 1 + _Mode: + True + smartcard-mode + + + GTK_FILL + @@ -2467,141 +2001,107 @@ access in the guest. - + True False - 12 + 6 + 12 - + True False - 0 - Please indicate the parameters of the redirected device. - True - True - - - False - False - 0 - - - - - True - False - 24 + 6 - + + True + True + + + + True + True + 0 + + + + True False - 6 - 12 - - - True - False - 6 - - - True - True - - - - True - True - 0 - - - - - True - False - 0 - _Port: - True - usbredir-service - - - False - True - 1 - - - - - True - True - adjustment1 - 1 - - - False - True - 2 - - - - - 1 - 1 - 1 - 1 - - - - - True - False - 1 - _Type: - True - - - 0 - 0 - 1 - 1 - - - - - True - False - 1 - _Host: - True - usbredir-host - - - 0 - 1 - 1 - 1 - - - - - True - False - start - - - - 1 - 0 - 1 - 1 - - + 0 + _Port: + True + usbredir-service + + False + True + 1 + + + + + True + True + adjustment1 + 1 + + + False + True + 2 + - False - True - 1 + 1 + 1 + 1 + 1 + + + + + True + False + 1 + _Type: + True + + + 0 + 0 + 1 + 1 + + + + + True + False + 1 + _Host: + True + usbredir-host + + + 0 + 1 + 1 + 1 + + + + + True + False + start + + + + 1 + 0 + 1 + 1 @@ -2621,122 +2121,65 @@ access in the guest. - + True False - 1 + 6 + 6 - + True - False - 12 - - - True - False - 0 - Please indicate what TPM device type to connect to the virtual machine. - True - True - - - False - False - 0 - - - - - True - False - 0 - none - - - True - False - 2 - 24 - - - True - False - 2 - 2 - 6 - 6 - - - True - False - - - - 1 - 2 - GTK_FILL - GTK_FILL - - - - - True - False - 1 - _Backend: - True - tpm-type - - - GTK_FILL - - - - - - True - False - 0 - Device Path: - - - 1 - 2 - GTK_FILL - - - - - - True - True - - - - 1 - 2 - 1 - 2 - GTK_FILL - GTK_FILL - - - - - - - - - False - True - 2 - - + True + - True - True - 0 + 1 + 1 + 1 + 1 + + + + + True + False + 0 + Device Path: + + + 0 + 1 + 1 + 1 + + + + + True + False + + + + 1 + 0 + 1 + 1 + + + + + True + False + 1 + _Backend: + True + tpm-type + + + 0 + 0 + 1 + 1 diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py index 88acb0916..aad5c5c53 100644 --- a/virtManager/addhardware.py +++ b/virtManager/addhardware.py @@ -958,13 +958,8 @@ class vmmAddHardware(vmmGObjectUI): show_something = False for param_name, widget_name in tpm_widget_mappings.items(): make_visible = self._dev.supports_property(param_name) - if make_visible: - show_something = True - - self.widget(widget_name).set_visible(make_visible) - self.widget(widget_name + "-label").set_visible(make_visible) - - self.widget("tpm-param-box").set_visible(show_something) + uihelpers.set_grid_row_visible(self.widget(widget_name + "-label"), + make_visible) def change_char_device_type(self, src): idx = src.get_active()