From 9e56169813763caf723427c6bb7fc4472c002d35 Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Wed, 5 Jun 2019 14:45:48 -0400 Subject: [PATCH] connection: Drop unused filter_nodedevs devcap value --- virtManager/connection.py | 8 +------- virtManager/details.py | 2 +- virtManager/mediacombo.py | 2 +- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/virtManager/connection.py b/virtManager/connection.py index 0c7492e8a..091679acd 100644 --- a/virtManager/connection.py +++ b/virtManager/connection.py @@ -595,7 +595,7 @@ class vmmConnection(vmmGObject): # nodedev helper functions # ############################ - def filter_nodedevs(self, devtype=None, devcap=None): + def filter_nodedevs(self, devtype): retdevs = [] for dev in self.list_nodedevs(): try: @@ -610,13 +610,7 @@ class vmmConnection(vmmGObject): if devtype and xmlobj.device_type != devtype: continue - if devcap: - if (not hasattr(xmlobj, "capability_type") or - xmlobj.capability_type != devcap): - continue - retdevs.append(dev) - return retdevs diff --git a/virtManager/details.py b/virtManager/details.py index 0dfcecb9c..e549c1175 100644 --- a/virtManager/details.py +++ b/virtManager/details.py @@ -2412,7 +2412,7 @@ class vmmDetails(vmmGObjectUI): devtype = 'usb_device' nodedev = None - for trydev in self.vm.conn.filter_nodedevs(devtype, None): + for trydev in self.vm.conn.filter_nodedevs(devtype): if trydev.xmlobj.compare_to_hostdev(hostdev): nodedev = trydev.xmlobj diff --git a/virtManager/mediacombo.py b/virtManager/mediacombo.py index 45c03432d..3963beabb 100644 --- a/virtManager/mediacombo.py +++ b/virtManager/mediacombo.py @@ -90,7 +90,7 @@ class vmmMediaCombo(vmmGObjectUI): def _make_nodedev_rows(self, media_type): rows = [] - for nodedev in self.conn.filter_nodedevs(devtype="storage"): + for nodedev in self.conn.filter_nodedevs("storage"): if not (nodedev.xmlobj.device_type == "storage" and nodedev.xmlobj.drive_type in ["cdrom", "floppy"]): continue