NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Better logging and error avoidance with net/disk stats routines.

Browse Source
This commit is contained in:
Cole Robinson 2009-09-16 16:01:54 -04:00
parent 31509207c2
commit 9fe564e14b
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/virtManager/domain.py
View File

@ -337,8 +337,12 @@ class vmmDomain(gobject.GObject):
return rx, tx return rx, tx
for netdev in self.get_network_devices(refresh_if_necc=False): for netdev in self.get_network_devices(refresh_if_necc=False):
dev = netdev[4]
if not dev:
continue
try: try:
io = self.vm.interfaceStats(netdev[4]) io = self.vm.interfaceStats(dev)
if io: if io:
rx += io[0] rx += io[0]
tx += io[4] tx += io[4]
@ -347,7 +351,9 @@ class vmmDomain(gobject.GObject):
logging.debug("Net stats not supported: %s" % err) logging.debug("Net stats not supported: %s" % err)
self._stats_net_supported = False self._stats_net_supported = False
else: else:
logging.error("Error reading net stats: %s" % err) logging.error("Error reading net stats for "
"'%s' dev '%s': %s" %
(self.get_name(), dev, err))
return rx, tx return rx, tx
def _sample_disk_io_dummy(self): def _sample_disk_io_dummy(self):
@ -360,8 +366,12 @@ class vmmDomain(gobject.GObject):
return rd, wr return rd, wr
for disk in self.get_disk_devices(refresh_if_necc=False): for disk in self.get_disk_devices(refresh_if_necc=False):
dev = disk[2]
if not dev:
continue
try: try:
io = self.vm.blockStats(disk[2]) io = self.vm.blockStats(dev)
if io: if io:
rd += io[1] rd += io[1]
wr += io[3] wr += io[3]
@ -370,7 +380,9 @@ class vmmDomain(gobject.GObject):
logging.debug("Disk stats not supported: %s" % err) logging.debug("Disk stats not supported: %s" % err)
self._stats_disk_supported = False self._stats_disk_supported = False
else: else:
logging.error("Error reading disk stats: %s" % err) logging.error("Error reading disk stats for "
"'%s' dev '%s': %s" %
(self.get_name(), dev, err))
return rd, wr return rd, wr
def _get_cur_rate(self, what): def _get_cur_rate(self, what):