From a10fda6b5c74c781e269073816b913d03a23ca87 Mon Sep 17 00:00:00 2001
From: Cole Robinson <crobinso@redhat.com>
Date: Sun, 21 Jan 2018 12:40:15 -0500
Subject: [PATCH] uitests: console: Add live lxc serial test

---
 tests/uitests/console.py                 | 10 ++++++++++
 tests/uitests/xml/uitests-lxc-serial.xml | 14 ++++++++++++++
 ui/details.ui                            |  5 +++++
 virtManager/serialcon.py                 |  1 +
 4 files changed, 30 insertions(+)
 create mode 100644 tests/uitests/xml/uitests-lxc-serial.xml

diff --git a/tests/uitests/console.py b/tests/uitests/console.py
index 83cb5d266..7b2dfe77c 100644
--- a/tests/uitests/console.py
+++ b/tests/uitests/console.py
@@ -123,3 +123,13 @@ class Console(uiutils.UITestCase):
         return self._checkPassword()
 
 
+    @_vm_wrapper("uitests-lxc-serial", uri="lxc:///")
+    def testConsoleLXCSerial(self):
+        """
+        Ensure LXC has serial open, and we can send some data
+        """
+        win = self.app.topwin
+        term = win.find("Serial Terminal")
+        self.assertTrue(term.showing)
+        term.typeText("help\n")
+        self.assertTrue("COMMANDS" in term.text)
diff --git a/tests/uitests/xml/uitests-lxc-serial.xml b/tests/uitests/xml/uitests-lxc-serial.xml
new file mode 100644
index 000000000..1ed357f22
--- /dev/null
+++ b/tests/uitests/xml/uitests-lxc-serial.xml
@@ -0,0 +1,14 @@
+<domain type='lxc'>
+  <name>uitests-lxc-serial</name>
+  <memory unit='KiB'>1048576</memory>
+  <currentMemory unit='KiB'>1048576</currentMemory>
+  <vcpu placement='static'>1</vcpu>
+  <os>
+    <type arch='x86_64'>exe</type>
+    <init>/bin/sh</init>
+  </os>
+  <devices>
+    <console type='pty'/>
+  </devices>
+</domain>
+
diff --git a/ui/details.ui b/ui/details.ui
index 2a4e39593..e0689f4d5 100644
--- a/ui/details.ui
+++ b/ui/details.ui
@@ -6165,6 +6165,11 @@
                   <object class="GtkNotebook" id="serial-pages">
                     <property name="visible">True</property>
                     <property name="can_focus">True</property>
+                    <child internal-child="accessible">
+                      <object class="AtkObject" id="serial-pages-atkobject">
+                        <property name="AtkObject::accessible-name">serial-pages</property>
+                      </object>
+                    </child>
                   </object>
                   <packing>
                     <property name="position">2</property>
diff --git a/virtManager/serialcon.py b/virtManager/serialcon.py
index 21ab8ae71..176e94b80 100644
--- a/virtManager/serialcon.py
+++ b/virtManager/serialcon.py
@@ -336,6 +336,7 @@ class vmmSerialConsole(vmmGObject):
         self.terminal = Vte.Terminal()
         self.terminal.set_scrollback_lines(1000)
         self.terminal.set_audible_bell(False)
+        self.terminal.get_accessible().set_name("Serial Terminal")
 
         self.terminal.connect("button-press-event", self.show_serial_rcpopup)
         self.terminal.connect("commit", self.console.send_data, self.terminal)