NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

delete: Fix ambiguity that confused pylint

Browse Source 
virtManager/delete.py:219:11: E0601: Using variable 'error' before assignment (used-before-assignment)

Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Cole Robinson 2023-09-24 16:13:00 -04:00
parent 775edfd5dc
commit ab0a318a46
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
virtManager/delete.py
View File

@ -179,8 +179,9 @@ class _vmmDeleteBase(vmmGObjectUI):
self._set_vm(None)
def _async_delete(self, asyncjob, vm, paths):
details = ""
errdata = None
storage_errors = []
try:
self._destroy_vm(vm)
@ -191,33 +192,32 @@ class _vmmDeleteBase(vmmGObjectUI):
self._delete_vm(vm)
vm.conn.schedule_priority_tick(pollvm=True)
except Exception as e: # pragma: no cover
error = _("Error deleting virtual machine '%(vm)s': %(error)s") % {
"vm": vm.get_name(),
"error": str(e),
}
details = "".join(traceback.format_exc())
errdata = (
(_("Error deleting virtual machine '%(vm)s': %(error)s") %
{"vm": vm.get_name(), "error": str(e)}),
"".join(traceback.format_exc()))
if not storage_errors and not errdata:
return
storage_errstr = ""
for errinfo in storage_errors:
storage_errstr += "%s\n%s\n" % (errinfo[0], errinfo[1])
if not storage_errstr and not details:
return
# We had extra storage errors. If there was another error message,
# errors to it. Otherwise, build the main error around them.
if details: # pragma: no cover
if errdata: # pragma: no cover
error, details = errdata
details += "\n\n"
details += _("Additionally, there were errors removing"
" certain storage devices: \n")
" certain storage devices: \n")
details += storage_errstr
else:
error = _("Errors encountered while removing certain "
"storage devices.")
"storage devices.")
details = storage_errstr
if error:
asyncjob.set_error(error, details)
asyncjob.set_error(error, details)
def _async_delete_paths(self, paths, conn, meter):
storage_errors = []