NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-10 23:45:49 -06:00
Code Issues Packages Projects Releases Wiki Activity

console: Warn if qemu+tcp URI and listen == 127.0.0.1

Browse Source
This commit is contained in:
Cole Robinson 2013-06-30 11:44:58 -04:00
parent a6d3b0ca14
commit bc13c302de
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
virtManager/console.py
View File

@ -77,6 +77,12 @@ class ConnectionInfo(object):
return self.transport in ["ssh", "ext"] return self.transport in ["ssh", "ext"]
def is_bad_localhost(self):
host, port = self.get_conn_host()
if self.need_tunnel():
return False
return self.transport and host == "127.0.0.1"
def get_conn_host(self): def get_conn_host(self):
host = self._connhost host = self._connhost
port = self._connport port = self._connport
@ -1125,6 +1131,14 @@ class vmmConsolePages(vmmGObjectUI):
self.activate_unavailable_page(msg) self.activate_unavailable_page(msg)
return return
if ginfo.is_bad_localhost():
self.activate_unavailable_page(
_("Guest is on a remote host with transport '%s'\n"
"but is only configured to listen on 127.0.0.1.\n"
"Connect using 'ssh' transport or change the\n"
"guest's listen address." % ginfo.transport))
return
if ginfo.console_active(): if ginfo.console_active():
self.activate_unavailable_page( self.activate_unavailable_page(
_("Graphical console is not yet active for guest")) _("Graphical console is not yet active for guest"))