From c33eb562c28e2a289c2f9607c6e53eb512389b71 Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Mon, 10 Jun 2019 16:09:02 -0400 Subject: [PATCH] devices: graphics: Test remaining code coverage --- tests/xmlparse.py | 3 +++ virtinst/devices/graphics.py | 7 +------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/xmlparse.py b/tests/xmlparse.py index 311d01de4..1eeae4b68 100644 --- a/tests/xmlparse.py +++ b/tests/xmlparse.py @@ -766,6 +766,9 @@ class XMLParseTest(unittest.TestCase): self._alter_compare(guest.get_xml(), outfile) + # Call this for code coverage + self.assertTrue(bool(virtinst.DeviceGraphics.valid_keymaps())) + def testAlterHostdevs(self): infile = "tests/xmlparse-xml/change-hostdevs-in.xml" outfile = "tests/xmlparse-xml/change-hostdevs-out.xml" diff --git a/virtinst/devices/graphics.py b/virtinst/devices/graphics.py index 4b687a8cb..faf4eabcb 100644 --- a/virtinst/devices/graphics.py +++ b/virtinst/devices/graphics.py @@ -52,8 +52,6 @@ class DeviceGraphics(Device): CHANNEL_TYPE_RECORD = "record" KEYMAP_LOCAL = "local" - KEYMAP_DEFAULT = "default" - _special_keymaps = [KEYMAP_LOCAL, KEYMAP_DEFAULT] @staticmethod def valid_keymaps(): @@ -89,10 +87,7 @@ class DeviceGraphics(Device): return self._local_keymap def _set_keymap(self, val): - if val == self.KEYMAP_DEFAULT: - # Leave it up to the hypervisor - val = None - elif val == self.KEYMAP_LOCAL: + if val == self.KEYMAP_LOCAL: val = self._get_local_keymap() self._keymap = val def _get_keymap(self):