NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-09 23:15:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

domain: Clean up some support checks

Browse Source 
We don't need to cache things since virtinst/connection does it for
us.
This commit is contained in:
Cole Robinson 2013-09-29 09:56:48 -04:00
parent 66f71262f0
commit cd7837bc4b
2 changed files with 6 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
virtManager/connection.py
View File

@ -99,7 +99,6 @@ class vmmConnection(vmmGObject):
self._nodedev_capable = None
self._xml_flags = {}
self._support_dict = {}
# Physical network interfaces: name -> virtinst.NodeDevice
self.nodedevs = {}
@ -516,15 +515,6 @@ class vmmConnection(vmmGObject):
return self._get_flags_helper(vm, key, check_func)
def get_dom_managedsave_supported(self, vm):
key = self._backend.SUPPORT_DOMAIN_MANAGED_SAVE
if key not in self._support_dict:
val = self.check_domain_support(vm, key)
logging.debug("Connection managed save support: %s", val)
self._support_dict[key] = val
return self._support_dict[key]
def get_interface_flags(self, iface):
key = "interface"

23
virtManager/domain.py
View File

@ -199,8 +199,6 @@ class vmmDomain(vmmLibvirtObject):
self.lastStatus = libvirt.VIR_DOMAIN_SHUTOFF
self._getvcpus_supported = None
self._getjobinfo_supported = None
self.managedsave_supported = False
self.remote_console_supported = False
self.snapshots_supported = False
@ -227,31 +225,22 @@ class vmmDomain(vmmLibvirtObject):
self._snapshot_list = None
def _get_getvcpus_supported(self):
if self._getvcpus_supported is None:
self._getvcpus_supported = True
try:
self._backend.vcpus()
except libvirt.libvirtError, err:
if util.is_error_nosupport(err):
self._getvcpus_supported = False
return self._getvcpus_supported
return self.conn.check_domain_support(self._backend,
self.conn.SUPPORT_DOMAIN_GETVCPUS)
getvcpus_supported = property(_get_getvcpus_supported)
def _get_getjobinfo_supported(self):
if self._getjobinfo_supported is None:
self._getjobinfo_supported = self.conn.check_domain_support(
self._backend,
return self.conn.check_domain_support(self._backend,
self.conn.SUPPORT_DOMAIN_JOB_INFO)
return self._getjobinfo_supported
getjobinfo_supported = property(_get_getjobinfo_supported)
def _libvirt_init(self):
"""
Initialization to do if backed by a libvirt virDomain
"""
self.managedsave_supported = self.conn.get_dom_managedsave_supported(
self._backend)
self.managedsave_supported = self.conn.check_domain_support(
self._backend,
self.conn.SUPPORT_DOMAIN_MANAGED_SAVE)
self.remote_console_supported = self.conn.check_domain_support(
self._backend,
self.conn.SUPPORT_DOMAIN_CONSOLE_STREAM)