NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

serialcon: Don't open a console with name=None

Browse Source 
Can crash libvirt on f16, which is what happens when a user tries to open
dom-0 console
This commit is contained in:
Cole Robinson 2012-01-29 13:02:13 -05:00
parent 006ba306f7
commit ce94126b70
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/virtManager/serialcon.py
View File

@ -183,11 +183,14 @@ class LibvirtConsoleConnection(ConsoleConnection):
if self.stream: if self.stream:
self.close() self.close()
self.stream = self.conn.vmm.newStream(libvirt.VIR_STREAM_NONBLOCK)
name = dev and dev.alias.name or None name = dev and dev.alias.name or None
logging.debug("Opening console stream for dev=%s alias=%s", logging.debug("Opening console stream for dev=%s alias=%s",
dev, name) dev, name)
if not name:
raise RuntimeError(_("Cannot open a device with no alias name"))
self.stream = self.conn.vmm.newStream(libvirt.VIR_STREAM_NONBLOCK)
self.vm.open_console(name, self.stream) self.vm.open_console(name, self.stream)
self.stream.eventAddCallback((libvirt.VIR_STREAM_EVENT_READABLE | self.stream.eventAddCallback((libvirt.VIR_STREAM_EVENT_READABLE |