From d62ca8220b822783205e18ad7b84a631497421b3 Mon Sep 17 00:00:00 2001 From: Michael Weiser Date: Thu, 19 Dec 2019 22:52:34 +0100 Subject: [PATCH] details: snapshots: Warn of saved state on creation Add a confirmation dialog when creating a new snapshot if there is saved memory state so the user is aware that memory state will not be part of the snapshot. Reviewed-by: Cole Robinson Signed-off-by: Michael Weiser Suggested-by: Cole Robinson --- virtManager/details/snapshots.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/virtManager/details/snapshots.py b/virtManager/details/snapshots.py index bc5b915a7..c2aecd93a 100644 --- a/virtManager/details/snapshots.py +++ b/virtManager/details/snapshots.py @@ -633,6 +633,17 @@ class vmmSnapshotPage(vmmGObjectUI): self._snapshot_new = vmmSnapshotNew(self.vm) self._snapshot_new.connect("snapshot-created", self._snapshot_created_cb) + if self.vm.has_managed_save(): + result = self.err.ok_cancel( + _("Saved memory state will not be part of the snapshot"), + _("The domain is currently saved. Due to technical " + "limitations that saved memory state will not become part " + "of the snapshot. Running it later will be the same as " + "having forced the system off mid-flight. It is " + "recommended to snapshot either the running or shut down " + "system instead.")) + if not result: + return self._snapshot_new.show(self.topwin) def _on_refresh_clicked(self, ignore):