NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

virt-install: Warn if --osinfo detect=on,name=OSNAME detection fails

Browse Source 
Using `detect=on,name=OSNAME` is good for CI safety, incase
a new distro tree has a regression with detection, or if testing
against a new distro that osinfo-db doesn't know about.

But virt-install should still try to inform the user that detection
failed, and suggest filing a bug if the user expected it to work.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Cole Robinson
2024-10-09 10:44:30 -04:00
committed by Pavel Hrdina
parent e3da4337f6
commit e02607766c
2 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
virtinst/virtinstall.py
View File

@@ -547,15 +547,25 @@ def installer_detect_distro(guest, installer, osdata):
# OS name has to be set firstly whenever --osinfo is passed,
# otherwise it won't be respected when the installer creates the
# Distro Store.
fallback_name = None
if osdata.get_name():
fallback_name = osdata.get_name()
os_set = True
guest.set_os_name(osdata.get_name())
guest.set_os_name(fallback_name)
# This also validates the install location
autodistro = installer.detect_distro(guest)
if osdata.is_detect() and autodistro:
os_set = True
guest.set_os_name(autodistro)
if osdata.is_detect():
if autodistro:
os_set = True
guest.set_os_name(autodistro)
elif fallback_name:
msg = _(
"Failed to detect osinfo OS name from install media."
"Using fallback name=%s.") % fallback_name
msg += _("\nPlease file a bug against virt-install if "
"you expected detection to succeed.")
log.warning(msg)
except ValueError as e:
fail(_("Error validating install location: %s") % str(e))