Masayuki Sunou
efa4e15f2f
Re: [et-mgmt-tools] [PATCH] Fix the maximum number of VCPUin virt-manager
...
Hi Hugh
Thank you for reviewing.
I remake this patch.
> Hmm, this is good, but I'm inclined to think it would be better to put a
> getMaxVcpus() call in connection.py and isolate the "check the
> connection type and either call getMaxVcpus or arbitrarily return '32'"
> there (so we don't repeat the code in two places). Also, it looks to me
> like "Xen" is the default in xen_unified.c, at least in current libvirt
> code, so you shouldn't need to supply "Xen" to the getMaxVcpus call. Can
> you redo the patch along these lines?
>
This patch changes as follows.
1. getMaxVcpus() is executed from connection.py.
2. getMaxVcpus() is called with the result of get_type() not "Xen"
Thanks,
Masayuki Sunou.
===============================================================================
2007-06-18 15:16:20 -04:00
Daniel P. Berrange
bb7fffa441
Fixed connection name with test:///default (Mark Johnson)
2007-06-15 16:57:51 -04:00
Daniel P. Berrange
81007088f7
Automatically try to open a sensible default hypervisor connection
2007-04-12 19:43:31 -04:00
Daniel P. Berrange
f1e8204440
Persist changes to device config when adding devices. Disable hotplug for dom0
2007-04-12 17:50:22 -04:00
Daniel P. Berrange
c10f9f3880
Make shared NIC detection work with Xen netloop crack
2007-04-12 15:34:28 -04:00
Daniel P. Berrange
eb68f9321f
Added code to detect 'shared' physical NICs
2007-04-10 18:27:37 -04:00
Daniel P. Berrange
a389933464
Added signals for network devices& fix creation of virtual networks from UI
2007-04-04 10:56:10 -04:00
Daniel P. Berrange
17a1dac0ce
Hooked up stop/start/delete buttons for networking. Detect & signal start/stop events for network
2007-04-03 14:01:45 -04:00
Daniel P. Berrange
4955a8c6f8
Added API for enumerating network devices
2007-03-30 15:01:41 -04:00
Daniel P. Berrange
7a03e8836d
Added net-added & net-removed signals. Added API for creating a new network
2007-03-29 21:22:31 -04:00
Daniel P. Berrange
25a92026c4
Added dialog for viewing host status & resource config
2007-03-27 19:52:00 -04:00
Daniel P. Berrange
5dbe220ceb
Enable selection of networking options
2007-03-21 12:28:36 -04:00
Hugh O. Brock
c2c259f2a0
Make console popups work right with inactive domains by adding a 'vm-started' signal thrown by vmmConnection. Also fix another threading bug.
2007-03-14 15:51:26 -04:00
Daniel P. Berrange
b5e91c23ef
Refactor connect dialog to support QEMU driver
2007-02-19 22:23:15 -05:00
Daniel P. Berrange
5337c40c65
Deal with errors from hostname lookup (bz 216975)
2006-12-01 16:27:15 -05:00
Daniel P. Berrange
5c0221bd1b
Merge heads
2006-11-13 10:31:29 -05:00
Daniel P. Berrange
b4756294b0
Include info about hypervisor connection in titlebar ( bz 213093)
2006-11-06 10:34:54 -05:00
Daniel P. Berrange
22ac1eda6c
Catch & ignore exception when looking up a domain, in case it went away, or is a zombie
2006-10-25 12:18:06 -04:00
Daniel P. Berrange
2512ba0ebf
Catch & log failure of listDefinedDomains method for older libvirt not supporting inactive domains
2006-10-11 12:05:50 -04:00
Daniel P. Berrange
104796e6ee
Support deleting of VMs
2006-10-10 17:43:44 -04:00
Daniel P. Berrange
f345ddbf5d
Hooked up domain filter in manager list. Ensure we don't recreate vmmDomain object on state changes
2006-10-10 17:24:59 -04:00
Daniel P. Berrange
9b9cadea98
Merged heads
2006-10-10 16:37:17 -04:00
Daniel P. Berrange
f0e88098cf
Added support for starting inactive VMs
2006-10-10 11:30:00 -04:00
Daniel P. Berrange
da7133edcc
Include listing of inactive domains
2006-10-09 13:28:13 -04:00
Daniel P. Berrange
de8425547b
Force immediate refresh of VMs after creating one
2006-10-03 11:53:07 -04:00
Hugh O. Brock
191d17e36a
Add code to register/unregister vm-added signal to stop consoles from spontaneously popping up
2006-08-21 14:00:32 -04:00
Hugh O. Brock
0a1906936f
Added error dialog for domain restore errors
2006-07-24 13:50:11 -04:00
Hugh O. Brock
a5c0597604
Make the progress bar threaded so that it will bounce back and forth in the background (still doesn't work) and abstract the progress bar functionality
2006-07-20 11:16:07 -04:00
berrange@roquette.boston.redhat.com
891424c321
Refactor domain lookup code to avoid as many RPC calls as possible
2006-07-13 13:35:24 -04:00
Daniel P. Berrange
8a1f389a7d
Added copyright tags & cleanup text files
2006-06-28 15:50:17 -04:00
Daniel P. Berrange
85d71812ca
Disable pause/shutdown/etc controls if using a read only connection to Xen
2006-06-28 10:40:35 -04:00
Daniel P. Berrange
4470b01559
Fixed handling of local Xen connects to use 'Xen' rather than None, also fix shutdown tests
2006-06-27 14:16:13 -04:00
Daniel P. Berrange
6529609d4b
Added button to launch console from details window. Cleanup debug output
2006-06-14 18:51:58 -04:00
Daniel P. Berrange
de407853b1
Hooked up instant state changes for pause/resume/shutdown operations, via domain lifecycle events
2006-06-14 18:42:04 -04:00
Daniel P. Berrange
aaad065c35
Moved vmStats() object code into vmmConection() and a new vmmDomain() class, providing an stateful model around libvirt objects
2006-06-14 17:52:49 -04:00
Daniel P. Berrange
c58e86de40
Remove redundant parameter
2006-06-14 16:56:49 -04:00
Daniel P. Berrange
794dcd1e96
Re-factored to avoid tight coupling between various windows/dialogs. Everything is now controlled/manager via vmmEngine
2006-06-14 16:20:06 -04:00
Daniel P. Berrange
29813b4368
Lifecycle management on vmmConnect & vmmManager so app exits when last window is closed
2006-06-14 14:36:26 -04:00
Daniel P. Berrange
7547140130
Make vmmConnection subclass GObject & use its signal infrastructure
2006-06-14 13:52:46 -04:00
Daniel P. Berrange
9617d52a8d
Split gnome-virt-manager.py into separate modules, one per class
2006-06-14 10:59:40 -04:00
Masayuki Sunou
Daniel P. Berrange
Hugh O. Brock
berrange@roquette.boston.redhat.com