Cole Robinson
2d921c6eb7
Prep for release 1.2.1
2015-06-06 18:15:40 -04:00
Cole Robinson
bfa5762d9e
guest: Add install cdrom in set_defaults, not start_install (bz 1220180)
...
Fixes weirdness when using addhardware wizard for a customized VM,
and makes the code easier to follow anyways.
2015-06-06 17:02:20 -04:00
Cole Robinson
cdc0a8fe41
guest: Remove unused code
...
We don't support the transient install disks anymore
2015-06-06 14:59:48 -04:00
Cole Robinson
19e35b0a5b
Fix test output with libvirt 1.2.16
2015-06-06 14:52:16 -04:00
Cole Robinson
8033d33fe3
createinterface: Avoid gtk warning about double setting text renderer
2015-06-06 14:40:19 -04:00
Cole Robinson
853cefbfe8
createinterface: Don't double log about closing dialog
2015-06-06 14:32:04 -04:00
Cole Robinson
07d02a13fd
mediacombo: Ensure has_media returns bool
2015-06-06 14:23:34 -04:00
Cole Robinson
68908c2d81
connection: Handle nodedevs disappearing in filter_nodedevs (bz 1225545)
...
Not exactly sure how we end up with a nodedev in the list that doesn't
have cached XML, but whatever
2015-06-06 14:21:05 -04:00
Giuseppe Scrivano
f5a13510eb
clone: do not use a '/' separator when using a disk file under /
...
It avoids file names like //foo.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1210564
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-06-06 00:00:40 +02:00
Christophe Fergeau
a22f75544e
Fix 'conveninece' typo in API documentation
2015-06-05 16:37:39 -04:00
Pavel Hrdina
0fbe8e7a1f
translation: fix wrong usage of _() function
...
All the strings have to be at first translated and then we can fill the
formated and translated string.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-06-05 16:33:51 -04:00
Cole Robinson
03c24ca5cb
Fix a pylint warning
2015-06-05 16:31:07 -04:00
Cole Robinson
832293f3fd
test_urls: Update latest distro detection
2015-06-05 16:30:53 -04:00
Lin Ma
9b99eff73d
test_urls: Add opensuse 13.x tests
...
Because the content file is changed little bit in 13.2, Both of
urls of 13.1 and 13.2 need to be tested.
From: Charles Arnold <carnold@suse.com>
Signed-off-by: Lin Ma <lma@suse.com>
2015-06-05 16:00:20 -04:00
Lin Ma
5618fa4c5d
urlfetcher: Add support for detecting os variants of suse distros
...
Detect os variants information based on content file
From: Charles Arnold <carnold@suse.com>
Signed-off-by: Lin Ma <lma@suse.com>
2015-06-05 16:00:19 -04:00
Lin Ma
23f262ec7c
urlfetcher: Fetch URL media from content file for suse distros
...
SUSE distro includes a file named content, It includes media information.
This patch adds the ability that fetching url media information through this file.
From: Charles Arnold <carnold@suse.com>
Signed-off-by: Lin Ma <lma@suse.com>
2015-06-05 16:00:19 -04:00
Charles Arnold
9ea3fcd1fc
urlfetcher: Add classes for SUSE distros
...
Signed-off-by: Lin Ma <lma@suse.com>
2015-06-05 16:00:19 -04:00
Chen Hanxiao
7251a2ba6e
createinterface: fix a typo
...
s/selectabel/selectable
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-06-03 23:12:19 -04:00
Cole Robinson
b02cb7ffa0
delete: Improve dialog sizing and scrolling
...
Drop horizontal scrolling, since with gtk3 hidden scrollbars it might
mean users don't realize there's info that is scrolled off.
Adjust the default sizing to match that pattern
2015-05-20 17:50:11 -04:00
Giuseppe Scrivano
f8af2e6b10
create: verify HYPER-V support after customization
...
commit 938060ae53
moved default devices
setup to happen before UEFI is set invalidating what the commit
5acfccf6032abb9e8be89130d05b661e8b3f42c7 does.
Add another check to happen before installing the guest to disable
HYPER-V when not supported.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1185253
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-20 22:48:33 +02:00
Cole Robinson
43340f46a2
create: Fix infinite loop after uiutil rework
...
Repopulating the ostype/variant list triggers a bunch of change events,
which causes us to enter an infinite loop due to some minor behavior
change in the uiutil helpers.
The uiutil helpers are still correct, the root problem is we should be
disabling change events when repopulating those UI lists (we already
have to do a similar trick in a few other places, like host.py)
2015-05-20 14:18:09 -04:00
Lin Ma
bbc4f83bd3
virtinst: enable qemu_ga for sles-11-sp4 and newer
...
Qemu guest agent becomes available since sles 11 sp4 distro,
So enable qemu_ga while installing sles11sp4 and newer sles.
Signed-off-by: Lin Ma <lma@suse.com>
2015-05-20 14:01:50 -04:00
Cole Robinson
2d572e02bd
tests: Fix tests on F22 libvirt
2015-05-20 14:00:15 -04:00
Cole Robinson
8a20a71c46
uiutil: Merge set_combo_entry into set_list_selection
2015-05-19 18:29:46 -04:00
Cole Robinson
23bf115024
uiutil: Rename select_list_row* to match getter functions
2015-05-19 18:29:46 -04:00
Cole Robinson
490aee74de
uiutil: select_list_row_by_value: Handle value=None
...
Which is a legit value we use as a key in several places. Fix up
a potentially problematic caller
2015-05-19 18:29:46 -04:00
Cole Robinson
08116d2869
uiutil: Group similar functions with comment blocks
2015-05-19 18:29:45 -04:00
Cole Robinson
5219e49eec
uiutil: Merge get_combo_entry into get_list_selection
...
There's no reason we can't handle it together
2015-05-19 18:29:45 -04:00
Cole Robinson
fdad3efe24
uiutil: streamline column vs rowidx parameter name
2015-05-19 18:29:45 -04:00
Cole Robinson
e8e2c831bf
addhardware: Don't list device 'default' options
...
This is really only useful for building default XML internally, and
for virt-install stuff like --watchdog default. Instead just select
the 'default' value in the wizard
2015-05-19 18:29:45 -04:00
Cole Robinson
f33b6d2750
addhardware: Modernize the code
...
- Privatize the actually private functions
- Drop the largely redundant get_config helpers
2015-05-19 18:29:45 -04:00
Cole Robinson
b17c00ecca
details: Clean up media eject/insert code
2015-05-19 18:29:45 -04:00
Cole Robinson
776c1d97c6
domain: Fix changing USB device model
...
Broken before v1.2.0
2015-05-19 18:29:45 -04:00
Cole Robinson
2168f33799
details: Unify controller model handling with addhardware
2015-05-19 18:29:45 -04:00
Giuseppe Scrivano
4b5c836a16
interface: read the start mode from the inactive conf XML
...
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1154480
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-15 09:14:09 +02:00
Giuseppe Scrivano
2c1e482b2d
virt-manager: fix --show-host-summary error windows flooding
...
Break an endless loop vmmHost.overview_name_changed ->
vmmHost.conn_state_changed -> vmmHost._overview_name_changed.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1220322
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-11 20:20:10 +02:00
Chen Hanxiao
24302dfdfd
tests: fix test cases failed by 'vmport'
...
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-05-11 04:55:14 -04:00
Giuseppe Scrivano
fbdf574c53
add-hardware: fix shortcut key for USB redir dev type
...
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1172108
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-11 10:17:11 +02:00
Cole Robinson
34a19e497e
man: virt-xml: Fix example
2015-05-10 18:10:21 -04:00
Cole Robinson
88e18c86d3
connection: Fix sending net-removed signal
2015-05-07 12:30:28 -04:00
Cole Robinson
a65c1f62ec
conn: Audit get_$obj callers, drop KeyError handling
...
These functions don't throw KeyErrors anymore, so adjust callers that
were handling it
2015-05-07 12:26:10 -04:00
Giuseppe Scrivano
ac2be79658
storage: do not throw exception if the volume or the pool don't exist
...
commit 5357b91402
changed the semantic of
conn.get_(vm|pool|interface|nodedev|net), to return None instead of
raising KeyError. Leave the exception handling code in case the
semantic is going to be reverted.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1219427
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-07 17:42:58 +02:00
Michał Kępień
c4d26d16a6
pollhelpers: Fix VM polling on old libvirt
...
https://bugzilla.redhat.com/show_bug.cgi?id=1219443
2015-05-07 11:10:20 -04:00
Cole Robinson
2d54949719
virtinst: Drop a bunch of uses of xmlbuilder make_xpath_cb
...
I'd like to drop that functionality from xmlbuilder, and just open
code it at the callers... this is most of the way there
2015-05-06 16:26:51 -04:00
Giuseppe Scrivano
ebcb7c064c
sshtunnels: fix exception when the address is not an IP
...
bug introduced with commit a2d453f3e2
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1218958
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-06 21:27:50 +02:00
Cole Robinson
32d998b216
domain: Properly prime stat lists at object creation
...
Fixes graph spikes when initially connecting to a running VM
2015-05-04 18:42:26 -04:00
Cole Robinson
cb0eaf23d8
conn/domain: Privatize stats list
2015-05-04 18:42:17 -04:00
Cole Robinson
fbf841151d
conn/domain: Condense the internal stats APIs
2015-05-04 18:05:54 -04:00
Cole Robinson
848123e6c8
domain: Fix memory stats for shutoff VM (bz 1215453)
...
memory doesn't have a separate input/output stats, so we shouldn't use
the in_out_vector_helper. This resulted in shutoff VMs appearing to still
use memory in the manager window.
2015-05-04 15:50:01 -04:00
Cole Robinson
feb9c7e9b2
Prep for release 1.2.0
2015-05-04 15:10:48 -04:00