7025 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Cole Robinson	e9308bde1f	man: virt-install: Clarify that --noautoconsole might want --wait ... There's been some confusion about why the VM doesn not reboot after --noautoconsole was passed. Mention the '--wait' fix in the man page https://bugzilla.redhat.com/show_bug.cgi?id=1663430	2019-06-17 00:12:32 -04:00
Cole Robinson	edfb749f91	man: virt-install: Big update ... - Document --install - Document --unattended - Modernize EXAMPLES section - Deprecate --livecd - Tweak the intro describing VM defaults	2019-06-17 00:12:32 -04:00
Cole Robinson	16362671e9	virt-install: Add --install no_install=yes|no ... This just formalizes the behavior of things like --import and --livecd	2019-06-17 00:12:32 -04:00
Cole Robinson	230545bdb3	virt-install: Make bare '--wait' mean 'wait indefinitely'	2019-06-17 00:12:32 -04:00
Cole Robinson	49112dbb70	man: virt-xml: Update with all latest options	2019-06-17 00:12:32 -04:00
Cole Robinson	3062b5ce08	virtManager: Move a lot of misc files to lib/	2019-06-17 00:12:32 -04:00
Cole Robinson	fa3f25dc1c	virtManager: rename connect.py -> createconn.py ... connect.py is too ambiguous, and this naming is more consistent	2019-06-17 00:12:32 -04:00
Cole Robinson	121cf5528d	virtManager: rename create.py -> createvm.py ... To be more consistent with other create wizard naming	2019-06-17 00:12:32 -04:00
Cole Robinson	b15510f3fd	virtManager: rename storagelist to hoststorage ... To match hostnets naming, and to be a bit more clear	2019-06-17 00:12:32 -04:00
Cole Robinson	16a608c37b	virtManager: move vmwindow components to virtManager/details	2019-06-17 00:12:32 -04:00
Cole Robinson	9be836102e	virtManager: move device UI files to virtManager/device/	2019-06-17 00:12:32 -04:00
Cole Robinson	a6c07fbfdc	virtManager: Move object .py files to virtManager/object/	2019-06-17 00:12:32 -04:00
Cole Robinson	e9439a8ef1	virtinst: Move multiple installer .py files to virtinst/install/	2019-06-17 00:12:32 -04:00
Cole Robinson	1d256bccd0	setup: Use smarter py file searching	2019-06-17 00:12:31 -04:00
Cole Robinson	f107e39989	Switch to more traditional logging structure ... Init a shared log instance in virtinst/logger.py, and use that throughout the code base, so we aren't calling directly into 'logging'. This helps protect our logging output from being cluttered with other library output, as happens with some 'requests' usage	2019-06-17 00:12:31 -04:00
Cole Robinson	2c03ea5c92	hostnets: Remove SR-IOV info listing ... This is fairly advanced stuff and it should be fine to get this info from the XML editor page	2019-06-16 23:48:51 -04:00
Cole Robinson	59873f3876	hostnets: Remove QoS viewing/editing ... This is fairly niche, and can be reviewed or edited with the XML editor	2019-06-16 20:25:42 -04:00
Cole Robinson	e25318e037	console: Fix graphics_type_pretty invocation	2019-06-16 20:19:26 -04:00
Cole Robinson	337e84083f	storagepool: Force refresh XML on refresh signal ... The XML will report things like updated capacity information, which we want to mirror in the UI https://bugzilla.redhat.com/show_bug.cgi?id=1447962	2019-06-16 19:43:20 -04:00
Cole Robinson	fe0e36499b	uitests: prefs: Another attempt to fix XML editor flakiness	2019-06-16 19:33:45 -04:00
Cole Robinson	a2a09a49c7	clone: Fix syntax error	2019-06-16 19:23:27 -04:00
Cole Robinson	addff23ccb	guest: Add uefi_requested ... This helps us break that virt-install dependency: parse cli to get arch/machine info, cli requests uefi, uefi needs to know arch machine info. Instead just make the 'uefi' bit set a flag, that we resolve in Guest.set_defaults once we have all the info we need.	2019-06-16 18:32:07 -04:00
Cole Robinson	3586d18971	guest: Warn before setting machine=q35 for secboot	2019-06-16 18:29:33 -04:00
Cole Robinson	b513388979	domain: Remove internal 'cloning' marker ... qemu nowadays should reject the common cases here with its default image locking. Our impl wasn't very good anyways so let's just leave it up to the lower layers	2019-06-16 17:32:41 -04:00
Cole Robinson	9c8e879ff0	virt-install: Add --boot firmware=	2019-06-16 17:15:08 -04:00
Cole Robinson	53f075ab76	virt-xml: Warn if libvirt discards our defined changes ... This can happen if we try to remove a default device, like a ps2 mouse on x86, but it can happen for many other reasons as well https://bugzilla.redhat.com/show_bug.cgi?id=1405263	2019-06-16 17:08:59 -04:00
Cole Robinson	f7854d0a84	virt-xml: Use VIR_DOMAIN_XML_SECURE ... Otherwise we will lose data when editing VMs	2019-06-16 16:48:50 -04:00
Cole Robinson	52c6094c65	virt-xml: Denest and comment code flow a bit ... Add lots of early exits to remove implicit fall through behavior that I find hard to follow	2019-06-16 16:47:05 -04:00
Cole Robinson	0221471e4f	virt-xml: If no XML diff is generated, explicitly warn	2019-06-16 16:37:48 -04:00
Cole Robinson	9ed926a898	spec: Add --with=virtconvert ... We may consider removing virt-convert in the future, and we don't want to ship it on RHEL. So app some spec machinery to exclude it from the RPM	2019-06-16 15:00:39 -04:00
Cole Robinson	4973564e65	virt-clone: add --skip-copy option ... This is the flip side to the --force-copy option. We already have the plumbing internally https://bugzilla.redhat.com/show_bug.cgi?id=1564865	2019-06-16 14:41:54 -04:00
Cole Robinson	44cf01cee1	setup: Fix test_urls coverage testing ... And exclude some error handling	2019-06-16 14:41:54 -04:00
Cole Robinson	88f52f956e	urldetect: Don't use dict ordering for URL detection ... ALLSTORES was implicitly using dict() ordering. This exposed a bug in our code on debian ci which was nice, but it should be deterministic. Hardcode the ordering	2019-06-16 14:41:54 -04:00
Cole Robinson	df82856021	tests: Finish cloner.py coverage	2019-06-16 14:37:56 -04:00
Cole Robinson	03ded3e2bc	urldetect: Fix sles11 ppc64 media detection ... https://bugzilla.redhat.com/show_bug.cgi?id=1379653	2019-06-16 13:50:36 -04:00
Cole Robinson	52f0b1c91e	devices: disk: Handle unset source_protocol ... This can't happen with libvirt processed XML, but could be triggered via virt-install command line. https://bugzilla.redhat.com/show_bug.cgi?id=1482636	2019-06-16 11:01:47 -04:00
Cole Robinson	dcd0b2ac81	cloner: Fill out test coverage	2019-06-15 16:15:01 -04:00
Pavel Hrdina	d6b6397ce0	virtManager: xmleditor: warn when switching to XML tab ... If there are unapplied changes in the UI warn user when they tries to switch to XML editor. Signed-off-by: Pavel Hrdina <phrdina@redhat.com>	2019-06-15 15:05:28 +02:00
Cole Robinson	5eb5913f34	domain: Ensure nvram path before trying to access it ... https://bugzilla.redhat.com/show_bug.cgi?id=1667025	2019-06-14 21:50:08 -04:00
Cole Robinson	524002da02	virt-xml: Abide domain name for --build-xml ... https://bugzilla.redhat.com/show_bug.cgi?id=1648939	2019-06-14 21:37:50 -04:00
Cole Robinson	d61f9d9995	details: Check for mac conflict in customize wizard ... https://bugzilla.redhat.com/show_bug.cgi?id=1660467	2019-06-14 21:11:37 -04:00
Cole Robinson	d40975c493	guest: Add back spice virtio-serial for windows ... This was removed in v2.0.0, but we've had some complains since then https://bugzilla.redhat.com/show_bug.cgi?id=1660123	2019-06-14 20:51:43 -04:00
Cole Robinson	c52e220504	devices: disk: Handle pool=iscsi-direct volumes ... I don't have a working setup for this so I'm not positive it actually works, but this roughly matches what I see in libvirt test suite data and docs https://bugzilla.redhat.com/show_bug.cgi?id=1658511	2019-06-14 20:35:41 -04:00
Cole Robinson	147a3b4790	preferences: Disable systray option if we know it won't work ... Basically on wayland, if appindicator isn't available https://bugzilla.redhat.com/show_bug.cgi?id=1666597	2019-06-14 20:05:09 -04:00
Cole Robinson	aabde5bbe6	domain: Remove pre-startup USB collision check ... Libvirt nowadays will throw an explicit warning about this exact situation. It doesn't guide people to virt-manager UI, but then again it should be obscure enough that it doesn't warrant this special corner case code to inform the user	2019-06-14 20:04:18 -04:00
Cole Robinson	b9981b4623	createpool: Drop disk and netfs pool source listing ... Both of these are awkward to use and IMO not really useful.	2019-06-14 17:16:48 -04:00
Cole Robinson	ab7b3c189f	Move virtcli/cliconfig.py to virtinst/buildconfig.py ... There's really no reason for the split, just contain it all within virtinst for simplicity	2019-06-14 17:12:19 -04:00
Cole Robinson	0e5fb7d7c2	data: appstream: add keywords and translations link	2019-06-14 16:09:29 -04:00
Cole Robinson	ef972cf2ea	virtinst: support: add full code coverage testing	2019-06-14 14:00:13 -04:00
Cole Robinson	54a28485df	tests: Use assertRaises more	2019-06-14 13:04:56 -04:00