Commit Graph

3655 Commits

Author SHA1 Message Date
Cole Robinson
3f532fe263 VirtualDisk: Handle the blktap default
And cache the blktap lookup once for the localhost
2013-10-06 13:17:35 -04:00
Cole Robinson
ef878a5d49 addhw: Fix a few issues with char dev combinations 2013-10-06 13:04:21 -04:00
Cole Robinson
102417ca0c addhw: Make sure to set device defaults 2013-10-06 13:00:30 -04:00
Cole Robinson
5945b8c4a1 connection: Drop redundant XML sanitizing 2013-10-06 13:00:30 -04:00
Cole Robinson
56b9f6187b Streamline support checks
Just use one function check_support
2013-10-06 10:08:04 -04:00
Cole Robinson
d4103eac26 virt-install: Add '--console none' and '--channel none'
For skipping the default channel and default console behavior
2013-10-06 09:43:56 -04:00
Cole Robinson
18fa751059 Add qemu-guest-agent channel automatically for supported OS 2013-10-06 09:19:59 -04:00
Cole Robinson
f44ad5ae05 Default to virtio console for supported OS
This could cause issues for people trying unattended non-graphical
kickstart installs and expecting ttyS0 in the guest to be hooked
up to the default console. So to get back the default behavior, you
can do:

  --console pty
2013-10-06 08:53:05 -04:00
Cole Robinson
dae3678d26 guest: Absorb more default device checks 2013-10-06 08:30:33 -04:00
Cole Robinson
4911cb990e tests: Fix a rogue failure after last commits 2013-10-06 08:23:22 -04:00
Cole Robinson
eede884554 guest: Set more involved clock defaults for qemu
The XML we use is:

  <clock offset="utc">
    <timer name="rtc" tickpolicy="catchup"/>
    <timer name="pit" tickpolicy="delay"/>
    <timer name="hpet" present="no"/>
  </clock>

Which translates to the qemu commands:

    -no-hpet -no-kvm-pit-reinjection -rtc driftfix=slew

The latter two bits are already used by openstack and gnome boxes by
default.

On RHEL hpet is compiled out so -no-hpet is the default,
but not everywhere else. Though recently the RH guys confirmed that
for regular usage it should be turned off because a) qemu support
is not that good, b) most users don't need it anyways c) it has
a performance penalty.

This default can be overridden from a virt-install command like

  --clock rtc_tickpolicy=delay

When Guest() sees that a timer has already been defined, it won't
set the new defaults, and that setting above is the old implied
default rtc setting.
2013-10-05 17:12:11 -04:00
Cole Robinson
d0b067f2fc virt-install: Add --clock option 2013-10-05 16:48:07 -04:00
Cole Robinson
a163f44a27 clock: Add timer parsing 2013-10-05 16:05:31 -04:00
Cole Robinson
fdb79b9832 snapshots: Add a right click menu for start/stop 2013-10-05 14:57:58 -04:00
Cole Robinson
111f4353a3 snapshots: new: Grab name focus, make activate create the snapshot 2013-10-05 14:47:10 -04:00
Cole Robinson
89646fe841 addhw: Filter root hubs out of USB device list 2013-10-05 14:40:38 -04:00
Cole Robinson
c5b5df8db2 storagebrowse: Select default pool on first run 2013-10-05 14:15:11 -04:00
Cole Robinson
ff73f1119e details: If we know the channel target name, pretty list it 2013-10-05 14:04:49 -04:00
Cole Robinson
0366589812 Rip out all support for local RHEL6 version checks
These bits only apply if virt-manager is running directly on a RHEL6.
Since latest virt-manager can't do that thanks to GTK3 conversion,
just drop it all.
2013-10-05 13:57:55 -04:00
Cole Robinson
34f23165b6 addhw: Add channel option for auto socket allocation 2013-10-05 13:54:28 -04:00
Cole Robinson
5f1187e4c3 addhw: Don't show target_type for every char device 2013-10-05 13:33:55 -04:00
Cole Robinson
9d21d2bb02 addhw: List known channel names in a comboboxentry 2013-10-05 13:27:11 -04:00
Cole Robinson
24137cdfe9 addhw: Add 'console' option for adding virtio consoles 2013-10-05 13:22:53 -04:00
Cole Robinson
f9fcac27a0 addhw: Don't advertise unused char types
Like vc, stdio, etc. They don't really have much use
2013-10-05 11:07:32 -04:00
Cole Robinson
a3493c8a50 testdriver: Add some <console> devices 2013-10-05 11:07:05 -04:00
Cole Robinson
8e460dce1d create: Hide arch expander if there aren't any connections 2013-10-05 10:31:02 -04:00
Cole Robinson
ca5e849ec6 create: Reset distro detection labels after each run 2013-10-05 10:29:16 -04:00
Cole Robinson
98187eb4b7 util: Fix generate_name start_num logic
We would start at start_num+1 which was confusing, fix it to do
the right thing.
2013-10-05 10:22:27 -04:00
Cole Robinson
20dfebeda3 clitest: Fix pylint, drop a few overkill tests 2013-10-05 10:22:11 -04:00
Cole Robinson
97f5717ef7 snapshots: Fix showing async dialogs for revert/delete 2013-10-05 10:03:56 -04:00
Cole Robinson
7c3c70d3d0 Remove gconf dep, Require dconf 2013-10-04 16:34:32 -04:00
Cole Robinson
e7e97a8088 domain: If title present, print only it
Forcing the name to be in the picture reduces the usefulness IMO
2013-10-04 11:50:19 -04:00
Cole Robinson
3756235a72 testdriver: Fix snapshot metadata 2013-10-04 08:54:31 -04:00
Fred A. Kemp
c005cc84d6 virt-manager: Future-proof disk 'removable' check box
Currently only QEMU is supported so we only show the check box when
it's used. The future-proofing is that we'll show it for an explicitly
set non-default value, even for hypervisors we don't think support it.
2013-10-04 08:17:25 -04:00
Fred A. Kemp
c45e1ef6b8 virt-manager: Add checkbox controlling disk 'removable' flag
(crobinso: Fix to use grid rework)
2013-10-04 08:08:44 -04:00
Cole Robinson
6de06778d3 details: Convert disk UI from table to grid 2013-10-04 08:01:18 -04:00
Fred A. Kemp
05254479db virt-install: Add --disk removable option 2013-10-04 07:57:13 -04:00
Fred A. Kemp
bcd47d6471 virtinst: Expose disk/target/@removable 2013-10-04 07:57:13 -04:00
Cole Robinson
d83b2c02fa virt-manager: Add USB3 convenience option to the controller UI
and a --controller usb3 option to virt-install
2013-10-03 16:34:28 -04:00
Cole Robinson
db6ef91b0b console: spice: don't set port=None
Can happen if defaultMode=secure, only a tlsport is allocated
2013-10-03 15:54:15 -04:00
Cole Robinson
5efd7c6d96 Add copyright to appdata file
http://blogs.gnome.org/hughsie/2013/10/01/copyright-in-appdata-files/
2013-10-03 14:18:23 -04:00
Giuseppe Scrivano
8e85840546 virt-install: allow to specify "startupPolicy" for --disk
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-03 16:51:23 +02:00
Giuseppe Scrivano
f5a7476497 virtinst: expose disk/source startupPolicy attribute
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-03 16:49:49 +02:00
Giuseppe Scrivano
b2e962fcf3 virtinst: Use the default keymap when running tests
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-03 16:49:45 +02:00
Cole Robinson
0bd2f97bda VirtualDisk: Try to append targets, not just use first free (bz #905439)
This used to happen:

- create VM with cdrom, cdrom gets hdc
- customize before install
- add new cdrom, gets target hda or hdb (first free target)
- new cdrom now has priority in the boot order

Change the logic to try to append targets first, and if there isn't
any space left, use the first free one. This may cause other issues
but we'll just have to wait and see.
2013-10-03 08:48:15 -04:00
Cole Robinson
5860b132dc tests: Add focused unit test for device numbering 2013-10-03 08:48:11 -04:00
Cole Robinson
0614e490c8 VirtualDisk: Don't try to force cdrom target=hdc
It was required a long long time ago, before qemu supported -drive
and possibly ancient xen. Nowadays it should be pointless, and contributes
to some issues like bz 905439
2013-10-02 20:31:57 -04:00
Cole Robinson
e6cebd04ca virt-install: Fix launching console (after graphics rework) 2013-10-02 20:20:52 -04:00
Cole Robinson
475ec1252e virt-install: Allow --disk target
Shouldn't be needed often, but just in case
2013-10-02 20:15:49 -04:00
Cole Robinson
27298c8a80 addhw: Fix disk naming from 'customize' dialog (bz 744137) 2013-10-02 19:58:21 -04:00