Commit Graph

92 Commits

Author SHA1 Message Date
Cole Robinson
64b2d0c6b7 Move shared graphics editing UI to gfxdetails.py
Fixes a couple UI bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=696217
https://bugzilla.redhat.com/show_bug.cgi?id=875403
2014-01-29 09:22:28 -05:00
Cole Robinson
00d5312bd6 Break out shared storage creation UI to addstorage.py 2014-01-29 09:22:28 -05:00
Cole Robinson
169ae1203d Break out shared network list UI to netlist.py
Use this to show vport stuff in addhw, give a warning about macvtap
networking, and allow macvtap from the create wizard.
2014-01-28 10:00:06 -05:00
Martin Kletzander
53a57fcdd8 Don't use SCSI or USB disks with stable_defaults
One more fix I forgot to ammend into commit dc0b9bb.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-01-28 11:27:39 +01:00
Cole Robinson
dc4e1da434 addhw: macvtap: select bridge mode by default 2014-01-27 15:05:50 -05:00
Cole Robinson
9d922f56df fsdetails: Fix error reporting
The UI file layout meant we were trying to use a gtk.Grid object
as the error dialog parent. Rework things to behave like snapshots.py
2014-01-27 11:03:59 -05:00
Cole Robinson
889ec18031 uiutil: Use list selection helpers everywhere 2014-01-27 10:46:14 -05:00
Cole Robinson
2771511946 uiutil: Make more use of set_combo_text_column 2014-01-26 21:35:42 -05:00
Cole Robinson
708a2737cf Split uihelpers into sharedui and uiutil
Reserve uiutil for the little gtk helper functions, rest goes into shared
UI (which all should probably be factored into their own files but thats
a task for another day)
2014-01-26 18:15:50 -05:00
Cole Robinson
20088ab8fb Move many shared UI functions to addhw static functions
Much of uihelpers is just simple stuff that's shared between addhw
and details UI, so just make it staticmethods in addhw, which details
already has a reference to.
2014-01-26 17:09:07 -05:00
Martin Kletzander
dc0b9bbaaf Rename hide_unsupported_rhel_options to stable_defaults and clean-up its usage
There were multiple problems with the setting and usage of
hide_unsupported_rhel_options.  Due to the fact that the option has
several diferent namings throughout the code, this patch is renaming
it to stable_defaults, which basically says what the option does and
makes it possible to use it without need for more than one negation
(where the old code had up to 4 of them in some places), which also
helps understanding it.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-01-21 17:13:18 +01:00
Cédric Bosdonnat
40422e13f2 Create a separate class vmmFSDetails to share filesystem addhardware UI
This class will be reused in the virtManager/details.py code soon to
provide the same UI to modify filesystem devices than to create them.
2014-01-21 09:29:13 -05:00
Cédric Bosdonnat
d888ff2394 Add lxc filesystem drivers: loop and nbd
These file systems drivers have been added in virtinst, but also in the
addhardware UI.
2014-01-21 09:29:13 -05:00
Cédric Bosdonnat
2f505822a1 Add Hardware: added the missing filesystem types for LXC guests.
This means tweaking the UI to input a memory usage for the 'ram'
filesystem type.
2014-01-21 09:29:12 -05:00
Chen Hanxiao
dc439b2c1c addhw: set virtio-scsi controller index via max index in scsi controller list
We set virtio-scsi controller index according to
the number of scsi controller in VM.
This patch will set virtio-scsi controller index
via max index in scsi controller list.

How to reproduce:
a)
If we got an VM with two scsi controller:
<controller type='scsi' index='0'>
<controller type='scsi' index='2'>

#reason for index='2':
someone delete a scsi controller with index=1
by virsh

b)
add a virtio-scsi disk by virt-manager

c)
error threw by virt-manager:
libvirtError: XML error: Multiple 'scsi' controllers with index '2'

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-21 09:00:39 -05:00
Chen Hanxiao
6d5acfab52 disable virtio disk with device type 'LUN'
We should not encourage user use device type 'LUN'
if they selected virtio bus.
This patch will prevent user from doing this.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-21 08:49:18 -05:00
Cole Robinson
66096a7eeb choosecd: Check path-in-use collision (bz 1028197) 2014-01-14 17:11:51 -05:00
Cole Robinson
6dd41e6944 create: Disable 'fully allocate' if qcow2 is the default
Since it doesn't support full allocation
2014-01-14 16:03:58 -05:00
Cole Robinson
2dffdff328 addhw: disk: Split bus and device into two combo boxes
Prior to this we had them in the same combo box, which had grown quite
large.
2014-01-12 16:52:26 -05:00
Cole Robinson
bd111d411c addhw: Only allow panic device if libvirt supports it 2014-01-12 15:16:06 -05:00
Cole Robinson
cad64c0dc1 nodedev: Remove subdev for pretty_name, it's pointless 2014-01-12 14:52:15 -05:00
Cole Robinson
02d07996b0 addhw: Fix a pep8 error 2014-01-11 16:08:42 -05:00
Chen Hanxiao
c7a374b51d virt-manager: add support for adding panic notifier device
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-11 14:53:20 -05:00
Chen Hanxiao
7b9a040249 show read-only check button when add fs for lxc container
Show read-only check button when add fs for lxc container.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2013-11-26 10:08:56 -05:00
Giuseppe Scrivano
a7519dc1e9 virt-manager: fix adding EGD RNG devices in UDP mode
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1001773

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:41:14 +01:00
Cole Robinson
3f532fe263 VirtualDisk: Handle the blktap default
And cache the blktap lookup once for the localhost
2013-10-06 13:17:35 -04:00
Cole Robinson
ef878a5d49 addhw: Fix a few issues with char dev combinations 2013-10-06 13:04:21 -04:00
Cole Robinson
102417ca0c addhw: Make sure to set device defaults 2013-10-06 13:00:30 -04:00
Cole Robinson
56b9f6187b Streamline support checks
Just use one function check_support
2013-10-06 10:08:04 -04:00
Cole Robinson
34f23165b6 addhw: Add channel option for auto socket allocation 2013-10-05 13:54:28 -04:00
Cole Robinson
5f1187e4c3 addhw: Don't show target_type for every char device 2013-10-05 13:33:55 -04:00
Cole Robinson
9d21d2bb02 addhw: List known channel names in a comboboxentry 2013-10-05 13:27:11 -04:00
Cole Robinson
24137cdfe9 addhw: Add 'console' option for adding virtio consoles 2013-10-05 13:22:53 -04:00
Cole Robinson
27298c8a80 addhw: Fix disk naming from 'customize' dialog (bz 744137) 2013-10-02 19:58:21 -04:00
Cole Robinson
a2cbb9f500 support: s/CONN_HV/CONN/g
We don't need to distinguish these days.
2013-10-02 16:41:23 -04:00
Cole Robinson
9194feb1f5 virt-manager: Default to qcow2 on kvm
qcow2 enables fancy features like snapshots and is generally more
desktopy, which we purport to be.

We only do this on not horribly old libvirt/qemu, and only on qemu
connections. This may work for xen but I'm not going to turn it on
until someone tests it.
2013-10-02 15:34:34 -04:00
Cole Robinson
fd00ad74e2 devicehostdev: Drop device creation helper
Goes against other device paradigms, and is cleaner when we unwind it.
2013-09-27 18:28:28 -04:00
Cole Robinson
976093287c addhw: Use a blue banner similar to other wizards 2013-09-27 11:18:52 -04:00
Giuseppe Scrivano
19c3e4cb98 virtManager: fix typo in error message
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-27 00:39:35 +02:00
Cole Robinson
a2e5206730 deviceinterface: Fix creating direct interfaces (bz 1006324)
And take the opportunity to standarize on setting net.source,
rather than have API users have to do net.bridge/network/source_dev
2013-09-24 10:00:01 -04:00
Giuseppe Scrivano
6f8ad1bf21 virtManager: add GUI elements for adding a RNG device
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1001773

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-23 14:09:34 -04:00
Cole Robinson
6da801f944 Set list selection signals in glade, not code 2013-09-22 16:29:58 -04:00
Cole Robinson
d338bce329 Rename ui files to match source file names 2013-09-22 16:10:16 -04:00
Cole Robinson
1683d56b8d ui: Set non-stock button images in glade, not explicitly in code 2013-09-22 12:33:02 -04:00
Cole Robinson
9ceaa2b427 addhardware: Make finish button icon be 'apply', not 'quit' (bz 1006928) 2013-09-20 20:18:52 -04:00
Cole Robinson
aff0ddb259 Use XMLBuilder for Storage object handling
Simplify the API a bunch while we are at it, add tests, etc.
2013-09-20 10:00:08 -04:00
Cole Robinson
aa9ff9854e Fix some pylint 2013-09-10 21:36:53 -04:00
Cole Robinson
9ca0545533 addhw: Drop intro text, simplify UI alignment 2013-09-09 13:06:37 -04:00
Cole Robinson
32c990dc29 addhw: Simplify chardev UI
The previous UI was a ugly and the doc text wasn't particularly helpful,
just make it work like the other UI.
2013-09-09 12:48:17 -04:00
Cole Robinson
ba6e40e879 addhw: Convert usbredir UI to grid 2013-09-09 11:17:01 -04:00