Hi Hugh
Thank you for reviewing.
I remake this patch.
> Hmm, this is good, but I'm inclined to think it would be better to put a
> getMaxVcpus() call in connection.py and isolate the "check the
> connection type and either call getMaxVcpus or arbitrarily return '32'"
> there (so we don't repeat the code in two places). Also, it looks to me
> like "Xen" is the default in xen_unified.c, at least in current libvirt
> code, so you shouldn't need to supply "Xen" to the getMaxVcpus call. Can
> you redo the patch along these lines?
>
This patch changes as follows.
1. getMaxVcpus() is executed from connection.py.
2. getMaxVcpus() is called with the result of get_type() not "Xen"
Thanks,
Masayuki Sunou.
===============================================================================
----------------------------------------------------------------------
In finish() of "create.py", the port number of VNC become -1.
When "Status monitoring" is short, the port number of VNC is updated
in a short time, but, when "Status monitoring" is long, the port number
of VNC is not updated for a long time.
Because the XML data cached in "domain.py" is updated only in tick().
----------------------------------------------------------------------
And, I forgot retrying in "console.py".
Therefore, I adopted updating the port number of VNC in "cerate.py".
I remake the patch.
This patch only clears XML in get_graphics_console(), and the connection
to the console is not retried in "create.py".
So, by applying this patch, the XML data is cleared by retrying in "console.py"
even when "Status monitoring" is long, and the port number of VNC is updated.
(Because retrying in "console.py" calls get_graphics_console())
Thanks,
Masayuki Sunou.
----------------------------------------------------------------------
Hi
When the disk is added to active VM by virt-manager, VM cannot be
restarted after VM is stopped.
--> Bugzilla Bug 239763
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239763
This patch fixes it.
When the device is attached to active VM, virt-manager adds the device
twice in add_device() of "domain.py".
1. Call attachDevice()
2. Call define_domain() after the XML is updated
Therefore, the same device is doubly attached.
(So, when the device is disk, VM cannot be started)
This patch fixes "domain.py" as follows so that the same device is not
doubly attached.
VM is active : Call attachDevice() only
VM is inactive : Call define_domain() after the XML is updated
Signed-off-by: Masayuki Sunou <fj1826dm@aa.jp.fujitsu.com>
Thanks,
Masayuki Sunou.
----------------------------------------------------------------------
