Commit Graph

1460 Commits

Author SHA1 Message Date
Cole Robinson
1df681fe17 prefs: Attempt to clarify 'keyboard grab' option 2010-04-21 12:59:48 -04:00
Cole Robinson
aa063f3408 console: Small readability cleanup 2010-04-21 12:59:25 -04:00
Cole Robinson
b15e601325 console: Listen for Prefs->Keygrab changes 2010-04-21 12:39:40 -04:00
Cole Robinson
db4879b42e host: storage: Add pool refresh button 2010-04-21 10:56:06 -04:00
Cole Robinson
13d61f97c9 Only close connection on error from 'remote' error domain. 2010-04-21 10:08:04 -04:00
Richard Laager
272a6e24ce Uppercase ESX and GSX (from the esx driver) 2010-04-18 00:13:33 -05:00
Cole Robinson
e4f9182034 console: Actually fix SSH with zsh 2010-04-12 17:51:45 -04:00
Cole Robinson
819aa357a0 console: Don't through traceback if we can't read error fd.
This is racy and best effort, so don't log errors if we fail.
2010-04-12 17:46:45 -04:00
Cole Robinson
2f59e36333 console: Fix VNC over ssh when using zsh on remote machine 2010-04-12 17:45:54 -04:00
Cole Robinson
d080e6dfc3 Don't throw odd traceback on app close from thread cleanup issues. 2010-04-12 17:43:55 -04:00
Cole Robinson
e6c40deb2b Log command line at app startup 2010-04-12 15:54:36 -04:00
Cole Robinson
0813d11837 Don't list memory percentages over 100
This upsets widgets. Any attempt at expressing memory overcommit will need
a bit more thought anyways.
2010-04-07 16:36:59 -04:00
Cole Robinson
245edc7c56 Update IPy, cleanup some code in createnet 2010-04-07 15:18:34 -04:00
Cole Robinson
d946c71185 Fix some UI typos. 2010-04-05 12:21:03 -04:00
Cole Robinson
c866044e37 Tweak sparse allocation tooltip: may not always take longer. 2010-04-05 12:17:25 -04:00
Cole Robinson
e4e4b6ffa4 Remove fedora specific packages from packagekit list 2010-03-24 11:22:07 -04:00
Cole Robinson
82b2de12c0 systray: Sort connection rows 2010-03-24 10:58:17 -04:00
Cole Robinson
e1c92b3f6b Fix 'Open Connection' dialog 2010-03-24 10:57:42 -04:00
Cole Robinson
5254e2961e Log a message when we connect to an already running instance 2010-03-24 10:54:38 -04:00
Cole Robinson
b93d1b362a watchdog support: Add, remove, edit in place, and enumerate existing devs 2010-03-24 00:22:17 -04:00
Cole Robinson
28bdbd599c domain: Fix device indexing to use a much simpler scheme 2010-03-23 23:22:08 -04:00
Cole Robinson
929571a8ae details: Allow changing network and sound model on the fly 2010-03-23 22:15:53 -04:00
Cole Robinson
3fedb00dcb Use properly sized icons 2010-03-23 14:27:30 -04:00
Cole Robinson
34ff5bdf9d create: Add 'Import' option for an existing disk image 2010-03-22 18:15:18 -04:00
Cole Robinson
836b7c1244 host: Properly set network/storage/interface error pages for inactive conn 2010-03-20 18:42:32 -04:00
Cole Robinson
290c99110a Allow user to manually specify a shared device name
This allows using remote bridge devices where netcf isn't supported.
2010-03-20 18:35:47 -04:00
Cole Robinson
14e1b166f6 Attempt to 'fake' reboot if it isn't supported
We do this by attempting vm.shutdown(), followed by a vm.start() when
the vm actually stops. Any manual 'shutdown' or 'destroy' call will undo
the reboot command, similar to how xen acts (on RHEL5 at least).
2010-03-17 16:41:50 -04:00
Dmitry Drozdov
4b6c8ca578 Mark some strings as translatable 2010-03-15 11:28:22 -04:00
Cole Robinson
f1fa9bc5eb storagepool: Refresh pool at create time 2010-03-08 12:08:59 -05:00
Marc Deslauriers
3a68fb584c details: Don't lie about en-us keymap if none specified 2010-03-04 15:51:12 -05:00
Cole Robinson
a39cad0f8b More pylint. 2010-03-04 15:36:29 -05:00
Cole Robinson
4af71fc07e addhw: Make disk page look more like create wizard storage page 2010-03-04 15:35:34 -05:00
Cole Robinson
4d4f34e596 create: Break out storage helpers for use in addhw 2010-03-04 15:31:33 -05:00
Cole Robinson
d9759e6c9b Fix some pylint. 2010-03-04 15:29:51 -05:00
Cole Robinson
b4f7383d28 addhw: Some UI cleanup and simplification 2010-03-04 15:29:33 -05:00
Cole Robinson
7c92a277b2 Revert 1548: add a comment why we need to release the domain handle. 2010-03-04 08:40:10 -05:00
Cole Robinson
f839ad9748 details: Display errors caught refreshing HW pages 2010-03-03 18:47:59 -05:00
Cole Robinson
ac43f4ebe0 details: Show disk size if available 2010-03-03 18:43:48 -05:00
Cole Robinson
5f6a59f118 create: Offer to reuse an existing disk image
If the disk image has the expected name /var/lib/libvirt/images/VMNAME.img,
and is unused by any guests, ask the user if they want to use it.
2010-03-03 18:16:08 -05:00
Cole Robinson
64765ec3d4 Use new VirtualDisk path_in_use_by helper 2010-03-03 17:48:22 -05:00
Cole Robinson
d24ce72160 PackageKit integration for first start hypervisor detection
Check to make sure the expected local packages are installed for
the default connection (KVM).
2010-03-03 16:58:50 -05:00
Cole Robinson
51dd50d254 Remove pylint 2010-03-03 16:55:00 -05:00
Cole Robinson
fa876ac6ea progress: Allow storing return data with the async class 2010-03-03 11:14:59 -05:00
Cole Robinson
320eb9a3e1 progress: Allow running a thread which calls its own gtk.main() 2010-03-03 10:51:09 -05:00
Cole Robinson
1879eadf44 manager: Improve startup error when no default connection. 2010-03-02 20:35:54 -05:00
Cole Robinson
b2705bc14e engine: Remove redundant function 2010-03-02 12:18:48 -05:00
Cole Robinson
fb6f725d9e virt-manager.py: Reindent some code 2010-03-02 11:56:04 -05:00
Cole Robinson
5db35b24d5 create: Don't cap storage size, just defer to warnings. 2010-02-28 20:56:41 -05:00
Cole Robinson
8344a977c1 uihelpers: Use Yes/No dialog for permission changing 2010-02-28 20:49:16 -05:00
Marc Deslauriers
654eac1495 systray: Support 'appindicator'
More info can be found here:

https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationIndicators
2010-02-28 20:28:51 -05:00
Cole Robinson
c6e9c4befe create: Make sure we restart new VMs the correct number of times
This means booting live cd's after initial creation, doing a post install
boot for most other installs, and booting windows twice for the 2 stage
install.
2010-02-28 19:40:06 -05:00
Cole Robinson
4db7c4e48d domain: Send 'oldstatus' in status-changed signal
We can then use this to hook up internal signal handlers to do needed
things on status update (rather than bog down _update_status).
2010-02-27 10:42:43 -05:00
Cole Robinson
5e22e3bd6f clone: Improve error message if block device can't be cloned. 2010-02-26 20:29:45 -05:00
Cole Robinson
2768270e43 createinterface: Enable specifying IP protocol info
By default, we try to copy the protocol information from a selected
child interface (if applicable), otherwise assume IPv4 DHCP.
2010-02-26 18:49:18 -05:00
Cole Robinson
699db61fcf host: interface: Display IP configuration 2010-02-25 21:13:33 -05:00
Cole Robinson
f777773ed9 host: interface: Allow changing start mode. 2010-02-25 19:42:08 -05:00
Cole Robinson
b377a740ca Factor out a common 'libvirt object' class.
Use simply now for some common XML routines.
2010-02-25 19:35:01 -05:00
Cole Robinson
7f1d543f76 host: Show errors encountered when populating net/pool/iface state 2010-02-25 17:42:00 -05:00
Cole Robinson
2feed6a3f3 host: Add 'error' page for virtual net and storage
Display a proper error if connection doesn't support network or storage
management.
2010-02-25 17:31:27 -05:00
Cole Robinson
63a53c6f55 details: Don't overwrite user input on XML update 2010-02-24 20:46:25 -05:00
Cole Robinson
882bb0dd0a Fix some pylint. 2010-02-24 20:42:00 -05:00
Cole Robinson
6be4684138 details: Multiple boot device support
Allows viewing, adding, removing, and reordering the boot device list.
2010-02-24 20:37:41 -05:00
Cole Robinson
25284b0833 connection: Remove redundant logging 2010-02-24 14:45:35 -05:00
Cole Robinson
19e87ded38 connection: Make SASL auth dialog a bit cleaner 2010-02-24 14:40:22 -05:00
Cole Robinson
ed211ef066 details: Make 'enter' activate VNC password auth
Not sure why this keeps regressing. I blame glade.
2010-02-23 14:48:35 -05:00
Cole Robinson
182eb4bcb6 Drop redundant calls to window.show() 2010-02-23 14:18:12 -05:00
Cole Robinson
1777528e1b createvol: Make sure error boxes run synchronous if we are modal. 2010-02-22 09:04:48 -05:00
Cole Robinson
492b40f015 createvol: Sensitize 'Finish' if default name suggested 2010-02-22 08:49:21 -05:00
Cole Robinson
d21aa79ed3 util: Fix return value of safe idle timeouts 2010-02-18 10:17:42 -05:00
Cole Robinson
b602f8aaa1 create: Make sure audio and video devices use OS recommended defaults 2010-02-17 16:40:33 -05:00
Cole Robinson
729c478401 domain: Fix connecting to VNC on ESX servers
ESX libvirt URIs don't use have a 'transport' section (like the ssh in
qemu+ssh). If virt-manager didn't see a transport, we assumed the
host is localhost, and used 127.0.0.1 when connecting to VNC.

Fix this check to only use 127.0.0.1 if there is no hostname
specified in the libvirt URI.
2010-02-12 16:37:14 -05:00
Cole Robinson
f243ce4f7e domain: Have get_graphical_console provide more info 2010-02-12 16:33:43 -05:00
Cole Robinson
b661b289c9 console: Condense some debugging output 2010-02-12 14:17:30 -05:00
Cole Robinson
716acf1b9b create: Allow using a manually created 'default' pool 2010-02-12 14:17:16 -05:00
Cole Robinson
4c2b4f6c43 details: Pop up 'Add Hardware' option on hw list right click 2010-02-12 14:01:59 -05:00
Cole Robinson
9876b07ff9 create: Fix page 1 spacing 2010-02-12 13:55:30 -05:00
Cole Robinson
67635bda52 Allow selecting CDROM devices with no detected media.
We may have incorrect detection, and we hypervisors should be able to handle
empty CDROM devices, so allow the option, just don't select it by default.
2010-02-12 13:52:33 -05:00
Cole Robinson
5d52bcadc8 create: Expand 'advanced' options on networking issue
This way the user is informed that there is no default network device,
or the default device is inactive.
2010-02-12 13:37:04 -05:00
Cole Robinson
09968ec776 host: Only decrement window counter if host isn't visible 2010-02-12 12:09:39 -05:00
Cole Robinson
4ff0832301 console: Make sure error socket is non blocking 2010-02-12 10:45:07 -05:00
Cole Robinson
bb1102afe6 details: Remove debug print 2010-02-12 10:27:49 -05:00
Cole Robinson
e20a74c85a addhw: Use VirtualDisk to determine block device size. 2010-02-11 16:07:27 -05:00
Cole Robinson
5c8257d693 console: Try to detect debian/fedora nc incompatibilities 2010-02-11 15:54:45 -05:00
Cole Robinson
f3da3efce1 connection: Don't show harmless backtraces on conn disconnect 2010-02-11 15:25:41 -05:00
Cole Robinson
0a73eb3a7a console: Show SSH error output for remote VNC connections. 2010-02-11 10:43:44 -05:00
Cole Robinson
0bd42916a7 domain: Remove unneeded release_handle command
Not really sure if we even still need to manually change the backing
value, but this was apparently a performance optimization once upon a
time.
2010-02-11 14:00:46 -05:00
Cole Robinson
dfb8f8666a Make sure all idle and timeout routines are thread safe.
Unbeknownst to me, these functions are not run thread safe:

http://library.gnome.org/devel/gdk/unstable/gdk-Threads.html

However since they are run from the main loop, the chance of them conflicting
with another running thread is slim, since we have very few threads that
actually update the UI.
2010-02-11 12:32:00 -05:00
Cole Robinson
494a93cccc console: Don't wait for 'nc' to exit, just kill the process.
Certain nc versions don't handle disconnects very well or require specific
incompatible cli options to operate nicely, and a hung 'nc' connection can
lock up virt-manager. Just kill the tunnel process, rather than waitpid it.
2010-02-11 09:32:05 -05:00
Cole Robinson
c02b8538e6 domain: Don't flood logs if polling disk/net stats fails 2010-02-11 09:30:32 -05:00
Cole Robinson
71a21aabf1 host: Fix interface tooltips 2010-02-10 20:27:36 -05:00
Cole Robinson
6debe5347b create: Give more warning if conn capabilities are sub optimal
Warn if HVM is available but disabled, no guest options are available,
and if KVM isn't around.
2010-02-10 20:26:40 -05:00
Cole Robinson
306cca9ea0 connection: Make sure capabilities are refreshed as needed 2010-02-10 17:05:56 -05:00
Cole Robinson
34c1b5b6d9 create: Use virtinst unified device API as requested via comment 2010-02-10 16:42:20 -05:00
Cole Robinson
b87eb57554 graphwidgets: Don't draw over the border with the tick lines 2010-02-10 12:46:12 -05:00
Jan ONDREJ
3f3ff6558a Fix tapering issue for fully filled graph 2010-02-10 12:43:12 -05:00
Cole Robinson
0273c0c501 Allow viewing and setting domain 'description' field. 2010-02-10 12:16:59 -05:00
Cole Robinson
4da1af635a details: Make sure a HW selection is forced at startup 2010-02-10 11:54:12 -05:00
Cole Robinson
a6573e402f host: Confirm before starting/stopping interfaces 2010-02-08 22:34:23 -05:00
Cole Robinson
2c4e843605 Add libvirt interface create wizard. 2010-02-08 17:18:06 -05:00
Cole Robinson
c815740f41 List libvirt interfaces in host details view.
We use a similar look to storage and virtual network management.
2010-02-08 17:13:36 -05:00
Cole Robinson
8322f75220 Abide gtk cmdline options
By parsing opts later, GTK seems to auto parse and abide options like
--sync.
2010-02-08 11:54:21 -05:00
Cole Robinson
2194107152 connection: Make sure HAL initializers are run thread safe. 2010-02-08 11:44:04 -05:00
Cole Robinson
651c0b7a1a create: Add an option to 'customize before install'
This drops the user into a 'details' dialog where they can add, remove, or
tweaks settings before starting the install.
2010-02-07 12:18:28 -05:00
Cole Robinson
e788fdad23 domain: Add vmmDomainVirtinst class.
A domain class backed by a virtinst Guest, this allows for customizing a VM
before installing.
2010-02-07 12:16:13 -05:00
Cole Robinson
d99c04b02a domain: Factor out a vmmDomainBase class
This will be used to implement a virtinst Guest backed domain, to allow
customizing a VM before install.

Also make some small changes to how we add and remove devices.
2010-02-07 12:10:41 -05:00
Cole Robinson
e6ea45aa8e addhw: Have all device creation go through the same code path. 2010-02-06 15:59:52 -05:00
Cole Robinson
74222abfb8 addhw: Use common setup_dev function when building XML 2010-02-06 15:33:32 -05:00
Cole Robinson
d6e44672d6 create: Move default guest device set up out of finish phase. 2010-02-05 17:58:26 -05:00
Cole Robinson
d9c0363cb5 domain: Drop unneeded define_vcpus params 2010-02-05 18:03:41 -05:00
Cole Robinson
a776a35e92 domain: Remove redundant method 2009-12-08 12:40:42 -05:00
Cole Robinson
25a2e1e246 Better error reporting when opening ~/.virt-manager 2010-02-03 09:43:11 -05:00
Cole Robinson
4178b918b2 domain: Refresh inactive XML on demand
It was a useless operation, whenever we fetch inactive XML we always want
the latest and greatest, so don't cache anything.
2010-01-30 12:41:00 -05:00
Cole Robinson
09d86a79d1 config: Store saved paths using set_string 2010-01-30 12:41:31 -05:00
Cole Robinson
a0b23be738 Add a comment explaining an ambiguous message needing translation. 2010-01-27 10:34:10 -05:00
Cole Robinson
09ad32ad7d Make sure a default '_' implementation is always available
If things error out sufficiently earlier, '_' wouldn't have been installed
in the builtin namespace, so we will trigger an when trying to show a
translated error dialog.
2010-01-27 10:23:57 -05:00
Cole Robinson
d74e01155d engine: Make sure a libvirtd restart doesn't lock the app
We were trying to close the connection without thread locking (and closing
can emit a signal which updates the UI).
2010-01-26 12:24:33 -05:00
Cole Robinson
4075899085 create: Fix creation when no network sources are found 2010-01-25 10:04:31 -05:00
Cole Robinson
afecfd9163 Catch errors when connection to dbus 2010-01-25 09:31:33 -05:00
Cole Robinson
2e153edad9 manager: Safely set toolbar "icon-size" prop 2010-01-19 14:11:23 -05:00
Cole Robinson
5168e1d94a virt-manager.py: Remove some trailing whitespace 2010-01-19 14:10:09 -05:00
Cole Robinson
cae9e95f12 util: Break out common function to conditionally set gtk property 2010-01-19 14:09:43 -05:00
Cole Robinson
28ffe05490 error: Fix launching error dialog on pygtk < 2.10 2010-01-14 10:09:52 -05:00
Cole Robinson
9b7bf37c55 console: Try to catch xen race errors when opening VNC 2010-01-11 10:30:40 -05:00
Cole Robinson
bc908b05b5 migrate: Don't shorten URI IP addresses 2010-01-06 13:09:33 -05:00
Cole Robinson
a7b42276f8 console: Fix opening VNC console over tcp URI with manual port 2010-01-06 12:39:10 -05:00
Cole Robinson
038703bde0 network: Future proof pretty_desc 2009-12-15 11:14:22 -05:00
Cole Robinson
352affbe3a Make 'Escape' key close dialogs
We should get this for free by using gtk Dialogs for our various UI pieces,
however the stock dialog is pretty restrictive WRT widget spacing, and
prevents us from make our nice blue header, so we are stuck with gtk.Windows
2009-12-14 16:45:55 -05:00
Cole Robinson
287ad90a90 Additional focus improvements 2009-12-14 16:48:35 -05:00
Cole Robinson
985dd91f26 Improve default widget focus for various wizards 2009-12-14 16:26:46 -05:00
Cole Robinson
3ed0625000 choosecd: Customize dialog based on media type (cdrom, floppy) 2009-12-14 14:52:52 -05:00
Cole Robinson
ed911036f1 s/optical/mediadev/g for many internal routines
Make the move towards generalizing these for not just CDROM media, but also
floppy devices (and others in the future).
2009-12-10 20:04:26 -05:00
Cole Robinson
b9bf03b896 details: Enable media attach/detach for floppy devices
We still use the CD chooser when attaching media (for now).
2009-12-10 19:18:24 -05:00
Cole Robinson
420fc7a673 console: Disable scrollbars when doing 'resize to VM'
The same scrollbar confusion plagues us: if scrollbars are already showing and
we resize the window to the size of the VNC widget, the scrollbars don't go
away. Hide the scrollbars in this case.
2009-12-14 12:37:08 -05:00
Cole Robinson
dd74e9573c createnet: Make sure a failed network start cleans up properly 2009-12-11 13:45:53 -05:00
Cole Robinson
01d78647c5 details: Properly update disk names after device removal 2009-12-13 17:17:56 -05:00
Cole Robinson
93b4d82c77 connection: Catch all exceptions when building looking up libvirt objects
Currently in many places we only catch a libvirt exception. Make sure we
catch all exceptions, because not doing so pretty much leaves 'tick' dead
in the water. This helps avoid issues reported here:

https://bugzilla.redhat.com/show_bug.cgi?id=547045
2009-12-13 16:31:04 -05:00
Cole Robinson
d9c2f0a583 engine: Fix first app startup traceback 2009-12-10 12:28:55 -05:00
Cole Robinson
d99358e60c manager: Change the selection to the row we right click on 2009-12-09 11:28:38 -05:00
Cole Robinson
cd11862dfb Fix some UI typos 2009-12-09 10:58:47 -05:00
Cole Robinson
2ce3fef46b Drop gnomevfs dependency 2009-12-03 15:52:53 -05:00
Cole Robinson
9fc947a314 A few more small UI tweaks
- Actually make console border black
- Don't set overly large progress bar values in asyncjob
- Use larger icon in progress dialog.
2009-12-03 13:36:28 -05:00
Cole Robinson
99c7c25f73 Various libvirt back compat fixes
- Fix a check for domain support flags that was breaking inactive XML updates
- Even if requested XML hasn't changed, redefine. Needed for changes to
  take permenant effect if INACTIVE XML flag not supported
- Fix setting HD as a boot device
- Detect autostart unavailability on older libvirt
- Clean up how we display console devices to give more concise output
2009-12-03 10:37:57 -05:00
Cole Robinson
5e6d5b0b73 connection: Make sure openAuth is supported before we use it
Also fix a broken error call in that this path triggered, and
a small tweak to pretty printing a Xen connection.
2009-12-03 10:22:54 -05:00
Cole Robinson
7f88328fb4 Fix some gtk calls for older version compat (RHEL5 vintage) 2009-12-03 10:21:39 -05:00
Cole Robinson
f6c29ff8ea Log virtinst exception if we fail to import at startup 2009-12-03 10:20:36 -05:00
Cole Robinson
2d8c6e49fe manager: Improve tooltip for 'Open' toolbar button 2009-12-02 10:20:07 -05:00
Cole Robinson
6268a037a4 uihelpers: Make sure we have a reasonable network selection fallback 2009-12-02 10:03:03 -05:00
Cole Robinson
0f91429cfe uihelpers: Don't let empty bridge be the default selection
On rethinking, it seems a bit risky that user could create a bogus bridge
and then have all new guests choose it by default and provide no networking.
Be safe and force the user to opt in.
2009-12-02 09:58:31 -05:00
Cole Robinson
7d54481b97 details: Give a pretty description of network source
Currently we just printed net type and source device, when we could use the
pretty print we already have in uihelpers. Break out the functionality and
use it on the net screen.
2009-12-02 09:54:29 -05:00
Cole Robinson
e23f9c0a99 uihelpers: Don't list virtual network bridges as shared interfaces 2009-12-02 09:18:05 -05:00