Commit Graph

2224 Commits

Author SHA1 Message Date
Cole Robinson
3d8e6a9398 Set parent for all dialogs 2011-04-14 08:47:42 -04:00
Cole Robinson
fd755f99d5 engine: Use signals for incrementing window counter 2011-04-13 10:47:31 -04:00
Cole Robinson
b76804a8a5 console: Properly implement cleanup() 2011-04-13 10:47:03 -04:00
Cole Robinson
a3fd17575c conn: Remove debugging cruft that was disabling domain update! 2011-04-13 10:21:00 -04:00
Cole Robinson
f2781ee62a Properly cleanup all dialogs
On app close, all dialogs are properly cleaned up so there are no
dangling references and python can garbage collect.

While this isn't that important when the app shuts down, it ensures that
lifecycle changes while the app is running (vm start/stop/remove, conn
start/stop/remove) have the infrastructure to properly release resources.
2011-04-13 10:20:47 -04:00
Cole Robinson
ff3606e740 clone: Remove unused right click menus
Left over from an old design. Also move all attribute init above
child dialog init for clarity
2011-04-13 09:20:59 -04:00
Cole Robinson
8618278fe1 config: Return handle for all notifier functions
Assists callers in doing proper cleanup
2011-04-12 14:57:32 -04:00
Cole Robinson
681b508490 engine: Remove unused refresh-console signal 2011-04-12 12:06:44 -04:00
Cole Robinson
0c72663fa7 connection: Fix cleaning up removed iface + nodedevs 2011-04-12 12:05:36 -04:00
Cole Robinson
8845447a98 engine: connection-removed signal should only send URI
Since that's all that's really needed, and sending conn can interfere
with cleanup
2011-04-12 11:50:10 -04:00
Cole Robinson
f8cbb6fc75 systray: Fix connection removal callback 2011-04-12 11:47:51 -04:00
Cole Robinson
efee2bf7b2 uihelpers: Don't store network objs in combo model
Causes issues with trying to reap virConnect values
2011-04-11 19:42:17 -04:00
Cole Robinson
a52ad2eb37 details: Properly cleanup when VM/conn disappears
Make sure we are properly freeing all our state, so python can reap domains
and conn instances
2011-04-11 18:35:21 -04:00
Cole Robinson
87ebc2d46a serialcon: Subclass vmmGObject 2011-04-11 17:48:21 -04:00
Cole Robinson
a83fe73b1e error: Subclass vmmGObject
Gives us lifecycle tracking and useful helpers like refcount
2011-04-11 16:26:41 -04:00
Cole Robinson
3833aa8e3a details: Remove some unwanted debugging 2011-04-11 16:20:46 -04:00
Cole Robinson
b7730a96ab connection: Cleanup libvirt objects when they disappear
Call the new cleanup() function to ensure python actually reaps the objects
2011-04-11 16:19:47 -04:00
Cole Robinson
4d4717d5e8 delete: Drop VM reference on close
Also, simplify the interface for launching
2011-04-11 16:16:31 -04:00
Cole Robinson
1180c9c4e3 asyncjob: Do some cleanup to allow object to be garbage collected
Also ensure we don't carry around references to other objects
2011-04-11 16:16:29 -04:00
Cole Robinson
d74066da21 baseclass: Simplify cleaning up gobject signals
Just add a custom connect/disconnect to keep track of the signals for us.
2011-04-11 16:16:07 -04:00
Cole Robinson
85340ca491 baseclass: Track object lifetime to help debug ref leaks 2011-04-11 12:54:47 -04:00
Cole Robinson
96085b13a8 domain: Fix rename now that we cache name/id 2011-04-11 12:01:28 -04:00
Cole Robinson
586f7b3274 domain: Fix ref count issues preventing proper cleanup
Make sure we unregister all callbacks so that the domain object
is properly reaped by python. Mediadev has somewhat similar issues,
so handle that.
2011-04-11 12:01:28 -04:00
Cole Robinson
f5464b606d domain: Simplify disk/net stats enable/disable 2011-04-11 11:52:02 -04:00
Cole Robinson
743dddf1b9 connection: Refactor _update_vms to be more like other polling 2011-04-11 11:52:02 -04:00
Cole Robinson
86bf304248 domain: Use cached state for is_active
Rather than pull the latest ID. This way, we only find out about domain
state changes after a tick (or when the user manually performs one in
the GUI).
2011-04-10 17:51:36 -04:00
Cole Robinson
75c3d4dc1a util: Add a few duplicated functions 2011-04-10 17:08:23 -04:00
Cole Robinson
39fe2ed1f7 connection: Clean up domain polling
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2011-04-10 00:04:26 -04:00
Cole Robinson
5570851998 connection: Don't fetch domain XML for memory stats
Make sure we are returning mem values from info(), not from XML
2011-04-10 00:04:26 -04:00
Cole Robinson
b5023268a4 domain: maxmem -> stats_maxmem 2011-04-10 00:04:25 -04:00
Cole Robinson
01429d8734 console: Fix a debugging typo 2011-04-09 23:03:32 -04:00
Cole Robinson
3b0557012f Rename current_mem* -> stats_mem* for clarity 2011-04-09 23:03:01 -04:00
Cole Robinson
b7a13af566 domain: Cache ID and name lookups
Also try to minimize use of get_id call
2011-04-09 22:53:10 -04:00
Cole Robinson
27dcb860eb domain: _update_status: Only fetch info if required 2011-04-09 22:39:34 -04:00
Cole Robinson
aa15d2d4a0 Fix some pylint 2011-04-09 21:58:02 -04:00
Cole Robinson
dc054e05a9 connection: Factor out common polling logic
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2011-04-09 21:55:41 -04:00
Cole Robinson
5aa0a1814b error: Properly debug generated details message
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2011-04-09 21:55:41 -04:00
Cole Robinson
239015d248 host: Fix busted use of conn.storage_capable
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2011-04-09 21:55:41 -04:00
Cole Robinson
f6797644e9 mediadev: Stop polling when conn disconnects 2011-04-09 20:15:39 -04:00
Cole Robinson
6ba13a641d Add class wrapper for nodedev objects 2011-04-09 20:15:39 -04:00
Cole Robinson
2d5fc88cda connection: One missed s/get_devices/get_nodedevs/g 2011-04-09 19:31:55 -04:00
Cole Robinson
1537ea9806 uihelpers: Don't refretch pool object in host_space_tick 2011-04-09 19:25:40 -04:00
Cole Robinson
e8a040ae83 create: Fix minor debugging typo 2011-04-09 18:49:37 -04:00
Gerhard Stenzel
89dbf1e7cf virt-manager: enable direct interface selection
The following patch adds support to select direct interfaces
when defining a virtual machine via virt-manager. Also remove
the unused show_manual_bridge.

Signed-off-by: Gerhard Stenzel <gerhard.stenzel@de.ibm.com>
2011-04-09 17:10:26 -04:00
Cole Robinson
86f4bdaf1d connection: get_devices -> get_nodedevs for consistency 2011-04-07 18:16:28 -04:00
Cole Robinson
16e43da0ae connection: Cache 'storage supported' check
Otherwise we were hitting libvirt more than necc.
2011-04-07 18:10:22 -04:00
Cole Robinson
6da0a95b57 create: Fix building guest when no network options are present 2011-04-07 17:11:10 -04:00
Yuri Chornoivan
f10063d6bd schemas: Fix minor typo 2011-04-07 15:04:50 -04:00
Cole Robinson
40cd20930b Have conn window title match menu entries 2011-04-07 13:21:54 -04:00
Cole Robinson
f1c41b0866 error: Use more consistent details reporting
Always try and report summary + "\n\n" + details
2011-04-06 11:52:26 -04:00