NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2026-08-09 12:38:05 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,721 Commits 2 Branches 66 Tags
a33ac920405c5d315e18c8dda65076bde1da92ae
Commit Graph
937 Commits
Author SHA1 Message Date
Cole Robinson a33ac92040 cli: Fix --boot smbios_mode=sysinfo (bz 1570549) 
Not sure how this was expected to work, just make it do the simple
thing and set the value in the XML. Add a test case for it
 2018-04-24 12:32:18 -04:00
Radostin Stoyanov 087bf7debc tests: uriparse: Test for @ symbol in username 
Add test case for URI that contains the @ symbol in username.

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-04-24 12:13:07 -04:00
Cole Robinson 568841835d urldetect: Standardize _detect_version naming 
This is the hook that subclasses use to save a detect os_variant value
 2018-04-24 11:34:53 -04:00
Cole Robinson a9ad2426b0 test_urls: Improve error output 2018-04-24 11:33:12 -04:00
Cole Robinson 105a6d20be tests: urls: Fix custom ini file usage 2018-04-16 11:36:39 -04:00
Daniel P. Berrangé 48e32b429d Fix copyright header to specify GPLv2 or later, not GPLv2 only. 
The copyright headers in every file were chjanged in this previous commit

  commit b6dcee8eb7
  Author: Cole Robinson <crobinso@redhat.com>
  Date:   Tue Mar 20 15:00:02 2018 -0400

    Use consistent and minimal license header for every file

Where before this they said "

  "either version 2 of the License, or (at your option) any later version."

Now they just say

  "GNU GPLv2"

This fixes it to say "GNU GPLv2 or later" again.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
 2018-04-04 16:51:37 -04:00
Cole Robinson 83a1c43490 tests: test_urls: Look for manual.ini in ~/.config/virt-manager 
Rather than deal with ignoring it in the source tree
 2018-04-03 15:29:03 -04:00
Cole Robinson b17c7565e2 tests: clitest: test virt-xml --update on inactive VM 2018-04-03 12:43:14 -04:00
Cole Robinson 07489a900e tests: Remove __main__ handling, not needed 2018-04-03 10:59:00 -04:00
Charles Arnold fd6a815440 virtinst: compare host and domain cpu models 
Lookup the domain capabilities CPU model and compare with
the host capabilities CPU model and if they are not equal
set the guest's CPU model to None.

(crobinso: compare against 'custom' list not 'host-model', move
 to separate function)
 2018-04-03 10:57:49 -04:00
Charles Arnold d15b78ab0d virtinst: read CPU model from domain capabilities 
Add functionality to acquire the CPU model from the
libvirt domain capabilities. This is used to compare
with the host CPU model.

(crobinso: add test coverage, rework domcaps layout a bit)
 2018-04-03 10:57:15 -04:00
Cole Robinson eafdaf8b48 tests: test_urls: Add urldetect kernel arg validation 2018-04-02 17:15:05 -04:00
Cole Robinson 1269b549c4 tests: test_urls: Enable f28 development test 2018-03-29 19:45:33 -04:00
Cole Robinson a712549b2b tests: test_urls: Use https for debian-daily 
It converts to http to https but that takes time, so fix it
 2018-03-29 19:45:33 -04:00
Cole Robinson ad13c57dc5 urlfetch: Formalize the failed hostname check 
This heuristic is only valid for http connections, everything
else will fail way earlier in the process
 2018-03-29 19:45:33 -04:00
Cole Robinson 5055d7bd19 urlfetcher: Clean up RHEL version parsing/handling 
Drop SLDistro entirely because it adds nothing, just make it an
alias of Centos. Drop some old RHEL version logic. Tweak test cases
 2018-03-29 19:45:33 -04:00
Cole Robinson b9e72b8609 urldetect: Move treeinfo media checking into Treeinfo class 
Rather than in the base Distro class. Simplifies things a bit
 2018-03-29 16:23:57 -04:00
Cole Robinson 5aedc0aff7 urldetect: Drop GenericDistro, non-treeinfo redhat bits 
non-treeinfo redhat only applies to pre RHEL5.4 and very old
Fedora. It's not worth it anymore to slow down all URL lookups
and maintain code complexity to handle such long out of date
distros.

GenericDistro doesn't actually apply to any public trees that I
can find, except for some with TreeInfo. So turn it into
GenericTreeinfoDistro. If random URL trees want to work with
virt-install, add a treeinfo file
 2018-03-29 16:23:57 -04:00
Cole Robinson a8522032eb virtinst: Split out urldetect.py from urlfetcher.py 
urldetect.py has all the distro metadata and parsing logic,
urlfetcher.py has the http/ftp/iso/etc. fetching logic
 2018-03-28 18:46:07 -04:00
Cole Robinson 6e2e18ccf8 urlfetcher: Split up SUSE content parsing a bit 
Add comments for what each parsed line actually looks like
 2018-03-28 17:58:11 -04:00
Cole Robinson 35df66c1ed tests: test_urls: Make fedora distro checking a bit smarter 
Rather than constantly require updating distro values for latest
Fedora when osinfo-db catches up, build some smarts into the
test suite
 2018-03-28 14:56:52 -04:00
Cole Robinson 74f2fb73fd tests: test_urls: Rename distroobj->testdata 
Makes it much more clear what it is
 2018-03-28 14:40:41 -04:00
Cole Robinson 46ec093a28 virt-xml: Make it more clear when changes take effect 
shutdown could be interpreted as a soft reboot, which won't
apply the changes
 2018-03-25 19:22:28 -04:00
Cole Robinson b238718347 tests: uitests: Omit /usr for coverage 
like we do for regular test suite coverage
 2018-03-21 16:25:07 -04:00
Cole Robinson eee1caa946 domain: Drop most device list wrappers 
There's lots of hacks stuffed into the domain device lists. Formalize
some of it, move some of the specific stuff to details.py, and drop
a lot of the needless API wrappers
 2018-03-21 16:10:45 -04:00
Cole Robinson 538ea96116 guest: devices: change XML ordering to match libvirt 2018-03-21 11:17:36 -04:00
Cole Robinson 3b88bfb1ee cli: Drop clear_attr property 
It slightly complicates the generic machinery, and the one usage we
can handle directly
 2018-03-21 11:17:36 -04:00
Cole Robinson 7b61c45d3b guest: Move all_devices to guest.devices.X 
The way we enumerate devices doesn't conform with the way all
other XMLBuilder instances expose child objects. Move more towards
that direction.

This requires some virt-xml and cli.py hacks but we will remove those
in future patches
 2018-03-21 11:17:36 -04:00
Cole Robinson fe9ed2340c virtinst: move <domain> XML files to virtinst/domain 
And give the classes consistent naming
 2018-03-21 11:17:36 -04:00
Cole Robinson b6dcee8eb7 Use consistent and minimal license header for every file 2018-03-21 07:29:40 -04:00
Cole Robinson 3909c10441 virtinst: Move all devices to virtinst/devices/ 2018-03-21 07:29:40 -04:00
Cole Robinson 1c911ce567 virtinst: Give device classes consistent DeviceX naming 
Previous state was inconsistenty and needlessly wordy. Fix up
a few other class namings that have redundant Virtual in the name
 2018-03-21 07:29:40 -04:00
Cole Robinson 1994b4cf2d devicedisk: fix _is_dir_searchable 
And add a test case that would have caught this
 2018-03-18 11:51:09 -04:00
Cole Robinson 4d4a07c65b tests: uitests: Add window cleanup tests 
And fix some bugs I found as a result
 2018-03-17 19:42:19 -04:00
Cole Robinson 591dda6d1e uitests: connect: Test double click to open 2018-03-17 18:46:40 -04:00
Cole Robinson edc79a3272 uitests: Add VM 'doubleclick' open testing 2018-03-17 18:46:40 -04:00
Cole Robinson b423d8ffe7 uitests: cli: test --connect with a bad URI 2018-03-17 18:46:40 -04:00
Cole Robinson f5562e77ae tests: uitests: Make an addhw test less flakey 2018-03-15 21:24:48 -04:00
Cole Robinson dabbc8d5bd engine: Remove centralized conn.open handling 
Move connection opening logic to each caller, since needs are
slightly different.
 2018-03-15 21:24:48 -04:00
Cole Robinson 1d17b98852 engine: Move most remaining window tracking to UI classes 
Kind of a big mess but it was difficult to untangle piecemeal.
Basically this drops nearly all the centralized window tracking
in engine.py and moves it to each UI class. If manager.py wants
to open a details window it does it directly, and vmmDetails tracks
the window object list itself. This simplifies things and makes
the code easier to follow.

There's still some weirdness with vmmConnect and connection callbacks,
but future patches will break those apart.
 2018-03-15 21:24:48 -04:00
Cole Robinson b25c38816a pylint: Enable 'fixme' checking 
Using these for long term TODO type items is not effective, however
it's nice to label things as FIXME during a coding session and have
pylint warn you about them before pushing.
 2018-03-15 21:24:48 -04:00
Radostin Stoyanov 1ae5c4ff75 pylint: Resolve logging-not-lazy 
A new Python checker was added to warn about using a + operator inside
call of logging methods when one of the operands is a literal string.

https://pylint.readthedocs.io/en/latest/whatsnew/1.8.html

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-03-03 16:04:12 -05:00
Radostin Stoyanov 474f60fc56 pylint: Silence inconsistent-return-statements 
A new Python checker was added to warn about "inconsistent return
statements" [1]. A function or a method has inconsistent return
statements if it returns both explicit and implicit values.

[1] https://pylint.readthedocs.io/en/latest/whatsnew/1.8.html

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-03-03 16:04:08 -05:00
Cole Robinson 435fdf2a6a tests: Add xmlns remove_child test case 
And tighten up the xmlbuilder xmlns hackery
 2018-02-26 14:56:24 -05:00
Cole Robinson a58f458fb3 tests: storage: destroy/undefine created objects 
Otherwise we pollute the test driver which causes collisions on
libvirt.git
 2018-02-23 11:57:57 -05:00
Cole Robinson 3079426c82 virtinst: Drop doc= for properties 
This data never gets to the user and largely is just duplicating
libvirt docs. It's redundant
 2018-02-22 20:49:07 -05:00
Cole Robinson 472a52b170 virtconv: Drop all the chdir hackery 
This was just lazy stuff to avoid having to assumble abspaths. Plus
it confuses cprofile
 2018-02-22 20:49:07 -05:00
Cole Robinson 8371a681b1 tests: Remove some redundant clitests 
- Consolidate tests if they don't add coverage
- Remove some categories that aren't really required
 2018-02-22 18:26:50 -05:00
Marc-André Lureau 55fa6c4caa tests: add xmlparse/change vmcoreinfo test 
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
 2018-02-22 16:23:40 -05:00
Marc-André Lureau 0a62ae0b7a virtinst: add <vmcoreinfo/> feature 
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
 2018-02-22 16:23:40 -05:00