Giuseppe Scrivano
ebcb7c064c
sshtunnels: fix exception when the address is not an IP
...
bug introduced with commit a2d453f3e2
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1218958
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-06 21:27:50 +02:00
Cole Robinson
32d998b216
domain: Properly prime stat lists at object creation
...
Fixes graph spikes when initially connecting to a running VM
2015-05-04 18:42:26 -04:00
Cole Robinson
cb0eaf23d8
conn/domain: Privatize stats list
2015-05-04 18:42:17 -04:00
Cole Robinson
fbf841151d
conn/domain: Condense the internal stats APIs
2015-05-04 18:05:54 -04:00
Cole Robinson
848123e6c8
domain: Fix memory stats for shutoff VM (bz 1215453)
...
memory doesn't have a separate input/output stats, so we shouldn't use
the in_out_vector_helper. This resulted in shutoff VMs appearing to still
use memory in the manager window.
2015-05-04 15:50:01 -04:00
Cole Robinson
feb9c7e9b2
Prep for release 1.2.0
2015-05-04 15:10:48 -04:00
Cole Robinson
1a5b87b066
details: Remove unused function
2015-05-04 14:18:03 -04:00
Marc-André Lureau
e2184ea2cf
tests: add some vmport tests
...
Message-Id: <1428012248-5767-6-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:14 -04:00
Marc-André Lureau
ddfca74e54
virtinst: set vmport off by default when has_spice()
...
Spice is better off without vmport enabled, to be able to switch between
absolute and relative mouse mode easily.
Message-Id: <1428012248-5767-5-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:13 -04:00
Marc-André Lureau
ede876e792
virtinst: set_graphics_defaults() first
...
Some later options may require Spice (or other) to be enabled,
so call set_graphics_defaults() earlier.
Message-Id: <1428012248-5767-4-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:13 -04:00
Marc-André Lureau
b44cfde6ac
virtinst: add features.vmport option
...
Message-Id: <1428012248-5767-3-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:13 -04:00
Marc-André Lureau
ea4aa9ffc4
virtinst: add new vmport domain feature
...
This should be available with libvirt 1.2.16
Message-Id: <1428012248-5767-2-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:13 -04:00
Cole Robinson
cc67f8f194
addstorage: Clarify that VM will fail if cant set path search perms
...
https://bugzilla.redhat.com/show_bug.cgi?id=1181025
2015-05-03 17:33:26 -04:00
Cole Robinson
cca34185c0
create: customize: Hide bus=virtio-scsi
...
We don't handle it correctly, need to duplicate the addhw logic
2015-05-03 17:24:02 -04:00
Cole Robinson
4547031152
addhardware: Generate disk targets for disks via customize dialog
...
Since the XML we use now is with the defaults filled in. Fixes some
issues in the log here:
https://bugzilla.redhat.com/show_bug.cgi?id=1213475
2015-05-03 17:17:53 -04:00
Cole Robinson
a8d3afbcd9
domain: Log initial XML for virtinst/customize object
2015-05-03 17:01:16 -04:00
Cole Robinson
53703117d9
storagebrowser: Don't log about closing, if already closed.
2015-05-03 16:57:31 -04:00
Cole Robinson
68ce97d533
create: customize: cancel now cancels the entire installation
...
Trying to fall back to the create wizard can give weird results, since
it's really hard to ensure the customized changes are preserved if
the user changes things in the 'new' wizard.
2015-05-03 16:53:43 -04:00
Cole Robinson
c8a0b8310c
create: Fix a logging typo
2015-05-03 16:37:42 -04:00
Cole Robinson
252c216fb9
createpool: Don't unconditionally use /var/lib/libvirt
...
Doesn't make sense for session URIs
2015-05-02 19:54:14 -04:00
Cole Robinson
45e6cd4cac
Remove redundant 'default dir' functions
2015-05-02 19:48:04 -04:00
Cole Robinson
7e7c606ff7
pylint: Disable unidiomatic-typecheck, not really worth fixing
2015-05-02 19:48:04 -04:00
Cole Robinson
892e13d2c0
connection: Tweak pretty names a bit
2015-05-02 19:20:18 -04:00
Cole Robinson
015da05973
storage: Use .local/libvirt/images for session URIs
...
.config isn't really appropriate
2015-05-02 19:09:14 -04:00
Cole Robinson
95cda55376
spec: Don't use hardcode lookup of qemu-system-x86
...
libvirt-daemon-kvm pulls in the correct emulator dep per architecture
2015-05-02 18:25:41 -04:00
Cole Robinson
cc3c6e24a3
packageutils: Add some extra logging
2015-05-02 18:01:52 -04:00
Cole Robinson
fa08d0ada5
clitest: Fix tests on F21
2015-05-02 16:41:21 -04:00
Cole Robinson
46ecafd820
migrate: Fix typos pointed out by translator
2015-05-01 09:38:25 -04:00
Ján Tomko
be7611b645
connection: refresh domain XML on device hotplug
...
Listen to the VIR_DOMAIN_EVENT_ID_DEVICE_ADDED event
too, added by libvirt 1.2.15.
https://bugzilla.redhat.com/show_bug.cgi?id=1179138
Signed-off-by: Ján Tomko <jtomko@redhat.com>
2015-04-29 09:52:10 -04:00
Cole Robinson
0aeee5c449
serialcon: Fix opening with xen (bz 1215357)
...
Apparently xen doesn't set <serial> device alias names, and OpenConsole
just opens the first <console> device unconditionally.
Properly handling that would be to report it in the UI that we can
only open the first console, but for now just drop the alias check.
Apparently SUSE already does this as mentioned in the RH bug
https://bugzilla.redhat.com/show_bug.cgi?id=1215357
2015-04-26 11:54:55 -04:00
Cole Robinson
8369c65966
storage: Use ~/.config/libvirt/images for qemu:///session
...
It doesn't create the annoying ~/VirtualMachines directory, and already
has proper labelling.
2015-04-24 21:01:55 -04:00
Cole Robinson
05db555145
libvirtobject: Don't raise error during init_libvirt_state
...
The connection doesn't handle it. If it ever needs to know we can have
it return a value or something.
2015-04-24 15:34:55 -04:00
Giuseppe Scrivano
a2d453f3e2
sshtunnels: use ipaddr to check if address is loopback or unspecified
...
It supports IPv6 addresses written as "0::0", "0:0::0".
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-04-24 11:39:04 +02:00
Cole Robinson
33cfe883c6
guest: arm kvm should use host-passthrough, not model=host
...
Seems to work with libvirt, not sure if it was ever broken as the comment
suggested.
2015-04-23 10:14:58 -04:00
Cole Robinson
bbb048cbd0
clitest: Add KVM tests for aarch64, armv7, ppc64le
2015-04-22 20:28:47 -04:00
Cole Robinson
6fd3983f6d
tests: Clean up capabilities test data
...
Make it clear which ones are used for the caps unit tests, and which
are for cli/UI testing and can be updated at will. And drop a bunch
of outdated stuff.
2015-04-22 19:05:06 -04:00
Cole Robinson
8a3e3391c8
clitest: Drop explicit fake.iso filename
...
Just use one of the other files we stub out
2015-04-22 18:00:00 -04:00
Cole Robinson
d4bf3b58a0
clitest: Drop prompttest infrastructure
...
Just fake it for the one remaining test
2015-04-22 18:00:00 -04:00
Cole Robinson
070664b9e7
tests: Enable property checking for all objects
...
And loosen restrictions a bit so any read/write will trigger the
tracking.
2015-04-22 16:26:03 -04:00
Giuseppe Scrivano
1c22118179
aarch64: support virt-rhelsa7.1 machine type
...
Just check for the prefix of the machine type, as it is done for ARM
vexpress.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1212021
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-04-22 19:08:02 +02:00
Cole Robinson
4c361933ea
tests: Have the property checker work on whole test suite
...
Not just xmlparse.py. So we can test a new property via clitest and
not always via xmlparse
2015-04-21 20:15:37 -04:00
Cole Robinson
ccc0da3e51
tests: Add specific VM for virtxml tests
...
Decouple it from test-many-devices which is really about manual testing
of virt-manager UI. It's annoying that every time test-many-devices is
extended we need to regenerate all the virtxml tests.
2015-04-21 19:50:41 -04:00
Cole Robinson
18a6d8b444
migrate: Add 'temporary' option
...
This doesn't undefine the VM source, and leaves it temporary on the
destination. Basically the default migration action
2015-04-21 17:39:44 -04:00
Cole Robinson
fb26349546
domain: Make the tick() logic easier to follow
2015-04-21 17:15:58 -04:00
Cole Robinson
62ad0e91ee
migrate: Big reworking of the dialog
...
It's largely the same, but now
- The code is better organized
- The UI is much more streamlined, only showing relevant fields when
required.
- We warn about the hostname/URI cases that we know libvirt will error on
- Drop some of the attempts at being smart, and just mimic what libvirt
will do.
2015-04-21 17:15:58 -04:00
Cole Robinson
bfcfdbf785
host: Remove some redundant connection fields
2015-04-21 16:33:41 -04:00
Cole Robinson
996c8b76b8
clone: Use conn desc if showing destination conn
2015-04-21 16:33:41 -04:00
Cole Robinson
692604e0a3
domain: migrate: Use UNDEFINE_SOURCE
...
Leaving a VM defined on the source is dangerous: if they are sharing
storage, and aren't using virtlockd, then they might be inadvertently
started in two places at once and trash a disk image.
Some people might still need the option to turn this off, so maybe we
will revive it. Not sure though
2015-04-21 16:33:41 -04:00
Cole Robinson
26c729887d
domain: migrate: use PERSIST_DEST flag
...
Don't do it manually, it's been supported by libvirt for 5 years
2015-04-21 16:33:41 -04:00
Cole Robinson
be86785fdd
migrate: Drop unused 'live' parameter. We always pass LIVE
2015-04-21 16:33:41 -04:00