NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2026-08-04 02:13:21 -05:00
Code Issues Packages Projects Releases Wiki Activity
7,475 Commits 2 Branches 66 Tags
d073ee9a4821046de7df977571995300be827310
Commit Graph
98 Commits
Author SHA1 Message Date
Cole Robinson 9a9eb165ed uitests: Add host*.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 3062b5ce08 virtManager: Move a lot of misc files to lib/ 2019-06-17 00:12:32 -04:00
Cole Robinson b15510f3fd virtManager: rename storagelist to hoststorage 
To match hostnets naming, and to be a bit more clear
 2019-06-17 00:12:32 -04:00
Cole Robinson f107e39989 Switch to more traditional logging structure 
Init a shared log instance in virtinst/logger.py, and use that
throughout the code base, so we aren't calling directly into
'logging'. This helps protect our logging output from being
cluttered with other library output, as happens with some
'requests' usage
 2019-06-17 00:12:31 -04:00
Cole Robinson 6f5cd58ead util: Move pretty_* into virtManager code 2019-06-07 17:21:25 -04:00
Cole Robinson c3ea2d3119 host: Don't try to confirm changes on window close 
It's a bit of a pain to get right, so only do it on net/pool list
change
 2019-04-14 18:24:04 -04:00
Cole Robinson 86a13699ce host: separate out hostnets.ui and hostnets.py 
Helps organize things by limiting the files to a single class of
operations, and follows the storagelist.py pattern
 2019-04-14 18:23:58 -04:00
Cole Robinson 891968085c host: Modernize code style 
* Privatize non-public functions
* Have clear UI callbacks
* Group functions
* Simplify active_edits
* Remove no longer needed reset_net_state
 2019-04-14 17:05:14 -04:00
Cole Robinson de773179ef host: Remember window dimensions 
Like we do for details and manager windows, save window size in
gsettings and remember it across app runs
 2019-04-14 17:05:14 -04:00
Cole Robinson 3784864e10 baseclass: Add is_visible 
Remove the duplicated implementations everywhere
 2019-04-14 17:05:14 -04:00
Cole Robinson 4096800f71 Remove interface UI 
Discussed here: https://www.redhat.com/archives/virt-tools-list/2018-October/msg00032.html
 2018-10-12 14:38:05 -04:00
Daniel P. Berrangé 48e32b429d Fix copyright header to specify GPLv2 or later, not GPLv2 only. 
The copyright headers in every file were chjanged in this previous commit

  commit b6dcee8eb7
  Author: Cole Robinson <crobinso@redhat.com>
  Date:   Tue Mar 20 15:00:02 2018 -0400

    Use consistent and minimal license header for every file

Where before this they said "

  "either version 2 of the License, or (at your option) any later version."

Now they just say

  "GNU GPLv2"

This fixes it to say "GNU GPLv2 or later" again.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
 2018-04-04 16:51:37 -04:00
Cole Robinson b6dcee8eb7 Use consistent and minimal license header for every file 2018-03-21 07:29:40 -04:00
Cole Robinson 4d4a07c65b tests: uitests: Add window cleanup tests 
And fix some bugs I found as a result
 2018-03-17 19:42:19 -04:00
Cole Robinson 3c1e0a8a12 virtManager/*: Give pylint hints about singleton classes 
It can't seem to figure out that what 'cls' is in this context,
so make it explicit.
 2018-03-17 18:46:39 -04:00
Cole Robinson dac860e8ce engine: Show modal startup errors if window open fails 2018-03-16 19:09:55 -04:00
Cole Robinson cad809fe80 Make all dialogs clean up when vm/conn disappears 
Moves all the window cleanup handling to each class and audit for
all --test-leak-debug errors and fix
 2018-03-15 21:24:48 -04:00
Cole Robinson 1d17b98852 engine: Move most remaining window tracking to UI classes 
Kind of a big mess but it was difficult to untangle piecemeal.
Basically this drops nearly all the centralized window tracking
in engine.py and moves it to each UI class. If manager.py wants
to open a details window it does it directly, and vmmDetails tracks
the window object list itself. This simplifies things and makes
the code easier to follow.

There's still some weirdness with vmmConnect and connection callbacks,
but future patches will break those apart.
 2018-03-15 21:24:48 -04:00
Cole Robinson 92aea7c565 engine: Have windows increment/decrement windows directly 2018-03-15 21:24:48 -04:00
Cole Robinson 9fa9777f1c engine: Have windows call exit_app directly 2018-03-15 21:24:48 -04:00
Cole Robinson eb5cd8b2c9 host: Drop vestiges of old VM restore support 
This hasn't been in the UI for a long time
 2018-03-15 21:24:48 -04:00
Radostin Stoyanov 4d9c6141dd Convert the output of range() to list 
In Python 2 the range() function returns a list [1].
In Python 3 the range function returns a range type [2] which
represents an immutable sequence of numbers [3].

[1] https://docs.python.org/2.7/library/functions.html#range
[2] https://docs.python.org/3/library/functions.html#func-range
[3] https://docs.python.org/3/library/stdtypes.html#typesseq-range
 2018-02-06 18:49:17 -05:00
Radostin Stoyanov 69c84bea47 Import reduce() from functools module 
The built-in function reduce() [1] has been moved in the functools
module [2] [3].

[1] https://docs.python.org/2/library/functions.html#reduce
[2] https://docs.python.org/3/library/functools.html#functools.reduce
[3] https://docs.python.org/2/library/functools.html#functools.reduce
 2017-10-20 13:18:31 -04:00
Lin Ma 083dfcc8ec host: Show details about the network of SR-IOV VF pool 
Signed-off-by: Lin Ma <lma@suse.com>
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2017-10-09 10:22:48 +02:00
Chen Hanxiao c92aade081 pycodestyle: fix all E203 warnings 
Fix all E203 whitespace before ':'
   Also remove E203 ignore option of pycodestyle

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
 2017-08-11 00:01:38 +08:00
Radostin Stoyanov b93cc3bbc9 pycodestyle: Do not use bare 'except:' 
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].

[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
 2017-08-02 13:57:43 -04:00
Cole Robinson 62feeb02a8 Switch to python3 style 'except X as Y' notation 
Which also works with python2.7
 2017-05-05 14:52:11 -04:00
Cole Robinson 2c8ed52813 Fix some pylint 2017-03-27 17:27:14 -04:00
David Thurstenson a86c119e1c Fix ambigous label on Autostart checkbox 
When the Autostart checkbox on the host Virtual Network or Storage tabs
is deselected, the label reads "Never", and when selected the label reads
"On Boot". This changes these labels to always read "On Boot".
 2017-03-22 11:53:00 -04:00
Pavel Hrdina 2d554aca7b ui: remove "Restore Saved Machine..." from File menu of Connection Details 
Commit 839ce682 removed deprecated support of save/restore which was replaced by
managedsave feature.  This is a leftover that wasn't removed together with that
commit.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1340356

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2016-05-31 13:09:48 +02:00
Pavel Hrdina c39592ae7b localization: mark several strings as translatable 
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2016-02-06 16:25:08 +01:00
Cole Robinson 23bf115024 uiutil: Rename select_list_row* to match getter functions 2015-05-19 18:29:46 -04:00
Cole Robinson fdad3efe24 uiutil: streamline column vs rowidx parameter name 2015-05-19 18:29:45 -04:00
Cole Robinson a65c1f62ec conn: Audit get_$obj callers, drop KeyError handling 
These functions don't throw KeyErrors anymore, so adjust callers that
were handling it
 2015-05-07 12:26:10 -04:00
Cole Robinson fbf841151d conn/domain: Condense the internal stats APIs 2015-05-04 18:05:54 -04:00
Cole Robinson bfcfdbf785 host: Remove some redundant connection fields 2015-04-21 16:33:41 -04:00
Cole Robinson 3d2afbaf6f connection: Allow setting a custom 'pretty name' (bz 784701) 
We've had multiple requests over the years for something similar. People
might have to connect to multiple IP addresses, or really large hostnames,
that become difficult to distinguish in the UI.

Add a field in the host details page that allows setting a custom name,
and store it in gsettings.
 2015-04-11 13:39:25 -04:00
Cole Robinson 4781ad6cd6 connection: Simplify manager row 'pretty name' handling 
Unify all the callers, and use some UI ellipsizing to handle
crazy long hostnames.

This drops the conn name collision prevention stuff which can be
useful when you have lots of similar connection names. But upcoming
patches will make it mostly redundant.
 2015-04-11 12:57:32 -04:00
Cole Robinson ee9aa0ef11 host: Don't trigger selection callbacks when conn is closing 
We already do this for storage, make sure we do it for iface + net
as well.
 2015-04-11 11:40:47 -04:00
Cole Robinson 8c107f87f9 host: Remove some redudant conn details 
And some minor UI spacing fixes
 2015-04-11 11:29:03 -04:00
Cole Robinson 6071ab0ea4 uiutil: Clarify a few ambiguous function names 2015-04-10 15:00:34 -04:00
Cole Robinson 49e3ea2cdf host: Make sure first object selected when conn connects 
Previously it was dictated by what order we received conn
signals in.
 2015-04-10 15:00:34 -04:00
Cole Robinson 3df02e8ee1 host: Fix a couple recently introduced issues 2015-04-10 15:00:34 -04:00
Cole Robinson 1e154a373d libvirtobject: Populate status up front 
And use this to kill paranoid object tick() that are sprinkled throughout
the code.
 2015-04-10 15:00:34 -04:00
Cole Robinson a3f8d73a9c libvirtobject: Unify internal status APIs and signals 
Drop config-changes vs. status-changed and just use one signal, since they
are largely the same code paths for all users.
 2015-04-10 15:00:34 -04:00
Cole Robinson 01bf07ba11 libvirtobject: Unify status signals 
Dispatch them all from the actual object and not proxied through
the connection. Use the same signal name for all objects with the same
signature.
 2015-04-10 15:00:33 -04:00
Cole Robinson a45fc36d06 host: If connection disconnects, close add* wizards 2015-04-10 15:00:33 -04:00
Cole Robinson 058c06972e Break out shared storage UI to storagelist.py (bz 1060433) 
We were already sharing a chunk of this in a haphazard way. Now officially
break it all out, similar to netlist.py. This mostly unifies the views
of host->storage and storagebrowser.py
 2015-04-09 12:31:24 -04:00
Cole Robinson 85161e4c57 host: Clean up invocation of *apply from confirm dialog 
Basically, only apply the page we are actually on
 2014-09-20 17:32:10 -04:00
Cole Robinson 0717a21f65 host: Fix renaming network/storage pool 2014-09-20 17:32:09 -04:00