Commit Graph

738 Commits

Author SHA1 Message Date
Cole Robinson
e1b646594c console: Hide display widget from consumers
There were several layering violations, make it explicit by making
display private, and providing APIs for everything the consumers
need.
2014-09-21 13:25:43 -04:00
Cole Robinson
a3bd1b26a9 console: Clarify keyboard grab default handling 2014-09-21 13:06:25 -04:00
Cole Robinson
4568cdb636 module_trace: Only show main thread APIs by default 2014-09-21 12:05:02 -04:00
Cole Robinson
b0d5198b7a virt-manager: Switch 'Copy host' to use host-model (bz 1133155)
Similar to the previous change for virt-install
2014-09-20 20:44:14 -04:00
Cole Robinson
85161e4c57 host: Clean up invocation of *apply from confirm dialog
Basically, only apply the page we are actually on
2014-09-20 17:32:10 -04:00
Cole Robinson
0717a21f65 host: Fix renaming network/storage pool 2014-09-20 17:32:09 -04:00
Cole Robinson
38738d9fa6 connection: Don't close VM dialog on rename
Rework things a bit to simplify everything we pass around.

The specific bug fix is making sure we update the object list in place,
otherwise the event loop detects it as the VM being deleted and closes
the details window.
2014-09-20 17:32:09 -04:00
Cole Robinson
ea97325a72 connection: Tweak some debugging output 2014-09-20 16:33:26 -04:00
Cole Robinson
f2ff378a9d details: Avoid some misleading logging on rename 2014-09-20 16:18:10 -04:00
Cole Robinson
56c091600a details: Move hostdev prettyifier to virtinst 2014-09-20 14:56:57 -04:00
Cole Robinson
92f298e393 addhardware: Use virtmanager APIs for VM listing 2014-09-20 13:04:47 -04:00
Cole Robinson
dd67c48233 connection: Handle nodedev polling too
And cleanup up a bunch of nodedev functions as a result
2014-09-20 12:04:49 -04:00
Cole Robinson
439e5ad0fe details: Reorg a bunch of the global helpers
Some were redundant, some should be in virtinst
2014-09-20 10:23:19 -04:00
Cole Robinson
fa76e92f2c virt-manager: Fix issues with ellipsizing on recent gtk 2014-09-19 22:08:22 -04:00
Cole Robinson
edf9bf0aad serialcon: Drop use of yet more removed API 2014-09-19 20:35:06 -04:00
Cole Robinson
3feedb76e9 domain: Match UNDEFINE_NVRAM conditions with libvirt
Suggested-By: Laszlo Ersek <lersek@redhat.com>
2014-09-19 20:08:59 -04:00
Cole Robinson
ebeea7af9f delete: Remove nvram support
As of now, the only uses of nvram likely in the domain XML are with
libvirt configurations that also support the UNDEFINE_NVRAM flag, so
listing it here is kind of redundant. And in the common config of
non-root user connected to qemu:///system with template based nvram
in /var/lib, we won't be able to remove it anyways.
2014-09-19 20:04:39 -04:00
Cole Robinson
ae26313ed4 details: Add UI for enabling UEFI via 'customize before install'
We expose a simple combobox with two entries: BIOS, and UEFI. The
UEFI option is only selectable if 1) libvirt supports the necessary
domcapabilities bits, 2) it detects that qemu supports the necessary
command line options, and 3) libvirt detects a UEFI binary on the
host that maps to a known template via qemu.conf

If those conditions aren't met, we disable the UEFI option, and show
a small warning icon with an explanatory tooltip.

The option can only be changed via New VM->Customize Before Install.
For existing x86 VMs, it's a readonly label.
2014-09-17 18:43:41 -04:00
Cole Robinson
ead9d3f56d domain: If VM has nvram, ask libvirt to remove it on undefine 2014-09-17 18:35:20 -04:00
Lin Ma
e088486b23 addhardware: Deal with the conflict host device
If a host device is in use by guests, Warn user and
let user make choice while adding hardware.

Signed-off-by: Lin Ma <lma@suse.com>
2014-09-16 11:41:13 -04:00
Lin Ma
2f62ba964c Add comparison function for NodeDevice
PCIDevice and USBDevice include respective comparison logic.

Signed-off-by: Lin Ma <lma@suse.com>
2014-09-16 11:41:13 -04:00
Giuseppe Scrivano
e5d2059853 virt-manager: delete nvram file on VM deletion
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:49:00 +02:00
Giuseppe Scrivano
f2ad085918 virtManager: add "ich9" to the list of stable audio models
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1140937

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:04:14 +02:00
Cole Robinson
9b62573c0b module_trace: Improve output for tracking mainloop libvirt usage 2014-09-13 13:52:42 -04:00
Cole Robinson
226c4562d5 virtManager: Switch to relative imports 2014-09-12 16:28:38 -04:00
Cole Robinson
3753fcbaa3 addstorage: Rate limit the default pool refresh 2014-09-12 16:28:37 -04:00
Cole Robinson
76bc8e5ab9 connection: Do initial object refreshes in a thread
None of these objects are urgent, and this allows us to split up the
initial API calls to be more parallel.
2014-09-12 16:28:37 -04:00
Cole Robinson
37e0f16c8b connection: Simplifying connection error tracking 2014-09-12 16:28:37 -04:00
Cole Robinson
df32f9331d baseclass: Add helper for launching daemon thread
And use it in a few spots
2014-09-12 16:28:37 -04:00
Cole Robinson
5041529822 domain: Cache autostart value 2014-09-12 16:28:37 -04:00
Cole Robinson
d1c22b3b2c storagepool: Don't default to refreshing volume list
This needlessly hits the network too much. The places where it's
important to have up to date info will either manually call pool
refresh, or give the user an refresh button.
2014-09-12 16:28:37 -04:00
Cole Robinson
92835f205f connection: Cache x86 cpu values at connection time 2014-09-12 16:28:37 -04:00
Cole Robinson
1662f75e07 domain: Grab snapshot info at domain init time 2014-09-12 16:28:37 -04:00
Cole Robinson
1cf4671f85 domain: Prime the XML cache when object is created 2014-09-12 16:28:37 -04:00
Cole Robinson
f36d2ed960 domain: Remove the description/title hotplug hacks
We would unconditionally read VM description/hotplug from the inactive
domain XML, this allowed us to emulate metadata hotplug where it wasn't
implemented. However this means we end up doing many needless XMLDesc
calls, which slows down connection startup for low latency connections.

Since SetMetadata has been in libvirt for 2 years now, drop this hack.
2014-09-12 16:28:37 -04:00
Cole Robinson
fb671b4d92 connection: Leave in 'connecting' state until all bits are polled 2014-09-12 16:28:37 -04:00
Cole Robinson
8d862a7b7b storagepool: Don't defer initial refresh to main thread
Otherwise this can block the UI on initial connect
2014-09-12 16:28:37 -04:00
Cole Robinson
adbe68fc7f connection: Cleanup some initial connection code 2014-09-12 16:28:37 -04:00
Cole Robinson
bd5e57dbdc connection: Simplify state management 2014-09-12 16:28:37 -04:00
Cole Robinson
b398a46e9b domain: Cache has_managed_save value
Otherwise we call it every time a domain row is selected, which makes
things choppy on remote connections.
2014-09-12 16:28:37 -04:00
Cole Robinson
f0ab054109 connection: Do mediadev setup in a thread
Otherwise a lot of XMLDesc calls are done from the main thread
at connection startup time.
2014-09-12 16:28:37 -04:00
Cole Robinson
93dde44cf0 createpool: Raise validation error if no name specified 2014-09-06 15:03:58 -04:00
Giuseppe Scrivano
9af18bf4e6 virtManager, create: re-enable distro detection with URLs
It was broken by commit 4ee97133e7

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-08-05 11:28:57 +02:00
Giuseppe Scrivano
4ee97133e7 virtManager, create: disable ISO detection with remote connections
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-08-04 12:14:32 +02:00
Giuseppe Scrivano
de8e39ba53 snapshots: alert users for unapplied changes
The UI works slightly different than with other "unapplied changes"
alerts, as it changes anyway to the selected snapshot, no matter what
the user chooses.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-08-01 09:30:21 +02:00
Giuseppe Scrivano
f5b29c0416 snapshots: allow deleting multiple snapshots
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1124818

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-08-01 09:30:21 +02:00
Giuseppe Scrivano
724c6499f0 snapshots: add button to force snapshots list refresh
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-08-01 09:30:21 +02:00
Giuseppe Scrivano
92de2db42b virtManager: always save "do not show again" setting
Any other message box performs different than "Unapplied changes",
which stores this information regardless of the user choice of
Yes/No.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1047874

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-28 19:19:17 +02:00
Giuseppe Scrivano
4ba378d1b0 virtManager, host: warn user for unapplied changes
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1047875

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-28 19:19:16 +02:00
Giuseppe Scrivano
312b349fce virt-manager, create: honor untoggled "Set a fixed MAC address"
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1083461

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-22 09:25:05 +02:00