NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2026-08-05 18:57:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,585 Commits 2 Branches 66 Tags
eb5cd8b2c942a94a3506bb6f9451deeecdb41bfe
Commit Graph
78 Commits
Author SHA1 Message Date
Cole Robinson eb5cd8b2c9 host: Drop vestiges of old VM restore support 
This hasn't been in the UI for a long time
 2018-03-15 21:24:48 -04:00
Radostin Stoyanov 4d9c6141dd Convert the output of range() to list 
In Python 2 the range() function returns a list [1].
In Python 3 the range function returns a range type [2] which
represents an immutable sequence of numbers [3].

[1] https://docs.python.org/2.7/library/functions.html#range
[2] https://docs.python.org/3/library/functions.html#func-range
[3] https://docs.python.org/3/library/stdtypes.html#typesseq-range
 2018-02-06 18:49:17 -05:00
Radostin Stoyanov 69c84bea47 Import reduce() from functools module 
The built-in function reduce() [1] has been moved in the functools
module [2] [3].

[1] https://docs.python.org/2/library/functions.html#reduce
[2] https://docs.python.org/3/library/functools.html#functools.reduce
[3] https://docs.python.org/2/library/functools.html#functools.reduce
 2017-10-20 13:18:31 -04:00
Lin Ma 083dfcc8ec host: Show details about the network of SR-IOV VF pool 
Signed-off-by: Lin Ma <lma@suse.com>
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2017-10-09 10:22:48 +02:00
Chen Hanxiao c92aade081 pycodestyle: fix all E203 warnings 
Fix all E203 whitespace before ':'
   Also remove E203 ignore option of pycodestyle

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
 2017-08-11 00:01:38 +08:00
Radostin Stoyanov b93cc3bbc9 pycodestyle: Do not use bare 'except:' 
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].

[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
 2017-08-02 13:57:43 -04:00
Cole Robinson 62feeb02a8 Switch to python3 style 'except X as Y' notation 
Which also works with python2.7
 2017-05-05 14:52:11 -04:00
Cole Robinson 2c8ed52813 Fix some pylint 2017-03-27 17:27:14 -04:00
David Thurstenson a86c119e1c Fix ambigous label on Autostart checkbox 
When the Autostart checkbox on the host Virtual Network or Storage tabs
is deselected, the label reads "Never", and when selected the label reads
"On Boot". This changes these labels to always read "On Boot".
 2017-03-22 11:53:00 -04:00
Pavel Hrdina 2d554aca7b ui: remove "Restore Saved Machine..." from File menu of Connection Details 
Commit 839ce682 removed deprecated support of save/restore which was replaced by
managedsave feature.  This is a leftover that wasn't removed together with that
commit.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1340356

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2016-05-31 13:09:48 +02:00
Pavel Hrdina c39592ae7b localization: mark several strings as translatable 
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2016-02-06 16:25:08 +01:00
Cole Robinson 23bf115024 uiutil: Rename select_list_row* to match getter functions 2015-05-19 18:29:46 -04:00
Cole Robinson fdad3efe24 uiutil: streamline column vs rowidx parameter name 2015-05-19 18:29:45 -04:00
Cole Robinson a65c1f62ec conn: Audit get_$obj callers, drop KeyError handling 
These functions don't throw KeyErrors anymore, so adjust callers that
were handling it
 2015-05-07 12:26:10 -04:00
Cole Robinson fbf841151d conn/domain: Condense the internal stats APIs 2015-05-04 18:05:54 -04:00
Cole Robinson bfcfdbf785 host: Remove some redundant connection fields 2015-04-21 16:33:41 -04:00
Cole Robinson 3d2afbaf6f connection: Allow setting a custom 'pretty name' (bz 784701) 
We've had multiple requests over the years for something similar. People
might have to connect to multiple IP addresses, or really large hostnames,
that become difficult to distinguish in the UI.

Add a field in the host details page that allows setting a custom name,
and store it in gsettings.
 2015-04-11 13:39:25 -04:00
Cole Robinson 4781ad6cd6 connection: Simplify manager row 'pretty name' handling 
Unify all the callers, and use some UI ellipsizing to handle
crazy long hostnames.

This drops the conn name collision prevention stuff which can be
useful when you have lots of similar connection names. But upcoming
patches will make it mostly redundant.
 2015-04-11 12:57:32 -04:00
Cole Robinson ee9aa0ef11 host: Don't trigger selection callbacks when conn is closing 
We already do this for storage, make sure we do it for iface + net
as well.
 2015-04-11 11:40:47 -04:00
Cole Robinson 8c107f87f9 host: Remove some redudant conn details 
And some minor UI spacing fixes
 2015-04-11 11:29:03 -04:00
Cole Robinson 6071ab0ea4 uiutil: Clarify a few ambiguous function names 2015-04-10 15:00:34 -04:00
Cole Robinson 49e3ea2cdf host: Make sure first object selected when conn connects 
Previously it was dictated by what order we received conn
signals in.
 2015-04-10 15:00:34 -04:00
Cole Robinson 3df02e8ee1 host: Fix a couple recently introduced issues 2015-04-10 15:00:34 -04:00
Cole Robinson 1e154a373d libvirtobject: Populate status up front 
And use this to kill paranoid object tick() that are sprinkled throughout
the code.
 2015-04-10 15:00:34 -04:00
Cole Robinson a3f8d73a9c libvirtobject: Unify internal status APIs and signals 
Drop config-changes vs. status-changed and just use one signal, since they
are largely the same code paths for all users.
 2015-04-10 15:00:34 -04:00
Cole Robinson 01bf07ba11 libvirtobject: Unify status signals 
Dispatch them all from the actual object and not proxied through
the connection. Use the same signal name for all objects with the same
signature.
 2015-04-10 15:00:33 -04:00
Cole Robinson a45fc36d06 host: If connection disconnects, close add* wizards 2015-04-10 15:00:33 -04:00
Cole Robinson 058c06972e Break out shared storage UI to storagelist.py (bz 1060433) 
We were already sharing a chunk of this in a haphazard way. Now officially
break it all out, similar to netlist.py. This mostly unifies the views
of host->storage and storagebrowser.py
 2015-04-09 12:31:24 -04:00
Cole Robinson 85161e4c57 host: Clean up invocation of *apply from confirm dialog 
Basically, only apply the page we are actually on
 2014-09-20 17:32:10 -04:00
Cole Robinson 0717a21f65 host: Fix renaming network/storage pool 2014-09-20 17:32:09 -04:00
Cole Robinson 226c4562d5 virtManager: Switch to relative imports 2014-09-12 16:28:38 -04:00
Cole Robinson bd5e57dbdc connection: Simplify state management 2014-09-12 16:28:37 -04:00
Giuseppe Scrivano 92de2db42b virtManager: always save "do not show again" setting 
Any other message box performs different than "Unapplied changes",
which stores this information regardless of the user choice of
Yes/No.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1047874

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-07-28 19:19:17 +02:00
Giuseppe Scrivano 4ba378d1b0 virtManager, host: warn user for unapplied changes 
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1047875

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-07-28 19:19:16 +02:00
Giuseppe Scrivano e44ee980ae virtManager: add QoS information for a network 
Add UI elements to display and modify QoS settings in the network
details.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1089117

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-07-08 00:05:09 +02:00
Cole Robinson aefd4c4824 connection: Use name instead of uuid for object keys 
And clean up the API mess while we are at it. Treat the key as an opaque
value that users shouldn't depend on.

Besides the improved code clarity and API layout, this will help diagnose
'key error' issues, since we'll see an object name instead of UUID which
is hard to trace back.
 2014-06-02 17:48:32 -04:00
Chen Hanxiao 0b21c96d34 host: fix a typo 
s/Starmode/Startmode

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-05-21 16:41:30 +08:00
Cole Robinson a398d245cb Clean up pylint integration 
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
 2014-04-02 19:00:24 -04:00
Chen Hanxiao 1d3980015a host: unselect_all members before clear model 
Interface_selected is being triggered by model.clear() in
populate_interfaces. It usually calls interface_selected
on every interface after the current selected row.

So the gtk code is probably removing the first
row over and over, and when it removes the
current selection (the interface we are deleting),
it selects the next row in line.
It will raise a KeyError.

This patch will fix this issue.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-03-14 09:04:52 +08:00
Cole Robinson 99eaf059ae Fix deprecation warnings on F21/rawhide 2014-02-25 15:57:38 -05:00
Cole Robinson 889ec18031 uiutil: Use list selection helpers everywhere 2014-01-27 10:46:14 -05:00
Cole Robinson 708a2737cf Split uihelpers into sharedui and uiutil 
Reserve uiutil for the little gtk helper functions, rest goes into shared
UI (which all should probably be factored into their own files but thats
a task for another day)
 2014-01-26 18:15:50 -05:00
Cole Robinson 58d5e0b799 uihelpers: Move a few more functions closer to their callers 2014-01-26 17:51:15 -05:00
Cole Robinson 20088ab8fb Move many shared UI functions to addhw static functions 
Much of uihelpers is just simple stuff that's shared between addhw
and details UI, so just make it staticmethods in addhw, which details
already has a reference to.
 2014-01-26 17:09:07 -05:00
Cole Robinson 62cfac18dc host: Fix looking up interfaces on repopulate signal 2014-01-17 20:23:29 -05:00
Cole Robinson d12c986b98 Use BUTTON size for all status icons 2014-01-12 14:36:03 -05:00
Cole Robinson 2a25c8d37d host: Print iscsi volume key as well in volume list 
Suggested here: http://www.redhat.com/archives/virt-tools-list/2013-December/msg00014.html
 2013-12-05 09:17:29 -05:00
Cole Robinson c351c8963a storage: Merge duplicate vol list populating 2013-12-04 19:01:52 -05:00
Giuseppe Scrivano 0df75c7603 headers: update "Red Hat, Inc." copyright for the year 2013 
Ensure that any file touched by a @redhat.com author in 2013 has an
updated copyright header.

The files were updated using the build-aux/update-copyright gnulib
script and manually added where the copyright line wasn't present.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2013-10-28 17:22:26 +01:00
Cole Robinson 8f1ea67cad Don't lose current selection if redefining net/pool/iface/snapshot 2013-09-30 19:55:21 -04:00